VirtualMedia: fix incorrect NBD export size encoding

The NBD export size is encoded as a 64-bit value (MSB/LSB) in
NBDServer.js. The previous implementation relied on JavaScript bitwise
operations (e.g. size >>> 32), which is incorrect because all bitwise
operators coerce values to 32-bit integers.

This resulted in an incorrect export size for large files, causing the
kernel to detect an invalidly large NBD device and leading nbd_client to
fail with:
  "Exported device is too big for me. Get 64-bit machine :-("

Fix the MSB calculation by using arithmetic division instead of bitwise
shifts so the exported size is encoded correctly.

Fixes: d36ac8a8be86 ("Migrate to Bootstrap 5 and remove Vue compat
plugin")

Tested: VirtualMedia on evb-ast2600.

Change-Id: I18d8cdd05cf149907d31d79cfd5308c0943ef83e
Signed-off-by: Troy Lee <troy_lee@aspeedtech.com>
Signed-off-by: Vince Chang <vince_chang@aspeedtech.com>
1 file changed
tree: f93f4594f732fa9e56f78f38eb9292197ef399f4
  1. .github/
  2. docs/
  3. public/
  4. src/
  5. tests/
  6. .browserslistrc
  7. .env.ibm
  8. .env.intel
  9. .eslintrc.js
  10. .gitattributes
  11. .gitignore
  12. .npmrc
  13. .shellcheck
  14. babel.config.js
  15. CONTRIBUTING.md
  16. format-code.sh
  17. jest.config.js
  18. LICENSE
  19. OWNERS
  20. package-lock.json
  21. package.json
  22. postcss.config.js
  23. README.md
  24. run-ci
  25. vue.config.js
README.md

webui-vue

webui-vue is a web-based user interface for the OpenBMC firmware stack built on Vue.js.

Hold on... What happened to phosphor-webui?

phosphor-webui was built on AngularJS and AngularJS went End of Life on June 30, 2021. This repository is its replacement.

When will this new Vue.js application reach feature parity with phosphor-webui?

A few, mostly minor, features remain for feature parity. See GitHub Issues label:phosphor-webui-feature-parity for the complete list.

What improvements does webui-vue have?

As mentioned, this application is built using Vue.js, a modern open-source Model-View-ViewModel JavaScript framework supported by an active community and strong documentation. It has been architected to allow organizations to easily update the theme to support their brand. This rewrite takes advantage of front-end development best practices and does not suffer from some of the anti-patterns that exist in phosphor-webui today.

Should I switch to webui-vue from phosphor-webui?

It is recommended you switch from phosphor-webui if you haven't already.

webui-vue has the following additional features:

  • Ability to easily theme to meet brand guidelines
  • Accessibility
  • Full Redfish
  • Improved user experience based on user feedback
  • Language translation-ready
  • Modern front-end framework with an active community and future development roadmap

How can I get involved?

Documentation

The documentation for coding standards and components is located in the docs directory. It is created using the VuePress static site generator. Information about how to write documentation can be found on the VuePress website.