| commit | 9fd8ac2bbe7b9364f76e4494dca2de830866ae64 | [log] [tgz] |
|---|---|---|
| author | Jason M. Bills <jason.m.bills@linux.intel.com> | Thu Oct 21 15:14:17 2021 -0700 |
| committer | Jason M. Bills <jason.m.bills@linux.intel.com> | Thu Nov 11 12:52:59 2021 -0800 |
| tree | 7b41fbdc10f348cd80378125360f6bb45088d347 | |
| parent | 0d57f4e3fa171e5c908c9f18b6fbe6730dc79f8a [diff] |
Fix issues flagged by werror This fixes the issues that are flagged by werror in preparation for enabling a meson build. Change-Id: Icf05316d21390188f84da5b59f97319e3718e728 Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>
This repository contains an OpenBMC compliant implementation of power control for x86 servers. It relies on a number of features to do its job. It has several intentional design goals.
At this point in time, this daemon targets Lewisburg based, dual socket x86 server platforms, such as S2600WFT. It is likely that other platforms will work as well.
Because this relies on the hardware passthrough support in the AST2500 to function, it requires a few patches to work correctly.
This patch adds support to UBOOT to keep the passthrough enabled https://github.com/Intel-BMC/openbmc/blob/intel/meta-openbmc-mods/meta-common/ recipes-bsp/u-boot/files/0005-enable-passthrough-in-uboot.patch
The DTS file for your platform will need the following GPIO definitions RESET_BUTTON RESET_OUT POWER_BUTTON POWER_OUT POST_COMPLETE PS_PWROK SIO_ONCONTROL SIO_POWER_GOOD SIO_S5
x86-power-control uses default json file (power-config-host0.json) for GPIO configuration. However this can be customized by producing your own power-config-host0.json file.
Definitions can be configured by two type:
For the platform having direct GPIO access can use the type GPIO and define like below.
{
"Name" : "PostComplete",
"LineName" : "POST_COMPLETE",
"Type" : "GPIO"
},
For the platform not having direct GPIO access can use dbus based event monitor by using the type DBUS.
{
"Name" : "PowerButton",
"DbusName" : "xyz.openbmc_project.Chassis.Event",
"Path" : "/xyz/openbmc_project/Chassis/Event",
"Interface" : "xyz.openbmc_project.Chassis.Event",
"Property" : "PowerButton_Host1",
"Type" : "DBUS"
},
x86-power-control will monitor the property change from the given DbusName and take appropriate action. *define Property as a bool variable.
On an aspeed, these are generally connected to E0, E1, E2, and E3 respectively. An example of this is available in the s2600WF config.
This patch allows the passthrough to be reenabled to the default condition when the appropriate pin is released. This allows power control to take control when needed by a user power action, but leave the hardware in control a majority of the time, reducing the possibility of bricking a system due to a failed BMC.
https://github.com/Intel-BMC/openbmc/blob/intel/meta-openbmc-mods/meta-ast2500/recipes-kernel/linux/linux-aspeed/0002-Enable-pass-through-on-GPIOE1-and-GPIOE3-free.patch https://github.com/Intel-BMC/openbmc/blob/intel/meta-openbmc-mods/meta-ast2500/recipes-kernel/linux/linux-aspeed/0003-Enable-GPIOE0-and-GPIOE2-pass-through-by-default.patch https://github.com/Intel-BMC/openbmc/blob/intel/meta-openbmc-mods/meta-ast2500/recipes-kernel/linux/linux-aspeed/0006-Allow-monitoring-of-power-control-input-GPIOs.patch
Caveats: This implementation does not currently implement the common targets that other implementations do. There were several attempts to, but all ended in timing issues and boot inconsistencies during stress operations.
The POST Complete GPIO is usually held asserted by BIOS after POST complete and de-asserts on reset. This de-assert behavior is currently used to detect warm resets.
Some systems are adding support for a PLT_RST eSPI signal that can be used to more accurately detect warm resets. When this option is enabled, x86-power-control will use PLT_RST to detect warm resets instead of POST Complete.