remove is_method_error call
An `is_method_error` is not appropriate after an sdbus `call` since
`call` will always throw an exception. Remove the pointless call
and instead catch the exception.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ided9cfe572ab8f60bcd4464580d7a0cba30a029d
diff --git a/src/power_control.cpp b/src/power_control.cpp
index faefe9b..f6fdf3b 100644
--- a/src/power_control.cpp
+++ b/src/power_control.cpp
@@ -2607,21 +2607,15 @@
configData.lineName.c_str());
auto reply = conn->call(method);
- if (reply.is_method_error())
- {
- lg2::error(
- "Error reading {PROPERTY} D-Bus property on interface {INTERFACE} and path {PATH}",
- "PROPERTY", configData.lineName, "INTERFACE",
- configData.interface, "PATH", configData.path);
- return -1;
- }
-
reply.read(resp);
}
catch (const sdbusplus::exception_t& e)
{
- lg2::error("Exception while reading {PROPERTY}: {WHAT}", "PROPERTY",
- configData.lineName, "WHAT", e.what());
+ lg2::error(
+ "Error reading {PROPERTY} D-Bus property on interface {INTERFACE} and path {PATH}: {WHAT}",
+ "PROPERTY", configData.lineName, "INTERFACE", configData.interface,
+ "PATH", configData.path, "WHAT", e);
+
reschedulePropertyRead(configData);
return -1;
}