meta-phosphor: initrdscripts: fix flash update
We need word splitting on IFS for this variable to prevent "watchdog:
invalid number ' 1 -T 5'" error which ruins the update (hardware
watchdog reboots the system during the process) and results in
unbootable BMC firmware after restart.
Fixes: 51d6af4e64f0 ("meta-phosphor: initrdscripts: fix shellcheck issues")
Signed-off-by: Paul Fertser <fercerpav@gmail.com>
Change-Id: Ic8d5cb8eb390075b181e2a2a73c27e0d000f6c56
diff --git a/meta-phosphor/recipes-phosphor/initrdscripts/files/obmc-shutdown.sh b/meta-phosphor/recipes-phosphor/initrdscripts/files/obmc-shutdown.sh
index 363a1a3..2de0937 100644
--- a/meta-phosphor/recipes-phosphor/initrdscripts/files/obmc-shutdown.sh
+++ b/meta-phosphor/recipes-phosphor/initrdscripts/files/obmc-shutdown.sh
@@ -43,7 +43,8 @@
if test -c /dev/watchdog
then
echo Pinging watchdog ${wdt+with args $wdt}
- watchdog "$wdt" -F /dev/watchdog &
+ # shellcheck disable=SC2086
+ watchdog $wdt -F /dev/watchdog &
wd=$!
else
wd=