commit | 5ff169f12d35c5e55ccc88d0e064d8cd39f87031 | [log] [tgz] |
---|---|---|
author | Ed Tanous <edtanous@google.com> | Tue Jan 05 16:55:36 2021 -0800 |
committer | Andrew Geissler <geissonator@yahoo.com> | Mon Jan 25 13:40:53 2021 +0000 |
tree | 297b686a785de88b0977c7aa6320b616f9682263 | |
parent | bfc3b0995fd2eb9e4553f4ce0f31fca69e3c0464 [diff] |
Add owners plugin for root The gerrit owners plugin allows much more tight grained control over what files in a repository require which approvals. This would allow OpenBMC to use the primary openbmc/openbmc repository for most recipe, distro, and conf file submissions, relying on the owners plugin to gate code checked into meta layers for which they were not allowed. At this time, this file only has the effect of automatically adding owners to gerrit reviews. It requires a separate config change to the rules.pl and project.config to start obeying these for the submissions. My intention with this commit is to first populate the OWNERS files into the subtreed meta-* directories. After that the autobump scripts will push the new changes into the main tree, and we will end up with openbmc/openbmc that now posesses OWNERS files for all the meta layers. Once that is in place, we can then enable the owners plugin on openbmc/openbmc. If it has any unintended impact, we can always roll it back, and go back to the owners plugin being non-enforcing. This commit includes the root OWNERS commit. Open questions that I suspect we can answer later and as we have more experience with this. 1. Should we set inherited to true in all cases, some cases, or never? Inherited means that directories above the one specified inherit the privileges above it, ie, the sub OWNER can merge anything in the tree below it. I suspect this will need to be a case by case basis. 2. Is there a way to specify a special OWNERS file for meta layers that we don't own (meta-oe and others) that provides messages back to the submitter automatically that they should submit their changes directly to upstream? For the moment, the permissions just roll up to the root, and require the root maintainer to comment directly, but it seems likely we could automate this. Tested: I've built a gerrit test project as a test that enables these changes, and submitted https://gerrit.openbmc-project.xyz/c/openbmc/owners-plugin-test/+/39365 and https://gerrit.openbmc-project.xyz/c/openbmc/owners-plugin-test/+/39366 As examples of both positive (should be allowed to merge) and negative (shouldn't be allowed to merge) tests. In both cases, they act as expected, where even if the negative commit is +2 code review and +1 verified, it will not be allowed to merge until the owner +2s it. signed-off-by: Ed Tanous <ed@tanous.net> Change-Id: I6f33acfd12382f8eb7cb1e9ae56046c40de18635
The OpenBMC project can be described as a Linux distribution for embedded devices that have a BMC; typically, but not limited to, things like servers, top of rack switches or RAID appliances. The OpenBMC stack uses technologies such as Yocto, OpenEmbedded, systemd, and D-Bus to allow easy customization for your server platform.
sudo apt-get install -y git build-essential libsdl1.2-dev texinfo gawk chrpath diffstat
sudo dnf install -y git patch diffstat texinfo chrpath SDL-devel bitbake \ rpcgen perl-Thread-Queue perl-bignum perl-Crypt-OpenSSL-Bignum sudo dnf groupinstall "C Development Tools and Libraries"
git clone git@github.com:openbmc/openbmc.git cd openbmc
Any build requires an environment set up according to your hardware target. There is a special script in the root of this repository that can be used to configure the environment as needed. The script is called setup
and takes the name of your hardware target as an argument.
The script needs to be sourced while in the top directory of the OpenBMC repository clone, and, if run without arguments, will display the list of supported hardware targets, see the following example:
$ . setup <machine> [build_dir] Target machine must be specified. Use one of: centriq2400-rep nicole stardragon4800-rep2 f0b olympus swift fp5280g2 olympus-nuvoton tiogapass gsj on5263m5 vesnin hr630 palmetto witherspoon hr855xg2 qemuarm witherspoon-128 lanyang quanta-q71l witherspoon-tacoma mihawk rainier yosemitev2 msn romulus zaius neptune s2600wf
Once you know the target (e.g. romulus), source the setup
script as follows:
. setup romulus build
For evb-ast2500, please use the below command to specify the machine config, because the machine in meta-aspeed
layer is in a BSP layer and does not build the openbmc image.
TEMPLATECONF=meta-evb/meta-evb-aspeed/meta-evb-ast2500/conf . openbmc-env
bitbake obmc-phosphor-image
Additional details can be found in the docs repository.
The OpenBMC community maintains a set of tutorials new users can go through to get up to speed on OpenBMC development out here
Commits submitted by members of the OpenBMC GitHub community are compiled and tested via our Jenkins server. Commits are run through two levels of testing. At the repository level the makefile make check
directive is run. At the system level, the commit is built into a firmware image and run with an arm-softmmu QEMU model against a barrage of CI tests.
Commits submitted by non-members do not automatically proceed through CI testing. After visual inspection of the commit, a CI run can be manually performed by the reviewer.
Automated testing against the QEMU model along with supported systems are performed. The OpenBMC project uses the Robot Framework for all automation. Our complete test repository can be found here.
Support of additional hardware and software packages is always welcome. Please follow the contributing guidelines when making a submission. It is expected that contributions contain test cases.
Issues are managed on GitHub. It is recommended you search through the issues before opening a new one.
First, please do a search on the internet. There's a good chance your question has already been asked.
For general questions, please use the openbmc tag on Stack Overflow. Please review the discussion on Stack Overflow licensing before posting any code.
For technical discussions, please see contact info below for Discord and mailing list information. Please don't file an issue to ask a question. You'll get faster results by using the mailing list or Discord.
Feature List
Features In Progress
Features Requested but need help
Dive deeper into OpenBMC by opening the docs repository.
The Technical Steering Committee (TSC) guides the project. Members are: