Gitiles
Code Review Sign In
gerrit.openbmc.org / stefanberger / openbmc / 81c34d5f701c47059a1c87793f5849bc909d3a75
commit81c34d5f701c47059a1c87793f5849bc909d3a75[log] [tgz]
authorAdriana Kobylak <anoo@us.ibm.com>Tue Jan 14 09:59:09 2020 -0600
committerBrad Bishop <bradleyb@fuzziesquirrel.com>Mon Feb 10 14:45:17 2020 -0500
tree8d035a91389556f91fc6958212aac8aa5ce96b99
parent0adf892516db0935d11ae7c6f76414ae72ac23aa [diff]
preinit-mounts: init: Enhance handling of overlay errors

There has been a couple instances of overlay errors: duplicated
overlay mounts, and corrupted files that live in a subdirectory.

Add the following enhancements for when an overlay error is detected:
- If the etc umount fails, do not attempt to re-mount the overlay.
  This prevents duplicate mounts.
- Check each file after re-creating the overlay, and if it still has
  errors, delete it from the overlay. This would help also in cases
  like the point above where the umount fails and the overlay was not
  recreated.
- Check all overlay files recursively instead of just the ones in the
  top directory. One instance of this corruption was seen on a file
  in a subdirectory.

Tested: Verified the script would check all files in the overlay.

(From meta-phosphor rev: 50b569209789f824b7dac8c94adb01b78c0bf3f6)

Change-Id: I570a17ec00b7d303abe4654431c0c79d3dd95c1b
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
1 file changed
tree: 8d035a91389556f91fc6958212aac8aa5ce96b99
  1. .github/
  2. meta-arm/
  3. meta-aspeed/
  4. meta-evb/
  5. meta-facebook/
  6. meta-google/
  7. meta-hxt/
  8. meta-ibm/
  9. meta-ingrasys/
  10. meta-inspur/
  11. meta-intel/
  12. meta-inventec/
  13. meta-lenovo/
  14. meta-mellanox/
  15. meta-microsoft/
  16. meta-nuvoton/
  17. meta-openembedded/
  18. meta-openpower/
  19. meta-phosphor/
  20. meta-portwell/
  21. meta-qualcomm/
  22. meta-quanta/
  23. meta-raspberrypi/
  24. meta-security/
  25. meta-x86/
  26. meta-xilinx/
  27. meta-yadro/
  28. poky/
  29. bitbake ⇨ poky/bitbake/
  30. LICENSE ⇨ poky/LICENSE
  31. meta ⇨ poky/meta
  32. meta-poky ⇨ poky/meta-poky/
  33. meta-skeleton ⇨ poky/meta-skeleton
  34. oe-init-build-env ⇨ poky/oe-init-build-env
  35. scripts ⇨ poky/scripts/
  36. .gitignore
  37. .gitreview
  38. .templateconf
  39. MAINTAINERS
  40. openbmc-env
  41. README.md
  42. setup
README.md

OpenBMC

Build Status

The OpenBMC project can be described as a Linux distribution for embedded devices that have a BMC; typically, but not limited to, things like servers, top of rack switches or RAID appliances. The OpenBMC stack uses technologies such as Yocto, OpenEmbedded, systemd, and D-Bus to allow easy customization for your server platform.

Setting up your OpenBMC project

1) Prerequisite

  • Ubuntu 14.04
sudo apt-get install -y git build-essential libsdl1.2-dev texinfo gawk chrpath diffstat
  • Fedora 28
sudo dnf install -y git patch diffstat texinfo chrpath SDL-devel bitbake \
    rpcgen perl-Thread-Queue perl-bignum perl-Crypt-OpenSSL-Bignum
sudo dnf groupinstall "C Development Tools and Libraries"

2) Download the source

git clone git@github.com:openbmc/openbmc.git
cd openbmc

3) Target your hardware

Any build requires an environment variable known as TEMPLATECONF to be set to a hardware target. You can see all of the known targets with find meta-* -name local.conf.sample. Choose the hardware target and then move to the next step. Additional examples can be found in the OpenBMC Cheatsheet

MachineTEMPLATECONF
Palmettometa-ibm/meta-palmetto/conf
Zaiusmeta-ingrasys/meta-zaius/conf
Witherspoonmeta-ibm/meta-witherspoon/conf
Romulusmeta-ibm/meta-romulus/conf

As an example target Romulus

export TEMPLATECONF=meta-ibm/meta-romulus/conf

4) Build

. openbmc-env
bitbake obmc-phosphor-image

Additional details can be found in the docs repository.

OpenBMC Development

The OpenBMC community maintains a set of tutorials new users can go through to get up to speed on OpenBMC development out here

Build Validation and Testing

Commits submitted by members of the OpenBMC GitHub community are compiled and tested via our Jenkins server. Commits are run through two levels of testing. At the repository level the makefile make check directive is run. At the system level, the commit is built into a firmware image and run with an arm-softmmu QEMU model against a barrage of CI tests.

Commits submitted by non-members do not automatically proceed through CI testing. After visual inspection of the commit, a CI run can be manually performed by the reviewer.

Automated testing against the QEMU model along with supported systems are performed. The OpenBMC project uses the Robot Framework for all automation. Our complete test repository can be found here.

Submitting Patches

Support of additional hardware and software packages is always welcome. Please follow the contributing guidelines when making a submission. It is expected that contributions contain test cases.

Bug Reporting

Issues are managed on GitHub. It is recommended you search through the issues before opening a new one.

Questions

First, please do a search on the internet. There's a good chance your question has already been asked.

For general questions, please use the openbmc tag on Stack Overflow. Please review the discussion on Stack Overflow licensing before posting any code.

For technical discussions, please see contact info below for IRC and mailing list information. Please don't file an issue to ask a question. You'll get faster results by using the mailing list or IRC.

Features of OpenBMC

Feature List

  • Host management: Power, Cooling, LEDs, Inventory, Events, Watchdog
  • Full IPMI 2.0 Compliance with DCMI
  • Code Update Support for multiple BMC/BIOS images
  • Web-based user interface
  • REST interfaces
  • D-Bus based interfaces
  • SSH based SOL
  • Remote KVM
  • Hardware Simulation
  • Automated Testing
  • User management
  • Virtual media

Features In Progress

  • OpenCompute Redfish Compliance
  • Verified Boot

Features Requested but need help

  • OpenBMC performance monitoring

Finding out more

Dive deeper into OpenBMC by opening the docs repository.

Technical Steering Committee

The Technical Steering Committee (TSC) guides the project. Members are:

  • Brad Bishop (chair), IBM
  • Nancy Yuen, Google
  • Sai Dasari, Facebook
  • James Mihm, Intel
  • Sagar Dharia, Microsoft
  • Supreeth Venkatesh, Arm

Contact