Andrew Geissler | 3eeda90 | 2023-05-19 10:14:02 -0500 | [diff] [blame] | 1 | From 341e19dd69d847f84859e85cabff5846e7da24c4 Mon Sep 17 00:00:00 2001 |
| 2 | From: Trevor Gamblin <tgamblin@baylibre.com> |
| 3 | Date: Mon, 15 May 2023 09:26:04 -0400 |
| 4 | Subject: [PATCH] pylint: remove plugin pickle test |
| 5 | |
| 6 | Upstream-Status: Inappropriate (oe-specific) |
| 7 | |
| 8 | Upstream uses an assertion in the removed test to state that the test |
| 9 | needs changing if the plugin loading succeeds. The same failure wasn't |
| 10 | seen when running the tests on the host with pytest, so disable it by |
| 11 | removing the test from the suite. |
| 12 | |
| 13 | Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com> |
| 14 | --- |
| 15 | tests/test_check_parallel.py | 22 ---------------------- |
| 16 | 1 file changed, 22 deletions(-) |
| 17 | |
| 18 | diff --git a/tests/test_check_parallel.py b/tests/test_check_parallel.py |
| 19 | index d56502eaf..34fec140f 100644 |
| 20 | --- a/tests/test_check_parallel.py |
| 21 | +++ b/tests/test_check_parallel.py |
| 22 | @@ -257,28 +257,6 @@ class TestCheckParallelFramework: |
| 23 | assert stats.statement == 18 |
| 24 | assert stats.warning == 0 |
| 25 | |
| 26 | - def test_linter_with_unpickleable_plugins_is_pickleable(self) -> None: |
| 27 | - """The linter needs to be pickle-able in order to be passed between workers""" |
| 28 | - linter = PyLinter(reporter=Reporter()) |
| 29 | - # We load an extension that we know is not pickle-safe |
| 30 | - linter.load_plugin_modules(["pylint.extensions.overlapping_exceptions"]) |
| 31 | - try: |
| 32 | - dill.dumps(linter) |
| 33 | - raise AssertionError( |
| 34 | - "Plugins loaded were pickle-safe! This test needs altering" |
| 35 | - ) |
| 36 | - except (KeyError, TypeError, PickleError, NotImplementedError): |
| 37 | - pass |
| 38 | - |
| 39 | - # And expect this call to make it pickle-able |
| 40 | - linter.load_plugin_configuration() |
| 41 | - try: |
| 42 | - dill.dumps(linter) |
| 43 | - except KeyError as exc: |
| 44 | - raise AssertionError( |
| 45 | - "Cannot pickle linter when using non-pickleable plugin" |
| 46 | - ) from exc |
| 47 | - |
| 48 | def test_worker_check_sequential_checker(self) -> None: |
| 49 | """Same as test_worker_check_single_file_no_checkers with SequentialTestChecker.""" |
| 50 | linter = PyLinter(reporter=Reporter()) |
| 51 | -- |
| 52 | 2.40.1 |
| 53 | |