Brad Bishop | 996bc45 | 2019-12-02 13:05:15 -0500 | [diff] [blame] | 1 | From 87df05c3f83c563af76ab00567e7a1ab7a6ebc88 Mon Sep 17 00:00:00 2001 |
| 2 | From: Peter Rosin <peda@axentia.se> |
| 3 | Date: Sat, 9 Nov 2019 15:42:03 +0100 |
| 4 | Subject: [PATCH] dbus: avoid 'strange' chars from the build dir in #defines |
| 5 | |
| 6 | gdbus-codegen uses include guards with the full path dir, and if there |
| 7 | are "bad" characters, such as '+', this fails miserably. E.g. Yocto has a |
| 8 | tendency to build in directories named from the Yocto package version and |
| 9 | that package version containing a '+' are not uncommon, and even the |
| 10 | standard in certain scenarios such as when using ${SRCPV}. |
| 11 | |
| 12 | Avoid the problem of the full path "leaking" into the source by avoiding |
| 13 | the normal include guards and request "#pragma once" instead. |
| 14 | |
| 15 | Signed-off-by: Peter Rosin <peda@axentia.se> |
| 16 | --- |
| 17 | dbus/CMakeLists.txt | 12 ++++++------ |
| 18 | 1 file changed, 6 insertions(+), 6 deletions(-) |
| 19 | |
| 20 | diff --git a/dbus/CMakeLists.txt b/dbus/CMakeLists.txt |
| 21 | index f5096ce10ecd..013c32239e12 100644 |
| 22 | --- a/dbus/CMakeLists.txt |
| 23 | +++ b/dbus/CMakeLists.txt |
| 24 | @@ -43,37 +43,37 @@ else() |
| 25 | endif() |
| 26 | |
| 27 | add_custom_command(OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/org-bluez-adaptater1.c |
| 28 | - COMMAND gdbus-codegen --interface-prefix org.bluez.Adapter1. --generate-c-code ${CMAKE_CURRENT_BINARY_DIR}/org-bluez-adaptater1 ${CMAKE_CURRENT_SOURCE_DIR}/${DBUS_BLUEZ_API}/org.bluez.Adapter1.xml |
| 29 | + COMMAND gdbus-codegen --pragma-once --interface-prefix org.bluez.Adapter1. --generate-c-code ${CMAKE_CURRENT_BINARY_DIR}/org-bluez-adaptater1 ${CMAKE_CURRENT_SOURCE_DIR}/${DBUS_BLUEZ_API}/org.bluez.Adapter1.xml |
| 30 | DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/${DBUS_BLUEZ_API}/org.bluez.Adapter1.xml |
| 31 | COMMENT "Generate D-Bus 'org.bluez.Adapter1.xml'" |
| 32 | ) |
| 33 | |
| 34 | add_custom_command(OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/org-bluez-device1.c |
| 35 | - COMMAND gdbus-codegen --interface-prefix org.bluez.Device1. --generate-c-code ${CMAKE_CURRENT_BINARY_DIR}/org-bluez-device1 ${CMAKE_CURRENT_SOURCE_DIR}/${DBUS_BLUEZ_API}/org.bluez.Device1.xml |
| 36 | + COMMAND gdbus-codegen --pragma-once --interface-prefix org.bluez.Device1. --generate-c-code ${CMAKE_CURRENT_BINARY_DIR}/org-bluez-device1 ${CMAKE_CURRENT_SOURCE_DIR}/${DBUS_BLUEZ_API}/org.bluez.Device1.xml |
| 37 | DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/${DBUS_BLUEZ_API}/org.bluez.Device1.xml |
| 38 | COMMENT "Generate D-Bus 'org.bluez.Device1.xml'" |
| 39 | ) |
| 40 | |
| 41 | add_custom_command(OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/org-bluez-gattservice1.c |
| 42 | - COMMAND gdbus-codegen --interface-prefix org.bluez.GattService1. --generate-c-code ${CMAKE_CURRENT_BINARY_DIR}/org-bluez-gattservice1 ${CMAKE_CURRENT_SOURCE_DIR}/${DBUS_BLUEZ_API}/org.bluez.GattService1.xml |
| 43 | + COMMAND gdbus-codegen --pragma-once --interface-prefix org.bluez.GattService1. --generate-c-code ${CMAKE_CURRENT_BINARY_DIR}/org-bluez-gattservice1 ${CMAKE_CURRENT_SOURCE_DIR}/${DBUS_BLUEZ_API}/org.bluez.GattService1.xml |
| 44 | DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/${DBUS_BLUEZ_API}/org.bluez.GattService1.xml |
| 45 | COMMENT "Generate D-Bus 'org.bluez.GattService1.xml'" |
| 46 | ) |
| 47 | |
| 48 | add_custom_command(OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/org-bluez-gattcharacteristic1.c |
| 49 | - COMMAND gdbus-codegen --interface-prefix org.bluez.Characteristic1. --generate-c-code ${CMAKE_CURRENT_BINARY_DIR}/org-bluez-gattcharacteristic1 ${CMAKE_CURRENT_SOURCE_DIR}/${DBUS_BLUEZ_API}/org.bluez.GattCharacteristic1.xml |
| 50 | + COMMAND gdbus-codegen --pragma-once --interface-prefix org.bluez.Characteristic1. --generate-c-code ${CMAKE_CURRENT_BINARY_DIR}/org-bluez-gattcharacteristic1 ${CMAKE_CURRENT_SOURCE_DIR}/${DBUS_BLUEZ_API}/org.bluez.GattCharacteristic1.xml |
| 51 | DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/${DBUS_BLUEZ_API}/org.bluez.GattCharacteristic1.xml |
| 52 | COMMENT "Generate D-Bus 'org.bluez.GattCharacteristic1.xml'" |
| 53 | ) |
| 54 | |
| 55 | add_custom_command(OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/org-bluez-gattdescriptor1.c |
| 56 | - COMMAND gdbus-codegen --interface-prefix org.bluez.Descriptor1. --generate-c-code ${CMAKE_CURRENT_BINARY_DIR}/org-bluez-gattdescriptor1 ${CMAKE_CURRENT_SOURCE_DIR}/${DBUS_BLUEZ_API}/org.bluez.GattDescriptor1.xml |
| 57 | + COMMAND gdbus-codegen --pragma-once --interface-prefix org.bluez.Descriptor1. --generate-c-code ${CMAKE_CURRENT_BINARY_DIR}/org-bluez-gattdescriptor1 ${CMAKE_CURRENT_SOURCE_DIR}/${DBUS_BLUEZ_API}/org.bluez.GattDescriptor1.xml |
| 58 | DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/${DBUS_BLUEZ_API}/org.bluez.GattDescriptor1.xml |
| 59 | COMMENT "Generate D-Bus 'org.bluez.GattDescriptor1.xml'" |
| 60 | ) |
| 61 | |
| 62 | add_custom_command(OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/org-bluez-battery1.c |
| 63 | - COMMAND gdbus-codegen --interface-prefix org.bluez.Battery1. --generate-c-code ${CMAKE_CURRENT_BINARY_DIR}/org-bluez-battery1 ${CMAKE_CURRENT_SOURCE_DIR}/${DBUS_BLUEZ_API}/org.bluez.Battery1.xml |
| 64 | + COMMAND gdbus-codegen --pragma-once --interface-prefix org.bluez.Battery1. --generate-c-code ${CMAKE_CURRENT_BINARY_DIR}/org-bluez-battery1 ${CMAKE_CURRENT_SOURCE_DIR}/${DBUS_BLUEZ_API}/org.bluez.Battery1.xml |
| 65 | DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/${DBUS_BLUEZ_API}/org.bluez.Battery1.xml |
| 66 | COMMENT "Generate D-Bus 'org.bluez.Battery1.xml'" |
| 67 | ) |
| 68 | -- |
| 69 | 2.11.0 |
| 70 | |