Ed Tanous | d5cea14 | 2021-09-09 11:42:05 -0700 | [diff] [blame] | 1 | #!/bin/bash -e |
| 2 | # |
| 3 | |
Ed Tanous | 7f8954e | 2021-09-09 11:46:43 -0700 | [diff] [blame] | 4 | script_dir="$( cd "$( dirname "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )" |
| 5 | obmc_dir=${script_dir}/../../ |
| 6 | |
Patrick Williams | 12a27b2 | 2021-10-26 16:07:31 -0500 | [diff] [blame] | 7 | cd "$obmc_dir" |
| 8 | |
Ed Tanous | 7f8954e | 2021-09-09 11:46:43 -0700 | [diff] [blame] | 9 | # openbmc doesn't control what upstream poky, or any of the other layers do, |
| 10 | # which do use patches as part of their upstreaming process. |
| 11 | # meta-phosphor is also included such that patches that the community agrees to |
| 12 | # hold onto will be allowed in that layer. |
| 13 | |
| 14 | patch_files_tmp=$(mktemp) |
| 15 | allowed_patches_tmp=$(mktemp) |
Patrick Williams | 693d3db | 2021-10-26 16:10:20 -0500 | [diff] [blame] | 16 | trap 'rm $patch_files_tmp $allowed_patches_tmp' exit |
Ed Tanous | 7f8954e | 2021-09-09 11:46:43 -0700 | [diff] [blame] | 17 | |
Patrick Williams | 12a27b2 | 2021-10-26 16:07:31 -0500 | [diff] [blame] | 18 | git ls-files -- \ |
Ed Tanous | 7f8954e | 2021-09-09 11:46:43 -0700 | [diff] [blame] | 19 | '*.patch' \ |
| 20 | ':!:poky/**' \ |
Brad Bishop | bec4ebc | 2022-08-03 09:55:16 -0400 | [diff] [blame] | 21 | ':!:meta-arm/**' \ |
Ed Tanous | 7f8954e | 2021-09-09 11:46:43 -0700 | [diff] [blame] | 22 | ':!:meta-security/**' \ |
Ed Tanous | 7f8954e | 2021-09-09 11:46:43 -0700 | [diff] [blame] | 23 | ':!:meta-raspberrypi/**' \ |
| 24 | ':!:meta-openembedded/**' \ |
| 25 | ':!:meta-phosphor/**' \ |
Patrick Williams | 693d3db | 2021-10-26 16:10:20 -0500 | [diff] [blame] | 26 | | sort > "$patch_files_tmp" |
Ed Tanous | 7f8954e | 2021-09-09 11:46:43 -0700 | [diff] [blame] | 27 | |
| 28 | |
| 29 | # The following patches were present on master at the time this test was |
| 30 | # written. Their presence in this list should not be acknowlegement that they |
| 31 | # are now allowed, but ignoring them is required in the intermediate time |
| 32 | # between when this test was created, and when the maintainers of these repos |
| 33 | # clean them up. |
| 34 | # |
| 35 | # https://github.com/openbmc/docs/blob/master/meta-layer-guidelines.md |
| 36 | echo "\ |
Ed Tanous | 7f8954e | 2021-09-09 11:46:43 -0700 | [diff] [blame] | 37 | meta-aspeed/recipes-bsp/u-boot/files/default-gcc.patch |
Ed Tanous | 7f8954e | 2021-09-09 11:46:43 -0700 | [diff] [blame] | 38 | meta-bytedance/meta-g220a/recipes-kernel/linux/linux-aspeed/0005-ARM-dts-aspeed-Enable-g220a-uart-route.patch |
Logananth Sundararaj | 971257a | 2022-03-23 17:34:12 +0530 | [diff] [blame] | 39 | meta-facebook/meta-yosemitev2/recipes-bsp/u-boot/u-boot-aspeed-sdk/0001-board-aspeed-Add-Mux-for-yosemitev2.patch |
| 40 | meta-facebook/meta-yosemitev2/recipes-bsp/u-boot/u-boot-aspeed-sdk/0002-spl-host-console-handle.patch |
Ed Tanous | 7f8954e | 2021-09-09 11:46:43 -0700 | [diff] [blame] | 41 | meta-google/dynamic-layers/nuvoton-layer/recipes-bsp/images/npcm7xx-igps/0001-Set-FIU0_DRD_CFG-and-FIU_Clk_divider-for-gbmc-hoth.patch |
| 42 | meta-google/recipes-extended/libconfig/files/0001-conf2struct-Use-the-right-perl.patch |
| 43 | meta-google/recipes-extended/libconfig/files/0001-makefile-Add-missing-LDFLAGS.patch |
| 44 | meta-google/recipes-phosphor/initrdscripts/obmc-phosphor-initfs/rwfs-clean-dev.patch |
| 45 | meta-ingrasys/meta-zaius/recipes-bsp/u-boot/u-boot-aspeed/0001-board-aspeed-Add-reset_phy-for-Zaius.patch |
| 46 | meta-nuvoton/recipes-bsp/images/npcm7xx-igps/0001-Adjust-paths-for-use-with-Bitbake.patch |
| 47 | meta-yadro/meta-nicole/recipes-bsp/u-boot/files/0001-Add-system-reset-status-support.patch |
| 48 | meta-yadro/meta-nicole/recipes-bsp/u-boot/files/0002-config-ast-common-set-fieldmode-to-true.patch |
| 49 | meta-yadro/meta-nicole/recipes-bsp/u-boot/files/0003-aspeed-add-gpio-support.patch |
| 50 | meta-yadro/meta-nicole/recipes-bsp/u-boot/files/0004-aspeed-add-bmc-position-support.patch |
| 51 | meta-yadro/meta-nicole/recipes-kernel/linux/linux-aspeed/0001-Add-NCSI-channel-selector.patch |
| 52 | meta-yadro/meta-nicole/recipes-phosphor/host/op-proc-control/0001-Stop-and-send-SRESET-for-one-thread-only.patch |
| 53 | meta-yadro/recipes-phosphor/dbus/phosphor-dbus-interfaces/0001-Add-boot-initiator-mailbox-interface.patch |
| 54 | meta-yadro/recipes-phosphor/ipmi/phosphor-ipmi-host/0001-Add-support-for-persistent-only-settings.patch |
| 55 | meta-yadro/recipes-phosphor/ipmi/phosphor-ipmi-host/0002-Add-support-for-boot-initiator-mailbox.patch |
| 56 | meta-yadro/recipes-phosphor/ipmi/phosphor-ipmi-host/0003-Fix-version-parsing-update-AUX-revision-info.patch |
Patrick Williams | 693d3db | 2021-10-26 16:10:20 -0500 | [diff] [blame] | 57 | " | sort > "$allowed_patches_tmp" |
Ed Tanous | 7f8954e | 2021-09-09 11:46:43 -0700 | [diff] [blame] | 58 | |
Patrick Williams | 693d3db | 2021-10-26 16:10:20 -0500 | [diff] [blame] | 59 | files_diff=$(comm -23 "$patch_files_tmp" "$allowed_patches_tmp") |
Ed Tanous | 7f8954e | 2021-09-09 11:46:43 -0700 | [diff] [blame] | 60 | |
Ed Tanous | 4734c22 | 2021-09-20 11:11:34 -0700 | [diff] [blame] | 61 | files_count=$(echo -n "$files_diff" | grep -c '^' || true) |
Ed Tanous | 7f8954e | 2021-09-09 11:46:43 -0700 | [diff] [blame] | 62 | if [[ $files_count -ne 0 ]]; then |
| 63 | echo "Patch files found not in allow list" |
| 64 | echo "$files_diff" |
| 65 | echo "Patches are not allowed on OpenBMC in these layers. Please upstream your changes and see \ |
| 66 | https://github.com/openbmc/docs/blob/master/meta-layer-guidelines.md" |
| 67 | exit 1 |
| 68 | fi |
| 69 | |
Andrew Geissler | fc32817 | 2022-01-21 09:37:06 -0600 | [diff] [blame] | 70 | # Now verify there are no kernel dts files being added in a patch |
| 71 | # All dts files should be sent upstream and can be carried in the openbmc/linux |
| 72 | # tree until they are accepted upstream |
| 73 | dts_files_tmp=$(mktemp) |
| 74 | allowed_dts_tmp=$(mktemp) |
| 75 | trap 'rm $dts_files_tmp $allowed_dts_tmp' exit |
| 76 | |
| 77 | git ls-files -- \ |
| 78 | '*.dts' \ |
| 79 | ':!:poky/**' \ |
Brad Bishop | bec4ebc | 2022-08-03 09:55:16 -0400 | [diff] [blame] | 80 | ':!:meta-arm/**' \ |
Andrew Geissler | fc32817 | 2022-01-21 09:37:06 -0600 | [diff] [blame] | 81 | ':!:meta-security/**' \ |
| 82 | ':!:meta-raspberrypi/**' \ |
| 83 | ':!:meta-openembedded/**' \ |
| 84 | | sort > "$dts_files_tmp" |
| 85 | |
| 86 | # There is a single dts currently in the tree that we will exempt for now |
| 87 | echo "\ |
| 88 | meta-hpe/meta-dl360poc/recipes-kernel/linux/linux-obmc/gxp.dts |
| 89 | " | sort > "$allowed_dts_tmp" |
| 90 | |
| 91 | files_diff=$(comm -23 "$dts_files_tmp" "$allowed_dts_tmp") |
| 92 | |
| 93 | files_count=$(echo -n "$files_diff" | grep -c '^' || true) |
| 94 | if [[ $files_count -ne 0 ]]; then |
| 95 | echo "Dts files found not in allow list" |
| 96 | echo "$files_diff" |
| 97 | echo "Dts files are not allowed on OpenBMC in these layers. Please upstream your changes and see \ |
| 98 | https://github.com/openbmc/docs/blob/master/kernel-development.md" |
| 99 | exit 1 |
| 100 | fi |
| 101 | |
Patrick Williams | 12a27b2 | 2021-10-26 16:07:31 -0500 | [diff] [blame] | 102 | lint_exempt="\ |
| 103 | meta-amd/recipes-amd/amd-fpga/files/ethanolx/fpgardu.sh |
Patrick Williams | 12a27b2 | 2021-10-26 16:07:31 -0500 | [diff] [blame] | 104 | meta-bytedance/meta-g220a/recipes-network/network/static-mac-addr/mac-check |
| 105 | meta-bytedance/meta-g220a/recipes-phosphor/datetime/me-time-sync/me-time-sync.sh |
Patrick Williams | 12a27b2 | 2021-10-26 16:07:31 -0500 | [diff] [blame] | 106 | meta-google/recipes-google/gpio/gpio-ctrl/lib.sh |
| 107 | meta-google/recipes-google/host-power-ctrl/gpio-host-pwr/host_isoff.sh |
| 108 | meta-google/recipes-google/host-power-ctrl/gpio-host-pwr/host_powercycle.sh |
| 109 | meta-google/recipes-google/host-power-ctrl/gpio-host-pwr/host_poweroff.sh |
| 110 | meta-google/recipes-google/host-power-ctrl/gpio-host-pwr/host_poweron.sh |
| 111 | meta-google/recipes-google/host-power-ctrl/gpio-host-pwr/host_reset.sh |
| 112 | meta-google/recipes-google/host-power-ctrl/gpio-host-pwr/lib.sh |
| 113 | meta-google/recipes-google/ipmi/ipmi-fru-sh/lib.sh |
| 114 | meta-google/recipes-google/ncsi/files/gbmc-ncsi-ip-from-ra.sh.in |
| 115 | meta-google/recipes-google/networking/files/gbmc-ip-monitor-test.sh |
| 116 | meta-google/recipes-google/networking/files/gbmc-ip-monitor.sh |
| 117 | meta-google/recipes-google/networking/files/gbmc-mac-config.sh.in |
Patrick Williams | 521d8f6 | 2021-10-27 09:30:41 -0500 | [diff] [blame] | 118 | meta-google/recipes-google/networking/gbmc-bridge/gbmc-br-from-ra.sh |
| 119 | meta-google/recipes-google/networking/gbmc-bridge/gbmc-br-gw-src.sh |
| 120 | meta-google/recipes-google/networking/gbmc-bridge/gbmc-br-nft.sh |
| 121 | meta-google/recipes-google/networking/gbmc-bridge/gbmc-br-ula.sh |
Patrick Williams | 12a27b2 | 2021-10-26 16:07:31 -0500 | [diff] [blame] | 122 | meta-google/recipes-google/networking/google-usb-network/usb_network.sh |
| 123 | meta-google/recipes-google/networking/google-usb-network/usb_network_test.sh |
| 124 | meta-google/recipes-google/networking/network-sh/lib.sh |
| 125 | meta-google/recipes-google/networking/network-sh/test.sh |
| 126 | meta-google/recipes-google/nftables/files/nft-configure.sh |
| 127 | meta-google/recipes-google/ssh/authorized-keys-comp/authorized-keys-comp.sh |
| 128 | meta-google/recipes-google/test/test-sh/test.sh |
| 129 | meta-google/recipes-phosphor/flash/google-key/verify-bmc-image.sh |
| 130 | meta-google/recipes-phosphor/flash/inplace-gbmc-update/inplace-gbmc-verify.sh |
| 131 | meta-hpe/meta-common/recipes-hpe/host/host-boot-enable/host-boot-enable.sh |
| 132 | meta-hpe/meta-common/recipes-phosphor/initrdscripts/files/gxp-obmc-init.sh |
| 133 | meta-hpe/meta-dl360poc/recipes-hpe/host/host-boot-enable/host-boot-enable.sh |
| 134 | meta-ibm/meta-romulus/recipes-phosphor/chassis/vrm-control/vrm-control.sh |
| 135 | meta-ibm/meta-romulus/recipes-phosphor/gpio/id-button/toggle_identify_led.sh |
| 136 | meta-ibm/recipes-phosphor/chassis/power-workarounds/witherspoon/power-workarounds.sh |
| 137 | meta-ibm/recipes-phosphor/chassis/vrm-control/ibm-ac-server/ir35221-unbind-bind.sh |
Patrick Williams | 12a27b2 | 2021-10-26 16:07:31 -0500 | [diff] [blame] | 138 | meta-ibm/recipes-phosphor/chassis/vrm-control/vrm-control.sh |
| 139 | meta-ibm/recipes-phosphor/dump/phosphor-debug-collector/plugins.d/ibm_elogall |
| 140 | meta-ibm/recipes-phosphor/dump/phosphor-debug-collector/plugins.d/pels |
| 141 | meta-ibm/recipes-phosphor/gpio/id-button/toggle_identify_led.sh |
| 142 | meta-ibm/recipes-phosphor/mboxd/mboxd/check_pnor_format.sh |
| 143 | meta-ingrasys/meta-zaius/recipes-phosphor/chassis/avsbus-control/zaius_avsbus.sh |
| 144 | meta-ingrasys/meta-zaius/recipes-phosphor/chassis/vcs-control/zaius_vcs.sh |
| 145 | meta-inventec/meta-transformers/recipes-phosphor/init/transformers-init/transformers-init.sh |
Patrick Williams | 521d8f6 | 2021-10-27 09:30:41 -0500 | [diff] [blame] | 146 | meta-openpower/recipes-bsp/pdata/files/power-target.sh |
Patrick Williams | 12a27b2 | 2021-10-26 16:07:31 -0500 | [diff] [blame] | 147 | meta-openpower/recipes-phosphor/dump/phosphor-debug-collector/plugins.d/guard |
| 148 | meta-openpower/recipes-phosphor/network/first-boot-set-hostname/first-boot-set-hostname.sh |
| 149 | meta-openpower/recipes-phosphor/network/first-boot-set-mac/first-boot-set-mac.sh |
| 150 | meta-openpower/recipes-phosphor/occ/openpower-occ-control/occ-active.sh |
| 151 | meta-phosphor/recipes-phosphor/initrdscripts/files/obmc-init.sh |
| 152 | meta-phosphor/recipes-phosphor/initrdscripts/files/obmc-shutdown.sh |
| 153 | meta-phosphor/recipes-phosphor/initrdscripts/files/obmc-update.sh |
| 154 | meta-phosphor/recipes-phosphor/initrdscripts/phosphor-mmc-init/mmc-init.sh |
| 155 | meta-phosphor/recipes-phosphor/interfaces/bmcweb/run-ptest |
Patrick Williams | 12a27b2 | 2021-10-26 16:07:31 -0500 | [diff] [blame] | 156 | meta-phosphor/recipes-support/nss-pam-ldapd/files/nslcd.init |
Patrick Williams | 12a27b2 | 2021-10-26 16:07:31 -0500 | [diff] [blame] | 157 | meta-quanta/meta-common/recipes-quanta/network/usb-network/usb-network.sh |
| 158 | meta-quanta/meta-gbs/recipes-gbs/gbs-bios-update/files/bios-update.sh |
| 159 | meta-quanta/meta-gbs/recipes-gbs/gbs-bios-update/files/bios-verify.sh |
| 160 | meta-quanta/meta-gbs/recipes-gbs/gbs-bmc-update/files/bmc-verify.sh |
| 161 | meta-quanta/meta-gbs/recipes-gbs/gbs-detect-gpio-present/files/detect-gpio-present.sh |
| 162 | meta-quanta/meta-gbs/recipes-gbs/gbs-sysinit/files/gbs-sysinit.sh |
| 163 | meta-quanta/meta-gbs/recipes-gbs/hotswap-power-cycle/files/tray_powercycle.sh |
| 164 | meta-quanta/meta-gbs/recipes-google/acpi-power-state/acpi-power-state-daemon/gbs-check-host-state.sh |
| 165 | meta-quanta/meta-gbs/recipes-google/acpi-power-state/acpi-power-state-daemon/gbs-set-failsafe.sh |
| 166 | meta-quanta/meta-gbs/recipes-phosphor/fans/phosphor-pid-control/fan-table-init.sh |
| 167 | meta-quanta/meta-gbs/recipes-phosphor/sensors/phosphor-nvme/nvme_json_rewrite.sh |
| 168 | meta-quanta/meta-gsj/recipes-gsj/detect-fan-fail/files/detect-fan-fail.sh |
| 169 | meta-quanta/meta-gsj/recipes-gsj/gsj-hotswap-change-setting/files/gsj-hotswap-change-setting.sh |
| 170 | meta-quanta/meta-gsj/recipes-gsj/quanta-nvme-powerctrl/files/init_once.sh |
| 171 | meta-quanta/meta-gsj/recipes-gsj/quanta-nvme-powerctrl/files/nvme_powerctrl_library.sh |
| 172 | meta-quanta/meta-gsj/recipes-gsj/quanta-nvme-powerctrl/files/nvme_powermanager.sh |
| 173 | meta-quanta/meta-gsj/recipes-gsj/usb-network/files/usb_network.sh |
| 174 | meta-quanta/meta-gsj/recipes-phosphor/fans/phosphor-pid-control/fan-control.sh |
Patrick Williams | 521d8f6 | 2021-10-27 09:30:41 -0500 | [diff] [blame] | 175 | meta-quanta/meta-gsj/recipes-phosphor/fans/phosphor-pid-control/fan-default-speed.sh |
Patrick Williams | 12a27b2 | 2021-10-26 16:07:31 -0500 | [diff] [blame] | 176 | meta-quanta/meta-olympus-nuvoton/recipes-olympus-nuvoton/power/first-boot-set-psu/first-boot-set-psu.sh |
Patrick Williams | 521d8f6 | 2021-10-27 09:30:41 -0500 | [diff] [blame] | 177 | meta-quanta/meta-olympus-nuvoton/recipes-phosphor/fans/phosphor-pid-control/fan-full-speed.sh |
Patrick Williams | 12a27b2 | 2021-10-26 16:07:31 -0500 | [diff] [blame] | 178 | meta-quanta/meta-q71l/recipes-phosphor/quanta-powerctrl/files/init_once.sh |
| 179 | meta-quanta/meta-q71l/recipes-phosphor/quanta-powerctrl/files/poweroff.sh |
| 180 | meta-quanta/meta-q71l/recipes-phosphor/quanta-powerctrl/files/poweron.sh |
| 181 | meta-yadro/meta-nicole/recipes-phosphor/chassis/avsbus-control/avsbus-control.sh |
Patrick Williams | 12a27b2 | 2021-10-26 16:07:31 -0500 | [diff] [blame] | 182 | " |
| 183 | |
Patrick Williams | 2ed00d8 | 2021-10-27 09:33:53 -0500 | [diff] [blame] | 184 | types=(json shell) |
| 185 | # shellcheck disable=SC2034 |
| 186 | check_json="eslint --resolve-plugins-relative-to /usr/local/lib/node_modules" |
Patrick Williams | 521d8f6 | 2021-10-27 09:30:41 -0500 | [diff] [blame] | 187 | # shellcheck disable=SC2034 |
| 188 | check_shell="shellcheck -x" |
| 189 | |
| 190 | for t in "${types[@]}"; do |
| 191 | check_cmd="check_${t}" |
| 192 | if ! which "${!check_cmd%% *}" > /dev/null 2>&1; then |
| 193 | eval "${check_cmd}=\"echo WARNING: Skipping $t due to missing command:\"" |
| 194 | echo "${!check_cmd}" |
| 195 | fi |
| 196 | done |
| 197 | |
Patrick Williams | 12a27b2 | 2021-10-26 16:07:31 -0500 | [diff] [blame] | 198 | non_bbfiles=$(git ls-files -- \ |
| 199 | ':!:poky/**' \ |
Brad Bishop | bec4ebc | 2022-08-03 09:55:16 -0400 | [diff] [blame] | 200 | ':!:meta-arm/**' \ |
Patrick Williams | 12a27b2 | 2021-10-26 16:07:31 -0500 | [diff] [blame] | 201 | ':!:meta-security/**' \ |
| 202 | ':!:meta-raspberrypi/**' \ |
| 203 | ':!:meta-openembedded/**' \ |
| 204 | | grep -v -e "\.patch$" -e "\.bb$" -e "\.bbappend$") |
| 205 | |
| 206 | for f in $non_bbfiles; do |
Patrick Williams | 521d8f6 | 2021-10-27 09:30:41 -0500 | [diff] [blame] | 207 | unset file_type |
| 208 | file_info=$(file "$f") |
| 209 | case $file_info in |
Patrick Williams | 12a27b2 | 2021-10-26 16:07:31 -0500 | [diff] [blame] | 210 | *shell\ script*) |
Patrick Williams | 521d8f6 | 2021-10-27 09:30:41 -0500 | [diff] [blame] | 211 | file_type="shell" |
Patrick Williams | 12a27b2 | 2021-10-26 16:07:31 -0500 | [diff] [blame] | 212 | ;; |
| 213 | |
Patrick Williams | 2ed00d8 | 2021-10-27 09:33:53 -0500 | [diff] [blame] | 214 | *JSON\ data*) |
| 215 | file_type="json" |
| 216 | ;; |
| 217 | |
Patrick Williams | 12a27b2 | 2021-10-26 16:07:31 -0500 | [diff] [blame] | 218 | *) |
Patrick Williams | 521d8f6 | 2021-10-27 09:30:41 -0500 | [diff] [blame] | 219 | case $f in |
| 220 | *.sh) |
| 221 | file_type="shell" |
| 222 | ;; |
| 223 | |
Patrick Williams | 2ed00d8 | 2021-10-27 09:33:53 -0500 | [diff] [blame] | 224 | *.json) |
| 225 | file_type="json" |
| 226 | ;; |
Patrick Williams | 521d8f6 | 2021-10-27 09:30:41 -0500 | [diff] [blame] | 227 | esac |
Patrick Williams | 12a27b2 | 2021-10-26 16:07:31 -0500 | [diff] [blame] | 228 | esac |
Patrick Williams | 521d8f6 | 2021-10-27 09:30:41 -0500 | [diff] [blame] | 229 | |
| 230 | if [ -n "$file_type" ]; then |
| 231 | check_cmd="check_${file_type}" |
| 232 | if ! eval "${!check_cmd} $f"; then |
| 233 | if [[ $lint_exempt == *$f* ]]; then |
| 234 | echo "EXEMPT: $f" |
| 235 | else |
| 236 | echo "FAILED: $f" |
| 237 | false |
| 238 | fi |
| 239 | fi |
| 240 | fi |
| 241 | |
Patrick Williams | 12a27b2 | 2021-10-26 16:07:31 -0500 | [diff] [blame] | 242 | done |
| 243 | |
Ed Tanous | d5cea14 | 2021-09-09 11:42:05 -0700 | [diff] [blame] | 244 | echo "Repo test passed" |