Andrew Geissler | ac970dd | 2021-02-12 15:32:45 -0600 | [diff] [blame] | 1 | From debd676cd94f92a30b3be45f1245aa13d8c398c0 Mon Sep 17 00:00:00 2001 |
Andrew Geissler | 748a483 | 2020-07-24 16:24:21 -0500 | [diff] [blame] | 2 | From: Philip Balister <philip@balister.org> |
| 3 | Date: Wed, 8 Jul 2020 09:41:43 -0400 |
| 4 | Subject: [PATCH] Do not strip binaries. |
| 5 | |
| 6 | * OpenEmbedded strips them after creating debug packages. |
| 7 | |
| 8 | Signed-off-by: Philip Balister <philip@balister.org> |
Andrew Geissler | ac970dd | 2021-02-12 15:32:45 -0600 | [diff] [blame] | 9 | Signed-off-by: Leon Anavi <leon.anavi@konsulko.com> |
Andrew Geissler | 748a483 | 2020-07-24 16:24:21 -0500 | [diff] [blame] | 10 | --- |
Andrew Geissler | ac970dd | 2021-02-12 15:32:45 -0600 | [diff] [blame] | 11 | tools/pybind11NewTools.cmake | 5 ----- |
| 12 | tools/pybind11Tools.cmake | 4 ---- |
| 13 | 2 files changed, 9 deletions(-) |
Andrew Geissler | 748a483 | 2020-07-24 16:24:21 -0500 | [diff] [blame] | 14 | |
Andrew Geissler | ac970dd | 2021-02-12 15:32:45 -0600 | [diff] [blame] | 15 | diff --git a/tools/pybind11NewTools.cmake b/tools/pybind11NewTools.cmake |
| 16 | index 18da8be1..82ebf5e7 100644 |
| 17 | --- a/tools/pybind11NewTools.cmake |
| 18 | +++ b/tools/pybind11NewTools.cmake |
| 19 | @@ -246,11 +246,6 @@ function(pybind11_add_module target_name) |
| 20 | endif() |
| 21 | endif() |
Andrew Geissler | 748a483 | 2020-07-24 16:24:21 -0500 | [diff] [blame] | 22 | |
Andrew Geissler | ac970dd | 2021-02-12 15:32:45 -0600 | [diff] [blame] | 23 | - if(NOT MSVC AND NOT ${CMAKE_BUILD_TYPE} MATCHES Debug|RelWithDebInfo) |
| 24 | - # Strip unnecessary sections of the binary on Linux/macOS |
| 25 | - pybind11_strip(${target_name}) |
Andrew Geissler | 748a483 | 2020-07-24 16:24:21 -0500 | [diff] [blame] | 26 | - endif() |
| 27 | - |
| 28 | if(MSVC) |
Andrew Geissler | ac970dd | 2021-02-12 15:32:45 -0600 | [diff] [blame] | 29 | target_link_libraries(${target_name} PRIVATE pybind11::windows_extras) |
| 30 | endif() |
| 31 | diff --git a/tools/pybind11Tools.cmake b/tools/pybind11Tools.cmake |
| 32 | index 32313539..a7d81012 100644 |
| 33 | --- a/tools/pybind11Tools.cmake |
| 34 | +++ b/tools/pybind11Tools.cmake |
| 35 | @@ -201,10 +201,6 @@ function(pybind11_add_module target_name) |
| 36 | endif() |
| 37 | endif() |
| 38 | |
| 39 | - if(NOT MSVC AND NOT ${CMAKE_BUILD_TYPE} MATCHES Debug|RelWithDebInfo) |
| 40 | - pybind11_strip(${target_name}) |
| 41 | - endif() |
| 42 | - |
| 43 | if(MSVC) |
| 44 | target_link_libraries(${target_name} PRIVATE pybind11::windows_extras) |
| 45 | endif() |
Andrew Geissler | 748a483 | 2020-07-24 16:24:21 -0500 | [diff] [blame] | 46 | -- |
Andrew Geissler | ac970dd | 2021-02-12 15:32:45 -0600 | [diff] [blame] | 47 | 2.17.1 |
Andrew Geissler | 748a483 | 2020-07-24 16:24:21 -0500 | [diff] [blame] | 48 | |