Andrew Geissler | 220dafd | 2023-10-04 10:18:08 -0500 | [diff] [blame] | 1 | From 5a4271456104bdf027644c81c3a208cde5cf522e Mon Sep 17 00:00:00 2001 |
Andrew Geissler | 517393d | 2023-01-13 08:55:19 -0600 | [diff] [blame] | 2 | From: Tim Orling <tim.orling@konsulko.com> |
| 3 | Date: Thu, 17 Nov 2022 16:33:20 -0800 |
| 4 | Subject: [PATCH] Skip TODO test cases that fail |
| 5 | |
| 6 | TODO cases report as "not ok" with ptest-runner |
| 7 | |
| 8 | Upstream-Status: Inappropriate [ptest-runner specific] |
| 9 | |
| 10 | Signed-off-by: Tim Orling <tim.orling@konsulko.com> |
| 11 | |
| 12 | --- |
| 13 | t/escape-char.t | 20 ++++++++++---------- |
| 14 | t/iri.t | 18 +++++++++--------- |
| 15 | t/mailto.t | 12 ++++++------ |
| 16 | 3 files changed, 25 insertions(+), 25 deletions(-) |
| 17 | |
| 18 | diff --git a/t/escape-char.t b/t/escape-char.t |
| 19 | index c6ce79c..5e62ad5 100644 |
| 20 | --- a/t/escape-char.t |
| 21 | +++ b/t/escape-char.t |
| 22 | @@ -6,16 +6,16 @@ use warnings; |
| 23 | use Test::More; |
| 24 | use URI (); |
| 25 | |
| 26 | -TODO: { |
| 27 | - my $str = "http://foo/\xE9"; |
| 28 | - utf8::upgrade($str); |
| 29 | - my $uri = URI->new($str); |
| 30 | - |
| 31 | - local $TODO = 'URI::Escape::escape_char misunderstands utf8'; |
| 32 | - |
| 33 | - # http://foo/%C3%A9 |
| 34 | - is("$uri", 'http://foo/%E9', 'correctly created a URI from a utf8-upgraded string'); |
| 35 | -} |
| 36 | +#TODO: { |
| 37 | +# my $str = "http://foo/\xE9"; |
| 38 | +# utf8::upgrade($str); |
| 39 | +# my $uri = URI->new($str); |
| 40 | +# |
| 41 | +# local $TODO = 'URI::Escape::escape_char misunderstands utf8'; |
| 42 | +# |
| 43 | +# # http://foo/%C3%A9 |
| 44 | +# is("$uri", 'http://foo/%E9', 'correctly created a URI from a utf8-upgraded string'); |
| 45 | +#} |
| 46 | |
| 47 | { |
| 48 | my $str = "http://foo/\xE9"; |
| 49 | diff --git a/t/iri.t b/t/iri.t |
Andrew Geissler | 220dafd | 2023-10-04 10:18:08 -0500 | [diff] [blame] | 50 | index cf983d6..884b36e 100644 |
Andrew Geissler | 517393d | 2023-01-13 08:55:19 -0600 | [diff] [blame] | 51 | --- a/t/iri.t |
| 52 | +++ b/t/iri.t |
| 53 | @@ -6,7 +6,7 @@ use Test::More; |
| 54 | use Config qw( %Config ); |
| 55 | |
| 56 | if (defined $Config{useperlio}) { |
Andrew Geissler | 220dafd | 2023-10-04 10:18:08 -0500 | [diff] [blame] | 57 | - plan tests=>30; |
| 58 | + plan tests=>28; |
Andrew Geissler | 517393d | 2023-01-13 08:55:19 -0600 | [diff] [blame] | 59 | } else { |
Andrew Geissler | 220dafd | 2023-10-04 10:18:08 -0500 | [diff] [blame] | 60 | plan skip_all=>"this perl doesn't support PerlIO layers"; |
Andrew Geissler | 517393d | 2023-01-13 08:55:19 -0600 | [diff] [blame] | 61 | } |
Andrew Geissler | 220dafd | 2023-10-04 10:18:08 -0500 | [diff] [blame] | 62 | @@ -67,17 +67,17 @@ is $u->as_iri, "http://➡.ws/"; |
Andrew Geissler | 517393d | 2023-01-13 08:55:19 -0600 | [diff] [blame] | 63 | # draft-duerst-iri-bis.txt examples (section 3.7.1): |
| 64 | is(URI->new("http://www.example.org/D%C3%BCrst")->as_iri, "http://www.example.org/D\xFCrst"); |
| 65 | is(URI->new("http://www.example.org/D%FCrst")->as_iri, "http://www.example.org/D%FCrst"); |
| 66 | -TODO: { |
| 67 | - local $TODO = "some chars (like U+202E, RIGHT-TO-LEFT OVERRIDE) need to stay escaped"; |
| 68 | -is(URI->new("http://xn--99zt52a.example.org/%e2%80%ae")->as_iri, "http://\x{7D0D}\x{8C46}.example.org/%e2%80%ae"); |
| 69 | -} |
| 70 | +#TODO: { |
| 71 | +# local $TODO = "some chars (like U+202E, RIGHT-TO-LEFT OVERRIDE) need to stay escaped"; |
| 72 | +#is(URI->new("http://xn--99zt52a.example.org/%e2%80%ae")->as_iri, "http://\x{7D0D}\x{8C46}.example.org/%e2%80%ae"); |
| 73 | +#} |
| 74 | |
| 75 | # try some URLs that can't be IDNA encoded (fallback to encoded UTF8 bytes) |
| 76 | $u = URI->new("http://" . ("ü" x 128)); |
| 77 | is $u, "http://" . ("%C3%BC" x 128); |
| 78 | is $u->host, ("\xC3\xBC" x 128); |
| 79 | -TODO: { |
| 80 | - local $TODO = "should ihost decode UTF8 bytes?"; |
| 81 | - is $u->ihost, ("ü" x 128); |
| 82 | -} |
| 83 | +#TODO: { |
| 84 | +# local $TODO = "should ihost decode UTF8 bytes?"; |
| 85 | +# is $u->ihost, ("ü" x 128); |
| 86 | +#} |
| 87 | is $u->as_iri, "http://" . ("ü" x 128); |
| 88 | diff --git a/t/mailto.t b/t/mailto.t |
| 89 | index 79e9a13..c68cfb2 100644 |
| 90 | --- a/t/mailto.t |
| 91 | +++ b/t/mailto.t |
| 92 | @@ -48,12 +48,12 @@ $u = URI->new('mailto:user+detail@example.com'); |
| 93 | is $u->to, 'user+detail@example.com', 'subaddress with `+` parsed correctly'; |
| 94 | is $u, 'mailto:user+detail@example.com', '... and stringification works'; |
| 95 | |
| 96 | -TODO: { |
| 97 | - local $TODO = "We can't handle quoted local parts without properly parsing the email addresses"; |
| 98 | - $u = URI->new('mailto:"foo bar+baz"@example.com'); |
| 99 | - is $u->to, '"foo bar+baz"@example.com', 'address with quoted local part containing spaces is parsed correctly'; |
| 100 | - is $u, 'mailto:%22foo%20bar+baz%22@example.com', '... and stringification works'; |
| 101 | -} |
| 102 | +#TODO: { |
| 103 | +# local $TODO = "We can't handle quoted local parts without properly parsing the email addresses"; |
| 104 | +# $u = URI->new('mailto:"foo bar+baz"@example.com'); |
| 105 | +# is $u->to, '"foo bar+baz"@example.com', 'address with quoted local part containing spaces is parsed correctly'; |
| 106 | +# is $u, 'mailto:%22foo%20bar+baz%22@example.com', '... and stringification works'; |
| 107 | +#} |
| 108 | |
| 109 | # RFC 5321 (4.1.3) - Address Literals |
| 110 | |