| Brad Bishop | 0e2770c | 2020-01-21 07:31:46 -0500 | [diff] [blame] | 1 | From d07d2f9601b49bb72cd4b36838f0c238bd1b0fc1 Mon Sep 17 00:00:00 2001 |
| 2 | From: Khem Raj <raj.khem@gmail.com> |
| 3 | Date: Wed, 15 Jan 2020 18:45:09 -0800 |
| 4 | Subject: [PATCH] tests: add explicit permissions to open() call |
| 5 | |
| 6 | Fixes |
| 7 | gethugepagesizes.c:227:35: error: open with O_CREAT in second argument needs 3 arguments |
| 8 | | fd = open(fname, O_WRONLY|O_CREAT); |
| 9 | | ^ |
| 10 | |
| 11 | Upstream-Status: Submitted [https://groups.google.com/forum/#!topic/libhugetlbfs/anNtDXbQKro] |
| 12 | Signed-off-by: Khem Raj <raj.khem@gmail.com> |
| 13 | --- |
| 14 | tests/gethugepagesizes.c | 4 ++-- |
| 15 | 1 file changed, 2 insertions(+), 2 deletions(-) |
| 16 | |
| 17 | diff --git a/tests/gethugepagesizes.c b/tests/gethugepagesizes.c |
| 18 | index 9551b38..5777265 100644 |
| 19 | --- a/tests/gethugepagesizes.c |
| 20 | +++ b/tests/gethugepagesizes.c |
| 21 | @@ -223,7 +223,7 @@ void setup_fake_data(long sizes[], int n_elem) |
| 22 | FAIL("mkdtemp: %s", strerror(errno)); |
| 23 | |
| 24 | sprintf(fname, "%s/meminfo-none", fake_meminfo); |
| 25 | - fd = open(fname, O_WRONLY|O_CREAT); |
| 26 | + fd = open(fname, O_WRONLY|O_CREAT, 0600); |
| 27 | if (fd < 0) |
| 28 | FAIL("open: %s", strerror(errno)); |
| 29 | if (write(fd, meminfo_base, |
| 30 | @@ -233,7 +233,7 @@ void setup_fake_data(long sizes[], int n_elem) |
| 31 | FAIL("close: %s", strerror(errno)); |
| 32 | |
| 33 | sprintf(fname, "%s/meminfo-hugepages", fake_meminfo); |
| 34 | - fd = open(fname, O_WRONLY|O_CREAT); |
| 35 | + fd = open(fname, O_WRONLY|O_CREAT, 0600); |
| 36 | if (fd < 0) |
| 37 | FAIL("open: %s", strerror(errno)); |
| 38 | if (write(fd, meminfo_base, |
| 39 | -- |
| 40 | 2.25.0 |
| 41 | |