Fix includes
Clang-tidy misc-include-cleaner appears to now be enforcing
significantly more headers than previously. That is overall a good
thing, but forces us to fix some issues. This commit is largely just
taking the clang-recommended fixes and checking them in. Subsequent
patches will fix the more unique issues.
Note, that a number of new ignores are added into the .clang-tidy file.
These can be cleaned up over time as they're understood. The majority
are places where boost includes a impl/x.hpp and x.hpp, but expects you
to use the later. include-cleaner opts for the impl, but it isn't clear
why.
Change-Id: Id3fdd7ee6df6c33b2fd35626898523048dd51bfb
Signed-off-by: Ed Tanous <etanous@nvidia.com>
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
diff --git a/redfish-core/lib/log_services.hpp b/redfish-core/lib/log_services.hpp
index 665e058..c47e45f 100644
--- a/redfish-core/lib/log_services.hpp
+++ b/redfish-core/lib/log_services.hpp
@@ -3,47 +3,72 @@
// SPDX-FileCopyrightText: Copyright 2018 Intel Corporation
#pragma once
+#include "bmcweb_config.h"
+
#include "app.hpp"
+#include "async_resp.hpp"
+#include "dbus_singleton.hpp"
#include "dbus_utility.hpp"
#include "error_messages.hpp"
#include "generated/enums/log_entry.hpp"
#include "generated/enums/log_service.hpp"
+#include "http_body.hpp"
+#include "http_request.hpp"
+#include "http_response.hpp"
#include "http_utility.hpp"
#include "human_sort.hpp"
+#include "logging.hpp"
#include "query.hpp"
#include "registries.hpp"
-#include "registries/base_message_registry.hpp"
-#include "registries/openbmc_message_registry.hpp"
#include "registries/privilege_registry.hpp"
+#include "str_utility.hpp"
#include "task.hpp"
#include "task_messages.hpp"
#include "utils/dbus_event_log_entry.hpp"
#include "utils/dbus_utils.hpp"
#include "utils/json_utils.hpp"
+#include "utils/query_param.hpp"
#include "utils/time_utils.hpp"
-#include <systemd/sd-id128.h>
+#include <asm-generic/errno.h>
+#include <systemd/sd-bus.h>
#include <tinyxml2.h>
#include <unistd.h>
+#include <boost/beast/http/field.hpp>
+#include <boost/beast/http/status.hpp>
#include <boost/beast/http/verb.hpp>
-#include <boost/container/flat_map.hpp>
#include <boost/system/linux_error.hpp>
#include <boost/url/format.hpp>
-#include <sdbusplus/asio/property.hpp>
+#include <boost/url/url.hpp>
+#include <sdbusplus/message.hpp>
+#include <sdbusplus/message/native_types.hpp>
#include <sdbusplus/unpack_properties.hpp>
+#include <algorithm>
#include <array>
-#include <charconv>
+#include <chrono>
#include <cstddef>
+#include <cstdint>
+#include <cstdio>
+#include <ctime>
#include <filesystem>
+#include <format>
+#include <fstream>
+#include <functional>
+#include <iomanip>
#include <iterator>
+#include <memory>
#include <optional>
#include <ranges>
#include <span>
+#include <sstream>
#include <string>
#include <string_view>
+#include <system_error>
+#include <utility>
#include <variant>
+#include <vector>
namespace redfish
{
@@ -65,8 +90,6 @@
DUMP_CREATE_INPROGRESS
};
-namespace fs = std::filesystem;
-
inline std::string translateSeverityDbusToRedfish(const std::string& s)
{
if ((s == "xyz.openbmc_project.Logging.Entry.Level.Alert") ||