Ed Tanous | 40e9b92 | 2024-09-10 13:50:16 -0700 | [diff] [blame] | 1 | // SPDX-License-Identifier: Apache-2.0 |
| 2 | // SPDX-FileCopyrightText: Copyright OpenBMC Authors |
Ed Tanous | 478b7ad | 2024-07-15 19:11:54 -0700 | [diff] [blame] | 3 | #include "async_resp.hpp" |
Ed Tanous | 88a03c5 | 2022-03-14 10:16:07 -0700 | [diff] [blame] | 4 | #include "http_request.hpp" |
| 5 | #include "routing.hpp" |
Nan Zhou | dff2f9b | 2022-06-26 23:50:39 +0000 | [diff] [blame] | 6 | #include "utility.hpp" |
Ed Tanous | 88a03c5 | 2022-03-14 10:16:07 -0700 | [diff] [blame] | 7 | |
Nan Zhou | dff2f9b | 2022-06-26 23:50:39 +0000 | [diff] [blame] | 8 | #include <boost/beast/http/verb.hpp> |
| 9 | |
| 10 | #include <memory> |
| 11 | #include <string> |
| 12 | #include <string_view> |
| 13 | #include <system_error> |
| 14 | |
Ed Tanous | 478b7ad | 2024-07-15 19:11:54 -0700 | [diff] [blame] | 15 | #include <gtest/gtest.h> |
Nan Zhou | d5c80ad | 2022-07-11 01:16:31 +0000 | [diff] [blame] | 16 | |
Nan Zhou | d5c80ad | 2022-07-11 01:16:31 +0000 | [diff] [blame] | 17 | // IWYU pragma: no_forward_declare bmcweb::AsyncResp |
Ed Tanous | 88a03c5 | 2022-03-14 10:16:07 -0700 | [diff] [blame] | 18 | |
Nan Zhou | ef74026 | 2022-06-26 23:55:13 +0000 | [diff] [blame] | 19 | namespace crow |
| 20 | { |
| 21 | namespace |
| 22 | { |
| 23 | |
Ed Tanous | 47488a9 | 2023-06-26 18:19:33 -0700 | [diff] [blame] | 24 | using ::crow::utility::getParameterTag; |
Nan Zhou | ef74026 | 2022-06-26 23:55:13 +0000 | [diff] [blame] | 25 | |
Ed Tanous | 88a03c5 | 2022-03-14 10:16:07 -0700 | [diff] [blame] | 26 | TEST(Router, AllowHeader) |
| 27 | { |
| 28 | // Callback handler that does nothing |
Patrick Williams | bd79bce | 2024-08-16 15:22:20 -0400 | [diff] [blame] | 29 | auto nullCallback = |
| 30 | [](const Request&, const std::shared_ptr<bmcweb::AsyncResp>&) {}; |
Ed Tanous | 88a03c5 | 2022-03-14 10:16:07 -0700 | [diff] [blame] | 31 | |
Nan Zhou | ef74026 | 2022-06-26 23:55:13 +0000 | [diff] [blame] | 32 | Router router; |
Ed Tanous | 88a03c5 | 2022-03-14 10:16:07 -0700 | [diff] [blame] | 33 | std::error_code ec; |
| 34 | |
Ed Tanous | 26ccae3 | 2023-02-16 10:28:44 -0800 | [diff] [blame] | 35 | constexpr std::string_view url = "/foo"; |
Ed Tanous | 88a03c5 | 2022-03-14 10:16:07 -0700 | [diff] [blame] | 36 | |
Nan Zhou | ef74026 | 2022-06-26 23:55:13 +0000 | [diff] [blame] | 37 | Request req{{boost::beast::http::verb::get, url, 11}, ec}; |
Ed Tanous | 88a03c5 | 2022-03-14 10:16:07 -0700 | [diff] [blame] | 38 | |
| 39 | // No route should return no methods. |
| 40 | router.validate(); |
Ed Tanous | 44e4518 | 2022-07-26 16:47:23 -0700 | [diff] [blame] | 41 | EXPECT_EQ(router.findRoute(req).allowHeader, ""); |
| 42 | EXPECT_EQ(router.findRoute(req).route.rule, nullptr); |
Ed Tanous | 88a03c5 | 2022-03-14 10:16:07 -0700 | [diff] [blame] | 43 | |
Nan Zhou | ef74026 | 2022-06-26 23:55:13 +0000 | [diff] [blame] | 44 | router.newRuleTagged<getParameterTag(url)>(std::string(url)) |
Ed Tanous | 88a03c5 | 2022-03-14 10:16:07 -0700 | [diff] [blame] | 45 | .methods(boost::beast::http::verb::get)(nullCallback); |
| 46 | router.validate(); |
Ed Tanous | 44e4518 | 2022-07-26 16:47:23 -0700 | [diff] [blame] | 47 | EXPECT_EQ(router.findRoute(req).allowHeader, "GET"); |
| 48 | EXPECT_NE(router.findRoute(req).route.rule, nullptr); |
| 49 | |
| 50 | Request patchReq{{boost::beast::http::verb::patch, url, 11}, ec}; |
| 51 | EXPECT_EQ(router.findRoute(patchReq).route.rule, nullptr); |
Ed Tanous | 88a03c5 | 2022-03-14 10:16:07 -0700 | [diff] [blame] | 52 | |
Nan Zhou | ef74026 | 2022-06-26 23:55:13 +0000 | [diff] [blame] | 53 | router.newRuleTagged<getParameterTag(url)>(std::string(url)) |
Ed Tanous | 88a03c5 | 2022-03-14 10:16:07 -0700 | [diff] [blame] | 54 | .methods(boost::beast::http::verb::patch)(nullCallback); |
| 55 | router.validate(); |
Ed Tanous | 44e4518 | 2022-07-26 16:47:23 -0700 | [diff] [blame] | 56 | EXPECT_EQ(router.findRoute(req).allowHeader, "GET, PATCH"); |
| 57 | EXPECT_NE(router.findRoute(req).route.rule, nullptr); |
| 58 | EXPECT_NE(router.findRoute(patchReq).route.rule, nullptr); |
| 59 | } |
| 60 | |
Ed Tanous | d9e89df | 2024-03-27 14:08:59 -0700 | [diff] [blame] | 61 | TEST(Router, OverlapingRoutes) |
| 62 | { |
| 63 | // Callback handler that does nothing |
Patrick Williams | bd79bce | 2024-08-16 15:22:20 -0400 | [diff] [blame] | 64 | auto fooCallback = |
| 65 | [](const Request&, const std::shared_ptr<bmcweb::AsyncResp>&) { |
| 66 | EXPECT_FALSE(true); |
| 67 | }; |
Ed Tanous | d9e89df | 2024-03-27 14:08:59 -0700 | [diff] [blame] | 68 | bool barCalled = false; |
| 69 | auto foobarCallback = |
| 70 | [&barCalled](const Request&, const std::shared_ptr<bmcweb::AsyncResp>&, |
| 71 | const std::string& bar) { |
Patrick Williams | bd79bce | 2024-08-16 15:22:20 -0400 | [diff] [blame] | 72 | barCalled = true; |
| 73 | EXPECT_EQ(bar, "bar"); |
| 74 | }; |
Ed Tanous | d9e89df | 2024-03-27 14:08:59 -0700 | [diff] [blame] | 75 | |
| 76 | Router router; |
| 77 | std::error_code ec; |
| 78 | |
| 79 | router.newRuleTagged<getParameterTag("/foo/<str>")>("/foo/<str>")( |
| 80 | foobarCallback); |
| 81 | router.newRuleTagged<getParameterTag("/foo")>("/foo")(fooCallback); |
| 82 | router.validate(); |
| 83 | { |
| 84 | constexpr std::string_view url = "/foo/bar"; |
| 85 | |
Jonathan Doman | 102a4cd | 2024-04-15 16:56:23 -0700 | [diff] [blame] | 86 | auto req = std::make_shared<Request>( |
| 87 | Request::Body{boost::beast::http::verb::get, url, 11}, ec); |
Ed Tanous | d9e89df | 2024-03-27 14:08:59 -0700 | [diff] [blame] | 88 | |
| 89 | std::shared_ptr<bmcweb::AsyncResp> asyncResp = |
| 90 | std::make_shared<bmcweb::AsyncResp>(); |
| 91 | |
| 92 | router.handle(req, asyncResp); |
| 93 | } |
| 94 | EXPECT_TRUE(barCalled); |
| 95 | } |
| 96 | |
Ed Tanous | 44e4518 | 2022-07-26 16:47:23 -0700 | [diff] [blame] | 97 | TEST(Router, 404) |
| 98 | { |
| 99 | bool notFoundCalled = false; |
| 100 | // Callback handler that does nothing |
| 101 | auto nullCallback = |
| 102 | [¬FoundCalled](const Request&, |
| 103 | const std::shared_ptr<bmcweb::AsyncResp>&) { |
Patrick Williams | bd79bce | 2024-08-16 15:22:20 -0400 | [diff] [blame] | 104 | notFoundCalled = true; |
| 105 | }; |
Ed Tanous | 44e4518 | 2022-07-26 16:47:23 -0700 | [diff] [blame] | 106 | |
| 107 | Router router; |
| 108 | std::error_code ec; |
| 109 | |
Ed Tanous | 26ccae3 | 2023-02-16 10:28:44 -0800 | [diff] [blame] | 110 | constexpr std::string_view url = "/foo/bar"; |
Ed Tanous | 44e4518 | 2022-07-26 16:47:23 -0700 | [diff] [blame] | 111 | |
Jonathan Doman | 102a4cd | 2024-04-15 16:56:23 -0700 | [diff] [blame] | 112 | auto req = std::make_shared<Request>( |
| 113 | Request::Body{boost::beast::http::verb::get, url, 11}, ec); |
Ed Tanous | 44e4518 | 2022-07-26 16:47:23 -0700 | [diff] [blame] | 114 | |
| 115 | router.newRuleTagged<getParameterTag(url)>("/foo/<path>") |
| 116 | .notFound()(nullCallback); |
| 117 | router.validate(); |
| 118 | { |
| 119 | std::shared_ptr<bmcweb::AsyncResp> asyncResp = |
| 120 | std::make_shared<bmcweb::AsyncResp>(); |
| 121 | |
| 122 | router.handle(req, asyncResp); |
| 123 | } |
| 124 | EXPECT_TRUE(notFoundCalled); |
Nan Zhou | ef74026 | 2022-06-26 23:55:13 +0000 | [diff] [blame] | 125 | } |
Ed Tanous | 759cf10 | 2022-07-31 16:36:52 -0700 | [diff] [blame] | 126 | |
| 127 | TEST(Router, 405) |
| 128 | { |
| 129 | // Callback handler that does nothing |
Patrick Williams | bd79bce | 2024-08-16 15:22:20 -0400 | [diff] [blame] | 130 | auto nullCallback = |
| 131 | [](const Request&, const std::shared_ptr<bmcweb::AsyncResp>&) {}; |
Ed Tanous | 759cf10 | 2022-07-31 16:36:52 -0700 | [diff] [blame] | 132 | bool called = false; |
| 133 | auto notAllowedCallback = |
| 134 | [&called](const Request&, const std::shared_ptr<bmcweb::AsyncResp>&) { |
Patrick Williams | bd79bce | 2024-08-16 15:22:20 -0400 | [diff] [blame] | 135 | called = true; |
| 136 | }; |
Ed Tanous | 759cf10 | 2022-07-31 16:36:52 -0700 | [diff] [blame] | 137 | |
| 138 | Router router; |
| 139 | std::error_code ec; |
| 140 | |
Ed Tanous | 26ccae3 | 2023-02-16 10:28:44 -0800 | [diff] [blame] | 141 | constexpr std::string_view url = "/foo/bar"; |
Ed Tanous | 759cf10 | 2022-07-31 16:36:52 -0700 | [diff] [blame] | 142 | |
Jonathan Doman | 102a4cd | 2024-04-15 16:56:23 -0700 | [diff] [blame] | 143 | auto req = std::make_shared<Request>( |
| 144 | Request::Body{boost::beast::http::verb::patch, url, 11}, ec); |
Ed Tanous | 759cf10 | 2022-07-31 16:36:52 -0700 | [diff] [blame] | 145 | |
| 146 | router.newRuleTagged<getParameterTag(url)>(std::string(url)) |
| 147 | .methods(boost::beast::http::verb::get)(nullCallback); |
| 148 | router.newRuleTagged<getParameterTag(url)>("/foo/<path>") |
| 149 | .methodNotAllowed()(notAllowedCallback); |
| 150 | router.validate(); |
| 151 | { |
| 152 | std::shared_ptr<bmcweb::AsyncResp> asyncResp = |
| 153 | std::make_shared<bmcweb::AsyncResp>(); |
| 154 | |
| 155 | router.handle(req, asyncResp); |
| 156 | } |
| 157 | EXPECT_TRUE(called); |
| 158 | } |
Nan Zhou | ef74026 | 2022-06-26 23:55:13 +0000 | [diff] [blame] | 159 | } // namespace |
Ed Tanous | 44e4518 | 2022-07-26 16:47:23 -0700 | [diff] [blame] | 160 | } // namespace crow |