Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / obmc-console / 982090d9ea1d2f81572e4a783e17d1a8b3f35a71
commit982090d9ea1d2f81572e4a783e17d1a8b3f35a71[log] [tgz]
authorAndrew Jeffery <andrew@codeconstruct.com.au>Tue Jul 09 17:31:27 2024 +0930
committerAndrew Jeffery <andrew@codeconstruct.com.au>Tue Jul 09 17:57:17 2024 +0930
tree48ea586ae69415cb9be03122cbfc36fbfbd39cf5
parent48d1f533efab4d48d45de5a79ed86f9b6814d068 [diff]
console-server: Fix leak of TTY sysfs dev node path

Identified by valgrind:

```
==1304== 50 bytes in 1 blocks are definitely lost in loss record 1 of 1
==1304==    at 0x4831C14: malloc (vg_replace_malloc.c:442)
==1304==    by 0x499D10F: strdup (strdup.c:42)
==1304==    by 0x4942913: realpath_stk (canonicalize.c:409)
==1304==    by 0x4942913: realpath@@GLIBC_2.4 (canonicalize.c:431)
==1304==    by 0x109CFF: UnknownInlinedFun (stdlib.h:42)
==1304==    by 0x109CFF: UnknownInlinedFun (console-server.c:143)
==1304==    by 0x109CFF: UnknownInlinedFun (console-server.c:359)
==1304==    by 0x109CFF: main (console-server.c:1000)
```

Change-Id: I614ef9f36d59587c6a633d679d0997136ab29bf3
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>
1 file changed
tree: 48ea586ae69415cb9be03122cbfc36fbfbd39cf5
  1. conf/
  2. test/
  3. .clang-format
  4. .clang-tidy
  5. .gitignore
  6. .travis.yml
  7. CHANGELOG.md
  8. config.c
  9. console-client.c
  10. console-dbus.c
  11. console-server.c
  12. console-server.h
  13. console-socket.c
  14. LICENSE
  15. log-handler.c
  16. meson.build
  17. meson.options
  18. OWNERS
  19. README.md
  20. ringbuffer.c
  21. socket-handler.c
  22. tty-handler.c
  23. util.c
README.md

To Build

To build this project, run the following shell commands:

meson setup build
meson compile -C build

To test:

meson test -C build

To Run Server

Running the server requires a serial port (e.g. /dev/ttyS0):

touch obmc-console.conf
./obmc-console-server --config obmc-console.conf ttyS0

To Connect Client

To connect to the server, simply run the client:

./obmc-console-client

To disconnect the client, use the standard ~. combination.

Underlying design

This shows how the host UART connection is abstracted within the BMC as a Unix domain socket.

               +---------------------------------------------------------------------------------------------+
               |                                                                                             |
               |       obmc-console-client       unix domain socket         obmc-console-server              |
               |                                                                                             |
               |     +----------------------+                           +------------------------+           |
               |     |   client.2200.conf   |  +---------------------+  | server.ttyVUART0.conf  |           |
           +---+--+  +----------------------+  |                     |  +------------------------+  +--------+-------+
Network    | 2200 +-->                      +->+ @obmc-console.host0 +<-+                        <--+ /dev/ttyVUART0 |   UARTs
           +---+--+  | console-id = "host0" |  |                     |  |  console-id = "host0"  |  +--------+-------+
               |     |                      |  +---------------------+  |                        |           |
               |     +----------------------+                           +------------------------+           |
               |                                                                                             |
               |                                                                                             |
               |                                                                                             |
               +---------------------------------------------------------------------------------------------+

This supports multiple independent consoles. The console-id is a unique portion for the unix domain socket created by the obmc-console-server instance. The server needs to know this because it needs to know what to name the pipe; the client needs to know it as it needs to form the abstract socket name to which to connect.