| commit | 62db08a938e08debb4bc56c155238eb22a5a885c | [log] [tgz] |
|---|---|---|
| author | Marri Devender Rao <devenrao@in.ibm.com> | Thu Aug 22 03:16:02 2019 -0500 |
| committer | Andrew Geissler <geissonator@yahoo.com> | Thu Sep 05 18:14:21 2019 +0000 |
| tree | bdecd6442eba2bc492dc70af23a931cb09b79d47 | |
| parent | 88064f0d61a8ff8f28cee73caa094f3325abb5ae [diff] |
Validate the certificate type and service values In OP930 certificate type and service values are used to compute the certifiate URL, any mismatch in the values used to result in Invalid D-Bus path error. In OP940 only certificate type is used in computing the Redfish url and service value is ignored. But allowing the user to pass service for backward compatability. In OP940 as serivce value is not used, no validation is done to check if certificate type and service are related leading to confusion. Modified to add the validation. listed below are the valid combinations of certificate type and service values. "server" and "https" "client" and "ldap", "autority" and "ldap" Tested $ python openbmctool.py -H $bmc -U user1 -P password1 certificate update server ldap -f cert.pem Attempting login... Invalid service type User user1 has been logged out $ python openbmctool.py -H $bmc -U user1 -P password1 certificate update client https -f cert.pem Attempting login... Invalid service type User user1 has been logged out $ python openbmctool.py -H $bmc -U user1 -P password1 certificate update authority https -f cert.pem Attempting login... Invalid service type User user1 has been logged out $ python openbmctool.py -H $bmc -U user1 -P password1 certificate update authority ldap -f cert.pem Attempting login... Update complete. None User user1 has been logged out Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com> Change-Id: I64dccca42391dca583fd0b2b8b612aff3b3970c3
The goal of this repository is to collect the two-minute hacks you write to automate interactions with OpenBMC systems.
It's highly likely the scripts don't meet your needs - they could be undocumented, dysfunctional or utterly broken. Please help us improve!
Then this repository aims to be the default destination for your otherwise un-homed scripts. As such we are setting the bar for submission pretty low, and we aim to make the process as easy as possible.
openbmc-events: Query error events on the target serveropenbmc-sensors: Query sensors on the target serveropenbmc-sfw: Manage host and BMC firmware images on the target serveropenbmctool: A general purpose tool for user interactions with OpenBMCpretty-journal: Convert journalctl's 'pretty' output to regular outputupload_and_update: Upload a tarball to TFTP server and update BMC with itnetboot: Painless netboot of BMC kernelsobmc-gerrit: Automagically add reviewers to changes pushed to Gerritreboot: Endlessly reboot OpenPOWER hoststracing: Enable and clean up kernel tracepoints remotelywitherspoon-debug: Deploy the debug tools tarball to Witherspoon BMCscla-signers: Check if a contributor has signed the OpenBMC CLAopenbmc-autobump.py: Update commit IDs in bitbake recipes to bring in new changesPlease use gerrit for all patches to this repository:
Do note that you will need to be party to the OpenBMC CLA before your contributions can be accepted. See Gerrit Setup and CLA for more information.
So long as your patches look sane with a cursory glance you can expect them to be applied. We may push back in the event that similar tools already exist or there are egregious issues.
We don't ask for much, but you need to give us at least a Signed-off-by, and put your work under the Apache 2.0 license. Licensing everything under Apache 2.0 will just hurt our heads less. Lets keep the lawyers off our backs. ^
^Any exceptions must be accompanied by a LICENSE file in the relevant subdirectory, and be compatible with Apache 2.0. You thought you would get away without any fine print?
There's no standard way to install the scripts housed in the here, so adding parts of the repository to your PATH might be a bit of a dice-roll. We may also move or remove scripts from time to time as part of housekeeping. It's probably best to copy things out if you need stability.