Revert "Allow script to be used without a git alias"
This reverts commit 6b4b9df44144c1cc2072eb1847a9fb335d326710.
The change switches from using an SSH alias to using a direct
hostname / port argument in the claims that it is better for most
users, but it is not.
- The original 'openbmc.gerrit' SSH alias has been documented
forever in openbmc/docs:CONTRIBUTING.md and it is expected that
everyone has it set up as it is part of our gerrit documentation.
- Almost no one runs their system with their Unix ID matching their
Github ID, which means the SSH also needs a username argument
in order to be useful for most people (which was not added by
this previous commit).
As we already document having some kind of SSH alias for interacting
with Gerrit, using an SSH alias is necessary for the majority of users
anyhow, and the SSH alias chosen by default is the project-wide
documented suggestion, I am reverting this back to the previous
behavior.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I78947c75ce689d443d2b08475a35328be296784b
diff --git a/tof-voters/libvoters/subcmd/dump-gerrit.py b/tof-voters/libvoters/subcmd/dump-gerrit.py
index 32a3766..455f0e6 100644
--- a/tof-voters/libvoters/subcmd/dump-gerrit.py
+++ b/tof-voters/libvoters/subcmd/dump-gerrit.py
@@ -14,14 +14,8 @@
p.add_argument(
"--server",
"-s",
- help="Gerrit server SSH alias (default=gerrit.openbmc-project.xyz)",
- default="gerrit.openbmc-project.xyz",
- )
- p.add_argument(
- "--port",
- "-p",
- help="Gerrit server SSH port (default=29418)",
- default="29418",
+ help="Gerrit server SSH alias (default=openbmc.gerrit)",
+ default="openbmc.gerrit",
)
p.add_argument(
"--after",
@@ -44,7 +38,6 @@
query = list(
ssh(
args.server,
- "-p", args.port,
"gerrit",
"query",
"--format=json",