commit 3cfbd1542958b656f38389758579e0640d6462cb
author William A. Kennington III <wak@google.com> Tue May 24 18:53:52 2022 -0700
committer William A. Kennington III <wak@google.com> Sat Jun 11 11:52:17 2022 -0700
tree e2f223f5674f13ada28b3665b38a05e858c75e68
parent 1fbee91ecebd2d0bcc6f0ca4ce9431ae77ff265a

meta-google: gbmc-update: Fix fetch error logic

We want to produce a meaningful error if we time out unpacking the
download tarball.

Change-Id: I4710e70925d8c4be93430739f8a2f7e4ece47ebf
Signed-off-by: William A. Kennington III <wak@google.com>

meta-google/recipes-phosphor/flash/gbmc-update/75-gbmc-upgrade.sh

diff --git a/meta-google/recipes-phosphor/flash/gbmc-update/75-gbmc-upgrade.sh b/meta-google/recipes-phosphor/flash/gbmc-update/75-gbmc-upgrade.sh
index 9d55eee..9fe51cc 100644
--- a/meta-google/recipes-phosphor/flash/gbmc-update/75-gbmc-upgrade.sh
+++ b/meta-google/recipes-phosphor/flash/gbmc-update/75-gbmc-upgrade.sh
@@ -49,13 +49,28 @@
   local max_mb=$((2*64 + 2))
   ulimit -f $((max_mb * 1024 * 1024 / 512)) || return
   timeout=$((SECONDS + 300))
-  while (( SECONDS < timeout )); do
-    local st=(0)
+  stime=5
+  while true; do
+    local st=()
     curl -LSsk --max-time $((timeout - SECONDS)) "$bootfile_url" |
-      tar -xC "$tmpdir" "firmware-gbmc/$machine" || st=("${PIPESTATUS[@]}")
-    (( st[0] != 0 )) || break
+      tar -xC "$tmpdir" "firmware-gbmc/$machine" \
+      && st=("${PIPESTATUS[@]}") || st=("${PIPESTATUS[@]}")
+    # Curl failures should continue
+    if (( st[0] == 0 )); then
+      # Tar failures when curl succeeds are hard errors to start over.
+      if (( st[1] != 0 )); then
+        echo 'Unpacking failed' >&2
+        return 1
+      fi
+      # Success should continue without retry
+      break
+    fi
+    if (( SECONDS + stime >= timeout )); then
+      echo 'Timed out fetching image' >&2
+      return 1
+    fi
     (shopt -s nullglob dotglob; rm -rf -- "${tmpdir:?}"/*)
-    sleep 5
+    sleep $stime
   done
 
   local sig