| From 53f9670d6af1bd0745c1df9c469b269c72607b23 Mon Sep 17 00:00:00 2001 |
| From: Joe Slater <joe.slater@windriver.com> |
| Date: Tue, 6 Jun 2023 08:04:27 -0700 |
| Subject: [PATCH] tools: tests: modify delays in toggle test |
| |
| The test "gpioset: toggle (continuous)" uses fixed delays to test |
| toggling values. This is not reliable, so we switch to looking |
| for transitions from one value to another. |
| |
| We wait for a transition up to 1.5 seconds. |
| |
| Signed-off-by: Joe Slater <joe.slater@windriver.com> |
| Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> |
| |
| Upstream-Status: Accepted |
| |
| Signed-off-by: Joe Slater <joe.slater@windriver.com> |
| --- |
| tools/gpio-tools-test.bats | 21 ++++++++++++++++----- |
| 1 file changed, 16 insertions(+), 5 deletions(-) |
| |
| diff --git a/tools/gpio-tools-test.bats b/tools/gpio-tools-test.bats |
| index c83ca7d..929c35a 100755 |
| --- a/tools/gpio-tools-test.bats |
| +++ b/tools/gpio-tools-test.bats |
| @@ -141,6 +141,20 @@ gpiosim_check_value() { |
| [ "$VAL" = "$EXPECTED" ] |
| } |
| |
| +gpiosim_wait_value() { |
| + local OFFSET=$2 |
| + local EXPECTED=$3 |
| + local DEVNAME=${GPIOSIM_DEV_NAME[$1]} |
| + local CHIPNAME=${GPIOSIM_CHIP_NAME[$1]} |
| + local PORT=$GPIOSIM_SYSFS/$DEVNAME/$CHIPNAME/sim_gpio$OFFSET/value |
| + |
| + for i in {1..15}; do |
| + [ "$(<$PORT)" = "$EXPECTED" ] && return |
| + sleep 0.1 |
| + done |
| + return 1 |
| +} |
| + |
| gpiosim_cleanup() { |
| for CHIP in ${!GPIOSIM_CHIP_NAME[@]} |
| do |
| @@ -1567,15 +1581,12 @@ request_release_line() { |
| gpiosim_check_value sim0 4 0 |
| gpiosim_check_value sim0 7 0 |
| |
| - sleep 1 |
| - |
| - gpiosim_check_value sim0 1 0 |
| + gpiosim_wait_value sim0 1 0 |
| gpiosim_check_value sim0 4 1 |
| gpiosim_check_value sim0 7 1 |
| |
| - sleep 1 |
| |
| - gpiosim_check_value sim0 1 1 |
| + gpiosim_wait_value sim0 1 1 |
| gpiosim_check_value sim0 4 0 |
| gpiosim_check_value sim0 7 0 |
| } |
| -- |
| 2.25.1 |
| |