commit 650fb6107839c2807448ab469333f4260cd005e1
author William A. Kennington III <wak@google.com> Fri Jun 02 16:27:24 2023 -0700
committer William A. Kennington III <wak@google.com> Tue Jun 06 00:00:45 2023 +0000
tree 0414fe6ea780b0221215ca1622573a50ba7fb9c8
parent 9e1e3a73c2e8b82dd66a2b3fa07d2f3083c72ceb

meta-google: gpio-ctrl: Fix shellcheck issues

Change-Id: I5cae02d263204d3e9122fee41040ba735f6305d6
Signed-off-by: William A. Kennington III <wak@google.com>

meta-google/recipes-google/gpio/gpio-ctrl/lib.sh

diff --git a/meta-google/recipes-google/gpio/gpio-ctrl/lib.sh b/meta-google/recipes-google/gpio/gpio-ctrl/lib.sh
index 13c624b..a2db0d6 100644
--- a/meta-google/recipes-google/gpio/gpio-ctrl/lib.sh
+++ b/meta-google/recipes-google/gpio/gpio-ctrl/lib.sh
@@ -31,6 +31,7 @@
 # named GPIOs
 shopt -s nullglob
 for conf in /usr/share/gpio-ctrl/conf.d/*.sh; do
+  # shellcheck source=/dev/null
   source "$conf"
 done
 
@@ -98,13 +99,14 @@
     gpio_sysfs_lookup_cache["$id"]="$sysfs"
   fi
 
-  local ngpio=$(cat "$sysfs"/ngpio)
+  local ngpio
+  ngpio=$(<"$sysfs"/ngpio)
   if (( ngpio <= offset )); then
     echo "$name with gpiochip $sysfs only has $ngpio but wants $offset" >&2
     return 1
   fi
 
-  gpio_lookup_cache["$name"]=$(( $(cat "$sysfs"/base) + offset ))
+  gpio_lookup_cache["$name"]=$(( $(<"$sysfs"/base) + offset ))
   echo "${gpio_lookup_cache["$name"]}"
 }
 
@@ -124,7 +126,7 @@
   local gpios=("$@")
 
   if (( ${#gpios[@]} == 0 )); then
-    gpios="${!GPIO_NAMES_TO_SCM[@]}"
+    gpios=("${!GPIO_NAMES_TO_SCM[@]}")
   fi
 
   local deadline=$(( timeout + SECONDS ))