meta-openpower: Fix explicit dependencies antipattern
Out of the box bitbake examines built applications, automatically adds
runtime dependencies and thus ensures any library packages dependencies
are automatically added to images, sdks, etc. There is no need to list
them explicitly in a recipe.
Dependencies change over time, and listing them explicitly is likely
prone to errors - the net effect being unnecessary shared library
packages being installed into images.
Consult
https://www.yoctoproject.org/docs/latest/mega-manual/mega-manual.html#var-RDEPENDS
for information on when to use explicit runtime dependencies.
(From meta-openpower rev: 42fbcf6040860dc6b0b553febeabedd241f22a27)
Change-Id: If56c264d3807f604ae8ba9c948095ba61093285d
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
diff --git a/meta-openpower/recipes-phosphor/debug/openpower-debug-collector_git.bb b/meta-openpower/recipes-phosphor/debug/openpower-debug-collector_git.bb
index 9127273..d79a01c 100644
--- a/meta-openpower/recipes-phosphor/debug/openpower-debug-collector_git.bb
+++ b/meta-openpower/recipes-phosphor/debug/openpower-debug-collector_git.bb
@@ -17,10 +17,6 @@
autoconf-archive-native \
sdbus++-native \
"
-RDEPENDS_${PN} += " \
- phosphor-logging \
- "
-
S = "${WORKDIR}/git"
# This provides below 2 applications that are called into in case
diff --git a/meta-openpower/recipes-phosphor/flash/openpower-software-manager_git.bb b/meta-openpower/recipes-phosphor/flash/openpower-software-manager_git.bb
index adbe2f8..c40a21b 100644
--- a/meta-openpower/recipes-phosphor/flash/openpower-software-manager_git.bb
+++ b/meta-openpower/recipes-phosphor/flash/openpower-software-manager_git.bb
@@ -28,9 +28,6 @@
RDEPENDS_${PN} += " \
mtd-utils-ubifs \
- phosphor-dbus-interfaces \
- phosphor-logging \
- sdbusplus \
virtual-obmc-image-manager \
"
diff --git a/meta-openpower/recipes-phosphor/host/op-proc-control_git.bb b/meta-openpower/recipes-phosphor/host/op-proc-control_git.bb
index 4251ba4..6f19e39 100644
--- a/meta-openpower/recipes-phosphor/host/op-proc-control_git.bb
+++ b/meta-openpower/recipes-phosphor/host/op-proc-control_git.bb
@@ -20,12 +20,6 @@
openpower-dbus-interfaces \
"
-RDEPENDS_${PN} += " \
- phosphor-logging \
- phosphor-dbus-interfaces \
- openpower-dbus-interfaces \
- "
-
TEMPLATE = "pcie-poweroff@.service"
INSTANCE_FORMAT = "pcie-poweroff@{}.service"
INSTANCES = "${@compose_list(d, 'INSTANCE_FORMAT', 'OBMC_CHASSIS_INSTANCES')}"
diff --git a/meta-openpower/recipes-phosphor/ipmi/openpower-ipmi-oem_git.bb b/meta-openpower/recipes-phosphor/ipmi/openpower-ipmi-oem_git.bb
index e4d9b04..711b7e6 100644
--- a/meta-openpower/recipes-phosphor/ipmi/openpower-ipmi-oem_git.bb
+++ b/meta-openpower/recipes-phosphor/ipmi/openpower-ipmi-oem_git.bb
@@ -20,13 +20,6 @@
DEPENDS += "sdbus++-native"
DEPENDS += "virtual/phosphor-ipmi-inventory-sel"
-RDEPENDS_${PN} += " \
- sdbusplus \
- phosphor-logging \
- openpower-dbus-interfaces \
- phosphor-dbus-interfaces \
- "
-
TARGET_CFLAGS += "-fpic"
HOSTIPMI_PROVIDER_LIBRARY += "liboemhandler.so"
diff --git a/meta-openpower/recipes-phosphor/occ/openpower-occ-control_git.bb b/meta-openpower/recipes-phosphor/occ/openpower-occ-control_git.bb
index fcf1263..49adbb5 100644
--- a/meta-openpower/recipes-phosphor/occ/openpower-occ-control_git.bb
+++ b/meta-openpower/recipes-phosphor/occ/openpower-occ-control_git.bb
@@ -36,13 +36,6 @@
systemd \
"
-RDEPENDS_${PN} += " \
- sdbusplus \
- phosphor-logging \
- openpower-dbus-interfaces \
- phosphor-dbus-interfaces \
- "
-
EXTRA_OECONF = " \
YAML_PATH=${STAGING_DATADIR_NATIVE}/${PN} \
PS_DERATING_FACTOR=${POWER_SUPPLY_DERATING_FACTOR} \
diff --git a/meta-openpower/recipes-phosphor/vpd/openpower-fru-vpd_git.bb b/meta-openpower/recipes-phosphor/vpd/openpower-fru-vpd_git.bb
index c9d3b66..a1b7026 100644
--- a/meta-openpower/recipes-phosphor/vpd/openpower-fru-vpd_git.bb
+++ b/meta-openpower/recipes-phosphor/vpd/openpower-fru-vpd_git.bb
@@ -23,11 +23,6 @@
autoconf-archive-native \
"
-RDEPENDS_${PN} += " \
- sdbusplus \
- phosphor-logging \
- "
-
SYSTEMD_SERVICE_${PN} += "op-vpd-parser.service"
S = "${WORKDIR}/git"