| From cce3ae98a2c1966719daabff5a4ec6cf94a846f6 Mon Sep 17 00:00:00 2001 |
| From: Philip Withnall <pwithnall@gnome.org> |
| Date: Mon, 26 Feb 2024 16:55:44 +0000 |
| Subject: [PATCH] tests: Remove variable-length lookbehind tests for GRegex |
| MIME-Version: 1.0 |
| Content-Type: text/plain; charset=UTF-8 |
| Content-Transfer-Encoding: 8bit |
| |
| PCRE2 10.43 has now introduced support for variable-length lookbehind, |
| so these tests now fail if GLib is built against PCRE2 10.43 or higher. |
| |
| See |
| https://github.com/PCRE2Project/pcre2/blob/e8db6fa7137f4c6f66cb87e0a3c9467252ec1ef7/ChangeLog#L94. |
| |
| Rather than making the tests conditional on the version of PCRE2 in use, |
| just remove them. They are mostly testing the PCRE2 code rather than |
| any code in GLib, so don’t have much value. |
| |
| This should fix CI runs on msys2-mingw32, which updated to PCRE2 10.43 2 |
| days ago. |
| |
| Signed-off-by: Philip Withnall <pwithnall@gnome.org> |
| |
| Upstream-Status: Backport [https://gitlab.gnome.org/GNOME/glib/-/commit/cce3ae98a2c1966719daabff5a4ec6cf94a846f6] |
| Signed-off-by: Alexander Kanavin <alex@linutronix.de> |
| --- |
| glib/tests/regex.c | 10 ---------- |
| 1 file changed, 10 deletions(-) |
| |
| diff --git a/glib/tests/regex.c b/glib/tests/regex.c |
| index 1082526292..d7a698ec67 100644 |
| --- a/glib/tests/regex.c |
| +++ b/glib/tests/regex.c |
| @@ -1885,16 +1885,6 @@ test_lookbehind (void) |
| g_match_info_free (match); |
| g_regex_unref (regex); |
| |
| - regex = g_regex_new ("(?<!dogs?|cats?) x", G_REGEX_OPTIMIZE, G_REGEX_MATCH_DEFAULT, &error); |
| - g_assert (regex == NULL); |
| - g_assert_error (error, G_REGEX_ERROR, G_REGEX_ERROR_VARIABLE_LENGTH_LOOKBEHIND); |
| - g_clear_error (&error); |
| - |
| - regex = g_regex_new ("(?<=ab(c|de)) foo", G_REGEX_OPTIMIZE, G_REGEX_MATCH_DEFAULT, &error); |
| - g_assert (regex == NULL); |
| - g_assert_error (error, G_REGEX_ERROR, G_REGEX_ERROR_VARIABLE_LENGTH_LOOKBEHIND); |
| - g_clear_error (&error); |
| - |
| regex = g_regex_new ("(?<=abc|abde)foo", G_REGEX_OPTIMIZE, G_REGEX_MATCH_DEFAULT, &error); |
| g_assert (regex); |
| g_assert_no_error (error); |
| -- |
| GitLab |
| |
| |