blob: b31026448c32468d988eea0d18fc4263e3d3f662 [file] [log] [blame]
Brad Bishop1a4b7ee2018-12-16 17:11:34 -08001From e1c6540f7984bd48e1e2d80d965fa82c70de3c20 Mon Sep 17 00:00:00 2001
Brad Bishop6e60e8b2018-02-01 10:27:11 -05002From: Khem Raj <raj.khem@gmail.com>
3Date: Sun, 17 Apr 2016 12:35:41 -0700
Brad Bishop1a4b7ee2018-12-16 17:11:34 -08004Subject: [PATCH] WebKitMacros: Append to -I and not to -isystem
Brad Bishop6e60e8b2018-02-01 10:27:11 -05005
6gcc-6 has now introduced stdlib.h in libstdc++ for better
7compliance and its including the C library stdlib.h using
8include_next which is sensitive to order of system header
9include paths. Its infact better to not tinker with the
10system header include paths at all. Since adding /usr/include
11to -system is redundant and compiler knows about it moreover
12now with gcc6 it interferes with compiler's functioning
13and ends up with compile errors e.g.
14
15/usr/include/c++/6.0.0/cstdlib:75:25: fatal error: stdlib.h: No such file or directory
16
17Signed-off-by: Khem Raj <raj.khem@gmail.com>
18
Brad Bishop316dfdd2018-06-25 12:45:53 -040019Upstream-Status: Pending
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080020
Brad Bishop6e60e8b2018-02-01 10:27:11 -050021---
22 Source/JavaScriptCore/shell/CMakeLists.txt | 2 +-
23 Source/WebCore/PlatformGTK.cmake | 6 +++---
24 Source/WebKit/PlatformGTK.cmake | 2 +-
25 Source/cmake/WebKitMacros.cmake | 2 +-
26 Tools/MiniBrowser/gtk/CMakeLists.txt | 2 +-
27 Tools/TestWebKitAPI/PlatformGTK.cmake | 2 +-
28 6 files changed, 8 insertions(+), 8 deletions(-)
29
30diff --git a/Source/JavaScriptCore/shell/CMakeLists.txt b/Source/JavaScriptCore/shell/CMakeLists.txt
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080031index b3c7e0b..88446de 100644
Brad Bishop6e60e8b2018-02-01 10:27:11 -050032--- a/Source/JavaScriptCore/shell/CMakeLists.txt
33+++ b/Source/JavaScriptCore/shell/CMakeLists.txt
34@@ -35,7 +35,7 @@ WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS()
35 WEBKIT_WRAP_SOURCELIST(${JSC_SOURCES})
36 WEBKIT_WRAP_SOURCELIST(${TESTAPI_SOURCES})
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080037 include_directories(./ ${JavaScriptCore_INCLUDE_DIRECTORIES} ${JavaScriptCore_PRIVATE_INCLUDE_DIRECTORIES})
Brad Bishop6e60e8b2018-02-01 10:27:11 -050038-include_directories(SYSTEM ${JavaScriptCore_SYSTEM_INCLUDE_DIRECTORIES})
39+include_directories(${JavaScriptCore_SYSTEM_INCLUDE_DIRECTORIES})
40 add_executable(jsc ${JSC_SOURCES})
41 target_link_libraries(jsc ${JSC_LIBRARIES})
42
43diff --git a/Source/WebCore/PlatformGTK.cmake b/Source/WebCore/PlatformGTK.cmake
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080044index f7d8d70a..3c27b8bc 100644
Brad Bishop6e60e8b2018-02-01 10:27:11 -050045--- a/Source/WebCore/PlatformGTK.cmake
46+++ b/Source/WebCore/PlatformGTK.cmake
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080047@@ -157,7 +157,7 @@ if (ENABLE_PLUGIN_PROCESS_GTK2)
48 target_include_directories(WebCorePlatformGTK2 PRIVATE
49 ${WebCore_INCLUDE_DIRECTORIES}
Brad Bishop6e60e8b2018-02-01 10:27:11 -050050 )
51- target_include_directories(WebCorePlatformGTK2 SYSTEM PRIVATE
52+ target_include_directories(WebCorePlatformGTK2 PRIVATE
53 ${WebCore_SYSTEM_INCLUDE_DIRECTORIES}
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080054 ${GTK2_INCLUDE_DIRS}
55 ${GDK2_INCLUDE_DIRS}
56@@ -183,7 +183,7 @@ add_dependencies(WebCorePlatformGTK WebCore)
Brad Bishop6e60e8b2018-02-01 10:27:11 -050057 target_include_directories(WebCorePlatformGTK PRIVATE
58 ${WebCore_INCLUDE_DIRECTORIES}
59 )
60-target_include_directories(WebCorePlatformGTK SYSTEM PRIVATE
61+target_include_directories(WebCorePlatformGTK PRIVATE
62 ${WebCore_SYSTEM_INCLUDE_DIRECTORIES}
63 ${GTK_INCLUDE_DIRS}
64 ${GDK_INCLUDE_DIRS}
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080065@@ -199,7 +199,7 @@ include_directories(
Brad Bishop6e60e8b2018-02-01 10:27:11 -050066 "${WEBCORE_DIR}/bindings/gobject/"
67 )
68
69-include_directories(SYSTEM
70+include_directories(
71 ${WebCore_SYSTEM_INCLUDE_DIRECTORIES}
72 )
73
74diff --git a/Source/WebKit/PlatformGTK.cmake b/Source/WebKit/PlatformGTK.cmake
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080075index 8c6ebb5..772c243 100644
Brad Bishop6e60e8b2018-02-01 10:27:11 -050076--- a/Source/WebKit/PlatformGTK.cmake
77+++ b/Source/WebKit/PlatformGTK.cmake
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080078@@ -655,7 +655,7 @@ if (ENABLE_PLUGIN_PROCESS_GTK2)
Brad Bishop6e60e8b2018-02-01 10:27:11 -050079 target_include_directories(WebKitPluginProcess2 PRIVATE
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080080 ${WebKitCommonIncludeDirectories}
Brad Bishop6e60e8b2018-02-01 10:27:11 -050081 )
82- target_include_directories(WebKitPluginProcess2 SYSTEM PRIVATE
83+ target_include_directories(WebKitPluginProcess2 PRIVATE
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080084 ${WebKitCommonSystemIncludeDirectories}
Brad Bishop6e60e8b2018-02-01 10:27:11 -050085 ${GTK2_INCLUDE_DIRS}
86 ${GDK2_INCLUDE_DIRS}
87diff --git a/Source/cmake/WebKitMacros.cmake b/Source/cmake/WebKitMacros.cmake
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080088index a1e7e8f..ce24274 100644
Brad Bishop6e60e8b2018-02-01 10:27:11 -050089--- a/Source/cmake/WebKitMacros.cmake
90+++ b/Source/cmake/WebKitMacros.cmake
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080091@@ -134,7 +134,7 @@ macro(WEBKIT_FRAMEWORK _target)
Brad Bishop6e60e8b2018-02-01 10:27:11 -050092 ${${_target}_SOURCES}
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080093 )
94 target_include_directories(${_target} PUBLIC "$<BUILD_INTERFACE:${${_target}_INCLUDE_DIRECTORIES}>")
95- target_include_directories(${_target} SYSTEM PRIVATE "$<BUILD_INTERFACE:${${_target}_SYSTEM_INCLUDE_DIRECTORIES}>")
96+ target_include_directories(${_target} PRIVATE "$<BUILD_INTERFACE:${${_target}_SYSTEM_INCLUDE_DIRECTORIES}>")
97 target_include_directories(${_target} PRIVATE "$<BUILD_INTERFACE:${${_target}_PRIVATE_INCLUDE_DIRECTORIES}>")
98 target_link_libraries(${_target} ${${_target}_LIBRARIES})
99 set_target_properties(${_target} PROPERTIES COMPILE_DEFINITIONS "BUILDING_${_target}")
Brad Bishop6e60e8b2018-02-01 10:27:11 -0500100diff --git a/Tools/MiniBrowser/gtk/CMakeLists.txt b/Tools/MiniBrowser/gtk/CMakeLists.txt
Brad Bishop1a4b7ee2018-12-16 17:11:34 -0800101index dc2b61e..0128dca 100644
Brad Bishop6e60e8b2018-02-01 10:27:11 -0500102--- a/Tools/MiniBrowser/gtk/CMakeLists.txt
103+++ b/Tools/MiniBrowser/gtk/CMakeLists.txt
104@@ -57,7 +57,7 @@ endif ()
105 add_definitions(-DGDK_VERSION_MIN_REQUIRED=GDK_VERSION_3_6)
106
107 include_directories(${MiniBrowser_INCLUDE_DIRECTORIES})
108-include_directories(SYSTEM ${MiniBrowser_SYSTEM_INCLUDE_DIRECTORIES})
109+include_directories(${MiniBrowser_SYSTEM_INCLUDE_DIRECTORIES})
110 add_executable(MiniBrowser ${MiniBrowser_SOURCES})
111 target_link_libraries(MiniBrowser ${MiniBrowser_LIBRARIES})
112
113diff --git a/Tools/TestWebKitAPI/PlatformGTK.cmake b/Tools/TestWebKitAPI/PlatformGTK.cmake
Brad Bishop1a4b7ee2018-12-16 17:11:34 -0800114index 4aef695..a14b163 100644
Brad Bishop6e60e8b2018-02-01 10:27:11 -0500115--- a/Tools/TestWebKitAPI/PlatformGTK.cmake
116+++ b/Tools/TestWebKitAPI/PlatformGTK.cmake
117@@ -20,7 +20,7 @@ include_directories(
Brad Bishop1a4b7ee2018-12-16 17:11:34 -0800118 ${WEBKIT_DIR}/UIProcess/API/gtk
Brad Bishop6e60e8b2018-02-01 10:27:11 -0500119 )
120
121-include_directories(SYSTEM
122+include_directories(
123 ${GDK3_INCLUDE_DIRS}
124 ${GLIB_INCLUDE_DIRS}
125 ${GTK3_INCLUDE_DIRS}