| Brad Bishop | 1932369 | 2019-04-05 15:28:33 -0400 | [diff] [blame^] | 1 | From 66471fbf7106917da7a1536b18a0a77d07479779 Mon Sep 17 00:00:00 2001 |
| 2 | From: Mingli Yu <Mingli.Yu@windriver.com> |
| 3 | Date: Mon, 17 Dec 2018 15:29:47 +0800 |
| 4 | Subject: [PATCH] configure.ac: Do not fatalize -Wmissing-prototypes |
| 5 | |
| 6 | There comes below error when run "make -C tests/nsm_client nsm_client" |
| 7 | | nlm_sm_inter_svc.c:20:1: error: no previous prototype for 'nlm_sm_prog_3' [-Werror=missing-prototypes] |
| 8 | |
| 9 | It is because rpcgen doesn't generate -Wmissing-prototypes |
| 10 | free code for nlm_sm_inter_svc.c with below logic |
| 11 | in tests/nsm_client/Makefile.am |
| 12 | [snip] |
| 13 | GENFILES_SVC = nlm_sm_inter_svc.c |
| 14 | [snip] |
| 15 | $(GENFILES_SVC): %_svc.c: %.x $(RPCGEN) |
| 16 | test -f $@ && rm -rf $@ || true |
| 17 | $(RPCGEN) -m -o $@ $< |
| 18 | |
| 19 | So add the logic not to fatalize -Wmissing-prototypes. |
| 20 | |
| 21 | Upstream-Status: Submitted[https://marc.info/?l=linux-nfs&m=154503260323936&w=2] |
| 22 | |
| 23 | Signed-off-by: Mingli Yu <Mingli.Yu@windriver.com> |
| 24 | --- |
| 25 | configure.ac | 2 +- |
| 26 | 1 file changed, 1 insertion(+), 1 deletion(-) |
| 27 | |
| 28 | diff --git a/configure.ac b/configure.ac |
| 29 | index e82ff14..d0cc5d5 100644 |
| 30 | --- a/configure.ac |
| 31 | +++ b/configure.ac |
| 32 | @@ -548,7 +548,7 @@ my_am_cflags="\ |
| 33 | -Wall \ |
| 34 | -Wextra \ |
| 35 | -Werror=strict-prototypes \ |
| 36 | - -Werror=missing-prototypes \ |
| 37 | + -Wmissing-prototypes \ |
| 38 | -Werror=missing-declarations \ |
| 39 | -Werror=format=2 \ |
| 40 | -Werror=undef \ |
| 41 | -- |
| 42 | 2.7.4 |
| 43 | |