blob: 8d2dc10ce54080878329d02e64d851a8303117eb [file] [log] [blame]
Brad Bishop19323692019-04-05 15:28:33 -04001From b4b6e9b1be33213ede3f612e87840c0045824d9e Mon Sep 17 00:00:00 2001
Brad Bishop1a4b7ee2018-12-16 17:11:34 -08002From: Otavio Salvador <otavio@ossystems.com.br>
3Date: Wed, 17 Jan 2018 10:02:14 -0200
4Subject: [PATCH 2/5] cmake: Prevent the detection of Qt5
5Organization: O.S. Systems Software LTDA.
6
7CMake doesn't have dependency on qt4/qt5, so these tests usually fail
8but still can cause undeterministic results or build failures (when
9OE_QMAKE_PATH_EXTERNAL_HOST_BINS is undefined or native qmake removed
10while running the test in cmake)
11
12Upstream-Status: Inappropriate [configuration]
13
14Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
15---
16 Source/QtDialog/CMakeLists.txt | 2 +-
17 Tests/CMakeLists.txt | 2 +-
18 Tests/Qt4And5Automoc/CMakeLists.txt | 4 ++--
Brad Bishop19323692019-04-05 15:28:33 -040019 Tests/QtAutogen/AutogenGuiTest.cmake | 3 +--
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080020 Tests/QtAutogen/MacOsFW/CMakeLists.txt | 2 +-
21 Tests/RunCMake/CMakeLists.txt | 2 +-
22 Tests/RunCMake/IncompatibleQt/IncompatibleQt.cmake | 2 +-
Brad Bishop19323692019-04-05 15:28:33 -040023 7 files changed, 8 insertions(+), 9 deletions(-)
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080024
25diff --git a/Source/QtDialog/CMakeLists.txt b/Source/QtDialog/CMakeLists.txt
Brad Bishop19323692019-04-05 15:28:33 -040026index 9ce0323844..06c86d63eb 100644
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080027--- a/Source/QtDialog/CMakeLists.txt
28+++ b/Source/QtDialog/CMakeLists.txt
29@@ -6,7 +6,7 @@ if(POLICY CMP0020)
30 cmake_policy(SET CMP0020 NEW) # Drop when CMake >= 2.8.11 required
31 endif()
32 CMake_OPTIONAL_COMPONENT(cmake-gui)
33-find_package(Qt5Widgets QUIET)
34+#find_package(Qt5Widgets QUIET)
35 if (Qt5Widgets_FOUND)
36 include_directories(${Qt5Widgets_INCLUDE_DIRS})
37 add_definitions(${Qt5Widgets_DEFINITONS})
38diff --git a/Tests/CMakeLists.txt b/Tests/CMakeLists.txt
Brad Bishop19323692019-04-05 15:28:33 -040039index ed98d974b0..7adfbc301b 100644
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080040--- a/Tests/CMakeLists.txt
41+++ b/Tests/CMakeLists.txt
Brad Bishop19323692019-04-05 15:28:33 -040042@@ -1342,7 +1342,7 @@ ${CMake_BINARY_DIR}/bin/cmake -DDIR=dev -P ${CMake_SOURCE_DIR}/Utilities/Release
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080043 set(CMake_TEST_Qt5 1)
44 endif()
45 if(CMake_TEST_Qt5)
46- find_package(Qt5Widgets QUIET NO_MODULE)
47+ #find_package(Qt5Widgets QUIET NO_MODULE)
48 endif()
49 if(CMake_TEST_Qt5 AND Qt5Widgets_FOUND)
50 add_subdirectory(Qt5Autogen)
51diff --git a/Tests/Qt4And5Automoc/CMakeLists.txt b/Tests/Qt4And5Automoc/CMakeLists.txt
Brad Bishop19323692019-04-05 15:28:33 -040052index ad74961d9f..a9dd74b151 100644
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080053--- a/Tests/Qt4And5Automoc/CMakeLists.txt
54+++ b/Tests/Qt4And5Automoc/CMakeLists.txt
55@@ -3,11 +3,11 @@ cmake_minimum_required(VERSION 2.8.12)
56 project(Qt4And5Automoc)
57
58 if (QT_REVERSE_FIND_ORDER)
59- find_package(Qt5Core REQUIRED)
60+ #find_package(Qt5Core REQUIRED)
61 find_package(Qt4 REQUIRED)
62 else()
63 find_package(Qt4 REQUIRED)
64- find_package(Qt5Core REQUIRED)
65+ #find_package(Qt5Core REQUIRED)
66 endif()
67
68 set(CMAKE_AUTOMOC ON)
Brad Bishop19323692019-04-05 15:28:33 -040069diff --git a/Tests/QtAutogen/AutogenGuiTest.cmake b/Tests/QtAutogen/AutogenGuiTest.cmake
70index b76d341a45..a6e0acbafa 100644
71--- a/Tests/QtAutogen/AutogenGuiTest.cmake
72+++ b/Tests/QtAutogen/AutogenGuiTest.cmake
73@@ -22,8 +22,7 @@ if (QT_TEST_VERSION EQUAL 4)
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080074 endmacro()
75
Brad Bishop19323692019-04-05 15:28:33 -040076 elseif(QT_TEST_VERSION EQUAL 5)
77-
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080078- find_package(Qt5Widgets REQUIRED)
79+ #find_package(Qt5Widgets REQUIRED)
80
81 set(QT_QTCORE_TARGET Qt5::Core)
Brad Bishop19323692019-04-05 15:28:33 -040082 set(QT_LIBRARIES Qt5::Widgets)
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080083diff --git a/Tests/QtAutogen/MacOsFW/CMakeLists.txt b/Tests/QtAutogen/MacOsFW/CMakeLists.txt
Brad Bishop19323692019-04-05 15:28:33 -040084index c08efc47a2..87e25d9391 100644
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080085--- a/Tests/QtAutogen/MacOsFW/CMakeLists.txt
86+++ b/Tests/QtAutogen/MacOsFW/CMakeLists.txt
87@@ -2,7 +2,7 @@ cmake_minimum_required(VERSION 3.10)
88 project(MacOsFW)
Brad Bishop19323692019-04-05 15:28:33 -040089 include("../AutogenGuiTest.cmake")
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080090
91-find_package(Qt5Test REQUIRED)
92+#find_package(Qt5Test REQUIRED)
93
94 set(CMAKE_CXX_STANDARD 11)
95 set(CMAKE_RUNTIME_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/output/bin)
96diff --git a/Tests/RunCMake/CMakeLists.txt b/Tests/RunCMake/CMakeLists.txt
Brad Bishop19323692019-04-05 15:28:33 -040097index 1f3e5c3006..8ed8d6ac54 100644
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080098--- a/Tests/RunCMake/CMakeLists.txt
99+++ b/Tests/RunCMake/CMakeLists.txt
Brad Bishop19323692019-04-05 15:28:33 -0400100@@ -326,7 +326,7 @@ add_RunCMake_test(configure_file)
Brad Bishop1a4b7ee2018-12-16 17:11:34 -0800101 add_RunCMake_test(CTestTimeoutAfterMatch)
102
103 find_package(Qt4 QUIET)
104-find_package(Qt5Core QUIET)
105+#find_package(Qt5Core QUIET)
106 if (QT4_FOUND AND Qt5Core_FOUND AND NOT Qt5Core_VERSION VERSION_LESS 5.1.0)
107 add_RunCMake_test(IncompatibleQt)
108 endif()
109diff --git a/Tests/RunCMake/IncompatibleQt/IncompatibleQt.cmake b/Tests/RunCMake/IncompatibleQt/IncompatibleQt.cmake
Brad Bishop19323692019-04-05 15:28:33 -0400110index 4fccdc418f..b76e1e5313 100644
Brad Bishop1a4b7ee2018-12-16 17:11:34 -0800111--- a/Tests/RunCMake/IncompatibleQt/IncompatibleQt.cmake
112+++ b/Tests/RunCMake/IncompatibleQt/IncompatibleQt.cmake
113@@ -1,6 +1,6 @@
114
115 find_package(Qt4 REQUIRED)
116-find_package(Qt5Core REQUIRED)
117+#find_package(Qt5Core REQUIRED)
118
119 add_executable(mainexe main.cpp)
120 target_link_libraries(mainexe Qt4::QtCore Qt5::Core)
121--
Brad Bishop19323692019-04-05 15:28:33 -04001222.11.0
Brad Bishop1a4b7ee2018-12-16 17:11:34 -0800123