blob: bebbfa4ad105dced7a690edb1aece9b350c4760c [file] [log] [blame]
Brad Bishop1a4b7ee2018-12-16 17:11:34 -08001From 1848b8f8b9be500046ca5d632789a068d6151815 Mon Sep 17 00:00:00 2001
Brad Bishopd7bf8c12018-02-25 22:55:05 -05002From: Khem Raj <raj.khem@gmail.com>
3Date: Thu, 8 Jun 2017 16:50:59 -0700
Brad Bishop1a4b7ee2018-12-16 17:11:34 -08004Subject: [PATCH] use intptr_t to fix pointer-to-int-cast issues
Brad Bishopd7bf8c12018-02-25 22:55:05 -05005
6uintptr_t is guaranteed to be wide enough that
7converting a void* to uintptr_t and back again
8will yield the original pointer value
9
10Signed-off-by: Khem Raj <raj.khem@gmail.com>
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080011
Brad Bishopd7bf8c12018-02-25 22:55:05 -050012---
13 src/lib/src/fwts_acpi_tables.c | 4 ++--
14 src/lib/src/fwts_mmap.c | 2 +-
15 src/lib/src/fwts_smbios.c | 4 ++--
16 3 files changed, 5 insertions(+), 5 deletions(-)
17
18diff --git a/src/lib/src/fwts_acpi_tables.c b/src/lib/src/fwts_acpi_tables.c
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080019index 58e982a6..6522032f 100644
Brad Bishopd7bf8c12018-02-25 22:55:05 -050020--- a/src/lib/src/fwts_acpi_tables.c
21+++ b/src/lib/src/fwts_acpi_tables.c
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080022@@ -156,7 +156,7 @@ static fwts_acpi_table_rsdp *fwts_acpi_get_rsdp(fwts_framework *fw, void *addr,
23 return NULL;
24 }
Brad Bishopd7bf8c12018-02-25 22:55:05 -050025
26- if ((mem = fwts_mmap((off_t)addr, sizeof(fwts_acpi_table_rsdp))) == FWTS_MAP_FAILED)
27+ if ((mem = fwts_mmap((uintptr_t)addr, sizeof(fwts_acpi_table_rsdp))) == FWTS_MAP_FAILED)
28 return NULL;
29
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080030 if (fwts_safe_memcpy(rsdp, mem, sizeof(fwts_acpi_table_rsdp)) != FWTS_OK) {
31@@ -455,7 +455,7 @@ static int fwts_acpi_load_tables_from_firmware(fwts_framework *fw)
Brad Bishopd7bf8c12018-02-25 22:55:05 -050032 if ((rsdp = fwts_acpi_get_rsdp(fw, rsdp_addr, &rsdp_len)) == NULL)
33 return FWTS_ERROR;
34
35- fwts_acpi_add_table("RSDP", rsdp, (uint64_t)(off_t)rsdp_addr, rsdp_len, FWTS_ACPI_TABLE_FROM_FIRMWARE);
36+ fwts_acpi_add_table("RSDP", rsdp, (uint64_t)(uintptr_t)rsdp_addr, rsdp_len, FWTS_ACPI_TABLE_FROM_FIRMWARE);
37
38 /* Load any tables from XSDT if it's valid */
39 if (rsdp->xsdt_address) {
40diff --git a/src/lib/src/fwts_mmap.c b/src/lib/src/fwts_mmap.c
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080041index e28abf87..2180b2cc 100644
Brad Bishopd7bf8c12018-02-25 22:55:05 -050042--- a/src/lib/src/fwts_mmap.c
43+++ b/src/lib/src/fwts_mmap.c
44@@ -81,7 +81,7 @@ int fwts_munmap(void *mem, const size_t size)
45 off_t offset;
46
47 page_size = fwts_page_size();
48- offset = ((off_t)(mem)) & (page_size - 1);
49+ offset = ((uintptr_t)(mem)) & (page_size - 1);
50
51 if (munmap((void *)((uint8_t *)mem - offset), size + offset) < 0)
52 return FWTS_ERROR;
53diff --git a/src/lib/src/fwts_smbios.c b/src/lib/src/fwts_smbios.c
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080054index e5b3c774..c8134926 100644
Brad Bishopd7bf8c12018-02-25 22:55:05 -050055--- a/src/lib/src/fwts_smbios.c
56+++ b/src/lib/src/fwts_smbios.c
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080057@@ -55,7 +55,7 @@ static void *fwts_smbios_find_entry_uefi(fwts_framework *fw, fwts_smbios_entry *
Brad Bishopd7bf8c12018-02-25 22:55:05 -050058 fwts_smbios_entry *mapped_entry;
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080059 const size_t size = sizeof(fwts_smbios_entry);
Brad Bishopd7bf8c12018-02-25 22:55:05 -050060
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080061- if ((mapped_entry = fwts_mmap((off_t)addr, size)) != FWTS_MAP_FAILED) {
62+ if ((mapped_entry = fwts_mmap((uintptr_t)addr, size)) != FWTS_MAP_FAILED) {
63 if (fwts_safe_memcpy(entry, mapped_entry, size) == FWTS_OK) {
64 (void)fwts_munmap(mapped_entry, size);
65 *type = FWTS_SMBIOS;
66@@ -91,7 +91,7 @@ static void *fwts_smbios30_find_entry_uefi(fwts_framework *fw, fwts_smbios30_ent
Brad Bishopd7bf8c12018-02-25 22:55:05 -050067 fwts_smbios30_entry *mapped_entry;
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080068 const size_t size = sizeof(fwts_smbios30_entry);
Brad Bishopd7bf8c12018-02-25 22:55:05 -050069
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080070- if ((mapped_entry = fwts_mmap((off_t)addr, size)) != FWTS_MAP_FAILED) {
71+ if ((mapped_entry = fwts_mmap((uintptr_t)addr, size)) != FWTS_MAP_FAILED) {
72 if (fwts_safe_memread(mapped_entry, size) == FWTS_OK) {
73 *entry = *mapped_entry;
74 (void)fwts_munmap(mapped_entry, size);