blob: bba420e3495172089d85311c7c6e16901981bb33 [file] [log] [blame]
Brad Bishop1a4b7ee2018-12-16 17:11:34 -08001From 8eb100b2e51be5d473b0748a223e2e7f61ec606c Mon Sep 17 00:00:00 2001
Brad Bishopd7bf8c12018-02-25 22:55:05 -05002From: Hongxu Jia <hongxu.jia@windriver.com>
Brad Bishop1a4b7ee2018-12-16 17:11:34 -08003Date: Fri, 29 Jun 2018 15:14:28 +0800
Brad Bishopd7bf8c12018-02-25 22:55:05 -05004Subject: [PATCH 7/7] Fix control path where we have str as uninitialized
5 string
6
7|
8/home/ubuntu/work/oe/openembedded-core/build/tmp-musl/work/i586-oe-linux-musl/elfutils/0.164-r0/elfutils-0.164/libcpu/i386_disasm.c:
9In function 'i386_disasm':
10|
11/home/ubuntu/work/oe/openembedded-core/build/tmp-musl/work/i586-oe-linux-musl/elfutils/0.164-r0/elfutils-0.164/libcpu/i386_disasm.c:310:5:
12error: 'str' may be used uninitialized in this function
13[-Werror=maybe-uninitialized]
14| memcpy (buf + bufcnt, _str, _len); \
15| ^
16|
17/home/ubuntu/work/oe/openembedded-core/build/tmp-musl/work/i586-oe-linux-musl/elfutils/0.164-r0/elfutils-0.164/libcpu/i386_disasm.c:709:17:
18note: 'str' was declared here
19| const char *str;
20
21Signed-off-by: Khem Raj <raj.khem@gmail.com>
22Upstream-Status: Pending
23
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080024Rebase to 0.172
Brad Bishopd7bf8c12018-02-25 22:55:05 -050025
26Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
27---
28 libcpu/i386_disasm.c | 1 +
29 1 file changed, 1 insertion(+)
30
31diff --git a/libcpu/i386_disasm.c b/libcpu/i386_disasm.c
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080032index a7e03f9..837a3a8 100644
Brad Bishopd7bf8c12018-02-25 22:55:05 -050033--- a/libcpu/i386_disasm.c
34+++ b/libcpu/i386_disasm.c
35@@ -821,6 +821,7 @@ i386_disasm (Ebl *ebl __attribute__((unused)),
36 }
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080037 FALLTHROUGH;
Brad Bishopd7bf8c12018-02-25 22:55:05 -050038 default:
39+ str = "";
40 assert (! "INVALID not handled");
41 }
42 }
43--
Brad Bishop1a4b7ee2018-12-16 17:11:34 -0800442.7.4
Brad Bishopd7bf8c12018-02-25 22:55:05 -050045