Brad Bishop | 1a4b7ee | 2018-12-16 17:11:34 -0800 | [diff] [blame^] | 1 | From b1985595e46721bb168ac38f4c841a915cc2f799 Mon Sep 17 00:00:00 2001 |
| 2 | From: Yousong Zhou <yszhou4tech@gmail.com> |
| 3 | Date: Fri, 24 Mar 2017 10:36:03 +0800 |
| 4 | Subject: [PATCH 11/11] Fix invalid sigprocmask call |
| 5 | MIME-Version: 1.0 |
| 6 | Content-Type: text/plain; charset=UTF-8 |
| 7 | Content-Transfer-Encoding: 8bit |
| 8 | |
| 9 | The POSIX document says |
| 10 | |
| 11 | The pthread_sigmask() and sigprocmask() functions shall fail if: |
| 12 | |
| 13 | [EINVAL] |
| 14 | The value of the how argument is not equal to one of the defined values. |
| 15 | |
| 16 | and this is how musl-libc is currently doing. Fix the call to be safe |
| 17 | and correct |
| 18 | |
| 19 | [1] http://pubs.opengroup.org/onlinepubs/9699919799/functions/pthread_sigmask.html |
| 20 | |
| 21 | gdb/ChangeLog: |
| 22 | 2017-03-24 Yousong Zhou <yszhou4tech@gmail.com> |
| 23 | |
| 24 | * common/signals-state-save-restore.c (save_original_signals_state): |
| 25 | Fix invalid sigprocmask call. |
| 26 | |
| 27 | Upstream-Status: Pending [not author, cherry-picked from LEDE https://bugs.lede-project.org/index.php?do=details&task_id=637&openedfrom=-1%2Bweek] |
| 28 | Signed-off-by: André Draszik <adraszik@tycoint.com> |
| 29 | Signed-off-by: Khem Raj <raj.khem@gmail.com> |
| 30 | --- |
| 31 | gdb/common/signals-state-save-restore.c | 2 +- |
| 32 | 1 file changed, 1 insertion(+), 1 deletion(-) |
| 33 | |
| 34 | diff --git a/gdb/common/signals-state-save-restore.c b/gdb/common/signals-state-save-restore.c |
| 35 | index 5bb66321bb..6597decbc6 100644 |
| 36 | --- a/gdb/common/signals-state-save-restore.c |
| 37 | +++ b/gdb/common/signals-state-save-restore.c |
| 38 | @@ -41,7 +41,7 @@ save_original_signals_state (bool quiet) |
| 39 | int i; |
| 40 | int res; |
| 41 | |
| 42 | - res = sigprocmask (0, NULL, &original_signal_mask); |
| 43 | + res = sigprocmask (SIG_BLOCK, NULL, &original_signal_mask); |
| 44 | if (res == -1) |
| 45 | perror_with_name (("sigprocmask")); |
| 46 | |
| 47 | -- |
| 48 | 2.18.0 |
| 49 | |