blob: 7d5868a72adb5326d55f328a1439eb1c8c1f97a9 [file] [log] [blame]
Brad Bishop1a4b7ee2018-12-16 17:11:34 -08001From 6b67d7f05918f7a1ee8fc6ff21355d7e8736aa10 Mon Sep 17 00:00:00 2001
2From: Michael Niedermayer <michael@niedermayer.cc>
3Date: Sat, 28 Jul 2018 15:03:50 +0200
4Subject: [PATCH] avformat/flvenc: Check audio packet size
5
6Fixes: Assertion failure
7Fixes: assert_flvenc.c:941_1.swf
8
9Upstream-Status: Backport [https://github.com/FFmpeg/FFmpeg/commit/6b67d7f05918f7a1ee8fc6ff21355d7e8736aa10]
10CVE: CVE-2018-15822
11
12Found-by: #CHEN HONGXU# <HCHEN017@e.ntu.edu.sg>
13Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
14Signed-off-by: Mingli Yu <Mingli.Yu@windriver.com>
15---
16 libavformat/flvenc.c | 5 +++++
17 1 file changed, 5 insertions(+)
18
19diff --git a/libavformat/flvenc.c b/libavformat/flvenc.c
20index 1c552a3e6b..e4863f1fc7 100644
21--- a/libavformat/flvenc.c
22+++ b/libavformat/flvenc.c
23@@ -883,6 +883,11 @@ static int flv_write_packet(AVFormatContext *s, AVPacket *pkt)
24 int flags = -1, flags_size, ret;
25 int64_t cur_offset = avio_tell(pb);
26
27+ if (par->codec_type == AVMEDIA_TYPE_AUDIO && !pkt->size) {
28+ av_log(s, AV_LOG_WARNING, "Empty audio Packet\n");
29+ return AVERROR(EINVAL);
30+ }
31+
32 if (par->codec_id == AV_CODEC_ID_VP6F || par->codec_id == AV_CODEC_ID_VP6A ||
33 par->codec_id == AV_CODEC_ID_VP6 || par->codec_id == AV_CODEC_ID_AAC)
34 flags_size = 2;
35--
362.17.1
37