| Brad Bishop | 6e60e8b | 2018-02-01 10:27:11 -0500 | [diff] [blame] | 1 | From: Petter Reinholdtsen <pere@hungry.com> |
| 2 | Date: Wed, 22 Oct 2014 13:25:21 +0200 |
| 3 | Subject: Fix format error blocking compilation with hardening |
| 4 | |
| 5 | Last-Update: 2014-10-22 |
| 6 | Forwarded: no |
| 7 | |
| 8 | Enabling hardening refuses to compile code with sprintf() calls |
| 9 | with no formatting string. Adjust the code to work with hardening. |
| 10 | --- |
| 11 | ogg123/status.c | 2 +- |
| 12 | 1 file changed, 1 insertion(+), 1 deletion(-) |
| 13 | |
| 14 | diff --git a/ogg123/status.c b/ogg123/status.c |
| 15 | index 92b8ff1..ccec389 100644 |
| 16 | --- a/ogg123/status.c |
| 17 | +++ b/ogg123/status.c |
| 18 | @@ -148,7 +148,7 @@ int print_statistics_line (stat_format_t stats[]) |
| 19 | |
| 20 | switch (stats->type) { |
| 21 | case stat_noarg: |
| 22 | - len += sprintf(str+len, stats->formatstr); |
| 23 | + len += sprintf(str+len, "%s", stats->formatstr); |
| 24 | break; |
| 25 | case stat_intarg: |
| 26 | len += sprintf(str+len, stats->formatstr, stats->arg.intarg); |