| Patrick Williams | c124f4f | 2015-09-15 14:41:29 -0500 | [diff] [blame] | 1 | Remove arm tests that don't compile |
| 2 | |
| 3 | Upstream-Status: Pending |
| 4 | |
| 5 | Corrects the original commit for the patch that removed ARM ptest CFLAGS |
| 6 | settings. Since the flags could be set by a user, the flags should |
| 7 | be kept in place during compilation. By keeping the original up-stream |
| 8 | CFLAGS for the tests, then additional tests successfully compile |
| 9 | for all tested ARM tunings. |
| 10 | |
| 11 | However, there were still two tests listed below that did not compile |
| 12 | for any beaglebone tuning that is valid for valgrind. With the updated |
| 13 | patch, the set of excluded ARM ptests and their respective build |
| 14 | failures are: |
| 15 | intdiv - fails for all beaglebone tunings with 2 errors: |
| 16 | {standard input}:(40 or 41): Error: selected processor does not |
| 17 | support Thumb mode `udiv r3,r9,r10' |
| 18 | {standard input}:(72 or 73): Error: selected processor does not |
| 19 | support Thumb mode `sdiv r3,r9,r10' |
| 20 | |
| 21 | vcvt_fixed_float_VFP - fails for all beaglebone tunings in one of |
| 22 | two ways: |
| 23 | with neon tuning (-mfpu=neon) fails with Internal Compiler Error |
| 24 | without neon tuning fails with 3 errors: |
| 25 | {standard input}:33: Error: selected FPU does not support |
| 26 | instruction -- `vcvt.f32.s32 s15,s15,#1' |
| 27 | {standard input}:58: Error: selected FPU does not support |
| 28 | instruction -- `vcvt.f32.s32 s15,s15,#32' |
| 29 | {standard input}:136: Error: selected FPU does not support |
| 30 | instruction -- `vcvt.f32.u32 s15,s15,#1' |
| 31 | |
| 32 | After applying this commit, the valgrind ARM ptests compile without |
| 33 | errors for tunings: |
| 34 | armv7[t][hf][b][-neon] cortexa8[t][hf][-neon] |
| 35 | where the tuning [option] was successfully compiled, both with |
| 36 | and without the 'option', and in combination with all other options. |
| 37 | |
| 38 | Signed-off-by: Dave Lerner <dave.lerner@windriver.com> |
| 39 | |
| 40 | Index: valgrind-3.10.1/none/tests/arm/Makefile.am |
| 41 | =================================================================== |
| 42 | --- valgrind-3.10.1.orig/none/tests/arm/Makefile.am 2015-05-19 15:11:59.224842927 -0500 |
| 43 | +++ valgrind-3.10.1/none/tests/arm/Makefile.am 2015-05-19 15:14:20.808847028 -0500 |
| 44 | @@ -17,9 +17,13 @@ |
| 45 | vfp.stdout.exp vfp.stderr.exp vfp.vgtest \ |
| 46 | vfpv4_fma.stdout.exp vfpv4_fma.stderr.exp vfpv4_fma.vgtest |
| 47 | |
| 48 | +# Remove the following tests which cause compiler errors for all tunings |
| 49 | +# available for beagle bone (see remove-arm-variant-specific.patch): |
| 50 | +# intdiv |
| 51 | +# vcvt_fixed_float_VFP |
| 52 | + |
| 53 | check_PROGRAMS = \ |
| 54 | allexec \ |
| 55 | - intdiv \ |
| 56 | ldrt \ |
| 57 | ldrt_arm \ |
| 58 | neon128 \ |
| 59 | @@ -27,7 +31,6 @@ |
| 60 | v6intARM \ |
| 61 | v6intThumb \ |
| 62 | v6media \ |
| 63 | - vcvt_fixed_float_VFP \ |
| 64 | vfp \ |
| 65 | vfpv4_fma |
| 66 | |