blob: 78520f0d9097e7bd98cc4b458809d1ef4dc611a9 [file] [log] [blame]
Brad Bishop37a0e4d2017-12-04 01:01:44 -05001From e1d426fd65c00a6d01a10d85edf8a294ae8a2d2b Mon Sep 17 00:00:00 2001
2From: Denys Vlasenko <vda.linux@googlemail.com>
3Date: Sun, 24 Apr 2016 18:19:49 +0200
4Subject: [PATCH] flock: fix -c; improve error handling of fork+exec
Patrick Williamsc0f7c042017-02-23 20:41:17 -06005
6function old new delta
Brad Bishop37a0e4d2017-12-04 01:01:44 -05007flock_main 254 334 +80
Patrick Williamsc0f7c042017-02-23 20:41:17 -06008
Brad Bishop37a0e4d2017-12-04 01:01:44 -05009Upstream-Status: Backport
Patrick Williamsc0f7c042017-02-23 20:41:17 -060010
Brad Bishop37a0e4d2017-12-04 01:01:44 -050011Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Patrick Williamsc0f7c042017-02-23 20:41:17 -060012Signed-off-by: Maxin B. John <maxin.john@intel.com>
13---
Brad Bishop37a0e4d2017-12-04 01:01:44 -050014 util-linux/flock.c | 19 +++++++++++++++++--
15 1 file changed, 17 insertions(+), 2 deletions(-)
Patrick Williamsc0f7c042017-02-23 20:41:17 -060016
17diff --git a/util-linux/flock.c b/util-linux/flock.c
Brad Bishop37a0e4d2017-12-04 01:01:44 -050018index 05a747f..539a835 100644
Patrick Williamsc0f7c042017-02-23 20:41:17 -060019--- a/util-linux/flock.c
20+++ b/util-linux/flock.c
Brad Bishop37a0e4d2017-12-04 01:01:44 -050021@@ -57,7 +57,6 @@ int flock_main(int argc UNUSED_PARAM, char **argv)
Patrick Williamsc0f7c042017-02-23 20:41:17 -060022 /* If it is "flock FILE -c PROG", then -c isn't caught by getopt32:
23 * we use "+" in order to support "flock -opt FILE PROG -with-opts",
24 * we need to remove -c by hand.
25- * TODO: in upstream, -c 'PROG ARGS' means "run sh -c 'PROG ARGS'"
26 */
27 if (argv[0]
28 && argv[0][0] == '-'
Brad Bishop37a0e4d2017-12-04 01:01:44 -050029@@ -66,6 +65,9 @@ int flock_main(int argc UNUSED_PARAM, char **argv)
Patrick Williamsc0f7c042017-02-23 20:41:17 -060030 )
31 ) {
Brad Bishop37a0e4d2017-12-04 01:01:44 -050032 argv++;
33+ if (argv[1])
34+ bb_error_msg_and_die("-c takes only one argument");
35+ opt |= OPT_c;
Patrick Williamsc0f7c042017-02-23 20:41:17 -060036 }
37
38 if (OPT_s == LOCK_SH && OPT_x == LOCK_EX && OPT_n == LOCK_NB && OPT_u == LOCK_UN) {
Brad Bishop37a0e4d2017-12-04 01:01:44 -050039@@ -90,8 +92,21 @@ int flock_main(int argc UNUSED_PARAM, char **argv)
Patrick Williamsc0f7c042017-02-23 20:41:17 -060040 bb_perror_nomsg_and_die();
41 }
Brad Bishop37a0e4d2017-12-04 01:01:44 -050042
Patrick Williamsc0f7c042017-02-23 20:41:17 -060043- if (argv[0])
Brad Bishop37a0e4d2017-12-04 01:01:44 -050044+ if (argv[0]) {
45+ if (!(opt & OPT_c)) {
46+ int rc = spawn_and_wait(argv);
47+ if (rc < 0)
48+ bb_simple_perror_msg(argv[0]);
49+ return rc;
50+ }
51+ /* -c 'PROG ARGS' means "run sh -c 'PROG ARGS'" */
52+ argv -= 2;
53+ argv[0] = (char*)get_shell_name();
54+ argv[1] = (char*)"-c";
55+ /* argv[2] = "PROG ARGS"; */
56+ /* argv[3] = NULL; */
57 return spawn_and_wait(argv);
58+ }
59
Patrick Williamsc0f7c042017-02-23 20:41:17 -060060 return EXIT_SUCCESS;
61 }
62--
632.4.0
64