| Brad Bishop | bec4ebc | 2022-08-03 09:55:16 -0400 | [diff] [blame] | 1 | From c0c6e4c1166c4868afc36649b9ed98081a6966e1 Mon Sep 17 00:00:00 2001 |
| 2 | From: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com> |
| 3 | Date: Fri, 24 Dec 2021 14:22:52 +0000 |
| 4 | Subject: [PATCH 24/27] Comment mm_communicate failure log |
| 5 | |
| 6 | When a getVariable() call is made with data size set to 0, |
| 7 | mm_communicate should return EFI_BUFFER_TOO_SMALL. This is |
| 8 | an expected behavior. There should not be any failure logs |
| 9 | in this case. So the error log is commented here. |
| 10 | |
| 11 | Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org> |
| 12 | --- |
| 13 | lib/efi_loader/efi_variable_tee.c | 5 ++++- |
| 14 | 1 file changed, 4 insertions(+), 1 deletion(-) |
| 15 | |
| 16 | diff --git a/lib/efi_loader/efi_variable_tee.c b/lib/efi_loader/efi_variable_tee.c |
| 17 | index 67743d1f8fce..a34989efac83 100644 |
| 18 | --- a/lib/efi_loader/efi_variable_tee.c |
| 19 | +++ b/lib/efi_loader/efi_variable_tee.c |
| 20 | @@ -411,7 +411,10 @@ static efi_status_t __efi_runtime mm_communicate(u8 *comm_buf, efi_uintn_t dsize |
| 21 | ret = ffa_mm_communicate(comm_buf, dsize); |
| 22 | #endif |
| 23 | if (ret != EFI_SUCCESS) { |
| 24 | - log_err("%s failed!\n", __func__); |
| 25 | + /* mm_communicate failure is logged even when getVariable() is called |
| 26 | + * with data size set to 0. This is not expected so logging is commented. |
| 27 | + */ |
| 28 | + //log_err("%s failed!\n", __func__); |
| 29 | return ret; |
| 30 | } |
| 31 | |
| 32 | -- |
| 33 | 2.30.2 |
| 34 | |