Andrew Geissler | 4b740dc | 2020-05-05 08:54:39 -0500 | [diff] [blame^] | 1 | From 658c034d92027dc8af5f784cae852123fac79b19 Mon Sep 17 00:00:00 2001 |
Patrick Williams | c0f7c04 | 2017-02-23 20:41:17 -0600 | [diff] [blame] | 2 | From: Khem Raj <raj.khem@gmail.com> |
| 3 | Date: Sat, 16 Apr 2016 13:28:59 -0700 |
Brad Bishop | 1a4b7ee | 2018-12-16 17:11:34 -0800 | [diff] [blame] | 4 | Subject: [PATCH] Do not ignore return value of write() |
Patrick Williams | c0f7c04 | 2017-02-23 20:41:17 -0600 | [diff] [blame] | 5 | |
| 6 | gcc warns about ignoring return value when compiling |
| 7 | with fortify turned on. |
| 8 | |
| 9 | assert when write() fails |
| 10 | |
Patrick Williams | c0f7c04 | 2017-02-23 20:41:17 -0600 | [diff] [blame] | 11 | Upstream-Status: Submitted |
Brad Bishop | 1a4b7ee | 2018-12-16 17:11:34 -0800 | [diff] [blame] | 12 | Signed-off-by: Khem Raj <raj.khem@gmail.com> |
Patrick Williams | c0f7c04 | 2017-02-23 20:41:17 -0600 | [diff] [blame] | 13 | |
Brad Bishop | 1a4b7ee | 2018-12-16 17:11:34 -0800 | [diff] [blame] | 14 | --- |
Patrick Williams | c0f7c04 | 2017-02-23 20:41:17 -0600 | [diff] [blame] | 15 | glib/tests/unix.c | 5 +++-- |
| 16 | 1 file changed, 3 insertions(+), 2 deletions(-) |
| 17 | |
| 18 | diff --git a/glib/tests/unix.c b/glib/tests/unix.c |
Andrew Geissler | 4b740dc | 2020-05-05 08:54:39 -0500 | [diff] [blame^] | 19 | index 7639d06..f941141 100644 |
Patrick Williams | c0f7c04 | 2017-02-23 20:41:17 -0600 | [diff] [blame] | 20 | --- a/glib/tests/unix.c |
| 21 | +++ b/glib/tests/unix.c |
Andrew Geissler | 4b740dc | 2020-05-05 08:54:39 -0500 | [diff] [blame^] | 22 | @@ -33,14 +33,15 @@ test_pipe (void) |
Patrick Williams | c0f7c04 | 2017-02-23 20:41:17 -0600 | [diff] [blame] | 23 | GError *error = NULL; |
| 24 | int pipefd[2]; |
| 25 | char buf[1024]; |
Brad Bishop | 1a4b7ee | 2018-12-16 17:11:34 -0800 | [diff] [blame] | 26 | - gssize bytes_read; |
| 27 | + gssize bytes_read, bytes_written; |
Patrick Williams | c0f7c04 | 2017-02-23 20:41:17 -0600 | [diff] [blame] | 28 | gboolean res; |
| 29 | |
| 30 | res = g_unix_open_pipe (pipefd, FD_CLOEXEC, &error); |
| 31 | g_assert (res); |
| 32 | g_assert_no_error (error); |
| 33 | |
| 34 | - write (pipefd[1], "hello", sizeof ("hello")); |
| 35 | + bytes_written = write (pipefd[1], "hello", sizeof ("hello")); |
| 36 | + g_assert (bytes_written != -1 && "write() failed"); |
| 37 | memset (buf, 0, sizeof (buf)); |
| 38 | bytes_read = read (pipefd[0], buf, sizeof(buf) - 1); |
| 39 | g_assert_cmpint (bytes_read, >, 0); |