blob: aac4ad49d71f6b5ac79c13ab20f246205e64cdcf [file] [log] [blame]
Andrew Geisslerd5838332022-05-27 11:33:10 -05001From 48a791aae7a47a2a08e9e60c18054071a43b8cda Mon Sep 17 00:00:00 2001
Brad Bishop19323692019-04-05 15:28:33 -04002From: Chen Qi <Qi.Chen@windriver.com>
3Date: Mon, 25 Feb 2019 15:12:41 +0800
William A. Kennington IIIac69b482021-06-02 12:28:27 -07004Subject: [PATCH] Use uintmax_t for handling rlim_t
Brad Bishop19323692019-04-05 15:28:33 -04005
6PRIu{32,64} is not right format to represent rlim_t type
7therefore use %ju and typecast the rlim_t variables to
8uintmax_t.
9
10Fixes portablility errors like
11
12execute.c:3446:36: error: format '%lu' expects argument of type 'long unsigned int', but argument 5 has type 'rlim_t {aka long long unsigned int}' [-Werror=format=]
13| fprintf(f, "%s%s: " RLIM_FMT "\n",
14| ^~~~~~~~
15| prefix, rlimit_to_string(i), c->rlimit[i]->rlim_max);
16| ~~~~~~~~~~~~~~~~~~~~~~
17
18Upstream-Status: Denied [https://github.com/systemd/systemd/pull/7199]
19
20Signed-off-by: Khem Raj <raj.khem@gmail.com>
21[Rebased for v241]
22Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
William A. Kennington IIIac69b482021-06-02 12:28:27 -070023
Brad Bishop19323692019-04-05 15:28:33 -040024---
25 src/basic/format-util.h | 8 +-------
Andrew Geisslerd159c7f2021-09-02 21:05:58 -050026 src/basic/rlimit-util.c | 12 ++++++------
Brad Bishop19323692019-04-05 15:28:33 -040027 src/core/execute.c | 4 ++--
Andrew Geisslerd159c7f2021-09-02 21:05:58 -050028 3 files changed, 9 insertions(+), 15 deletions(-)
Brad Bishop19323692019-04-05 15:28:33 -040029
Andrew Geisslerd1e89492021-02-12 15:35:20 -060030--- a/src/basic/format-util.h
31+++ b/src/basic/format-util.h
Andrew Geissler517393d2023-01-13 08:55:19 -060032@@ -34,13 +34,7 @@ assert_cc(sizeof(gid_t) == sizeof(uint32
Andrew Geissler7e0e3c02022-02-25 20:34:39 +000033 # error Unknown timex member size
Brad Bishop19323692019-04-05 15:28:33 -040034 #endif
35
36-#if SIZEOF_RLIM_T == 8
37-# define RLIM_FMT "%" PRIu64
38-#elif SIZEOF_RLIM_T == 4
39-# define RLIM_FMT "%" PRIu32
40-#else
41-# error Unknown rlim_t size
42-#endif
43+#define RLIM_FMT "%ju"
44
45 #if SIZEOF_DEV_T == 8
46 # define DEV_FMT "%" PRIu64
Andrew Geisslerd1e89492021-02-12 15:35:20 -060047--- a/src/basic/rlimit-util.c
48+++ b/src/basic/rlimit-util.c
Andrew Geissler517393d2023-01-13 08:55:19 -060049@@ -44,7 +44,7 @@ int setrlimit_closest(int resource, cons
Andrew Geissler09036742021-06-25 14:25:14 -050050 fixed.rlim_max == highest.rlim_max)
51 return 0;
52
53- log_debug("Failed at setting rlimit " RLIM_FMT " for resource RLIMIT_%s. Will attempt setting value " RLIM_FMT " instead.", rlim->rlim_max, rlimit_to_string(resource), fixed.rlim_max);
54+ log_debug("Failed at setting rlimit " RLIM_FMT " for resource RLIMIT_%s. Will attempt setting value " RLIM_FMT " instead.", (uintmax_t)rlim->rlim_max, rlimit_to_string(resource), (uintmax_t)fixed.rlim_max);
55
Andrew Geissler7e0e3c02022-02-25 20:34:39 +000056 return RET_NERRNO(setrlimit(resource, &fixed));
57 }
Andrew Geissler517393d2023-01-13 08:55:19 -060058@@ -307,13 +307,13 @@ int rlimit_format(const struct rlimit *r
Brad Bishop19323692019-04-05 15:28:33 -040059 if (rl->rlim_cur >= RLIM_INFINITY && rl->rlim_max >= RLIM_INFINITY)
Andrew Geissler7e0e3c02022-02-25 20:34:39 +000060 r = free_and_strdup(&s, "infinity");
Brad Bishop19323692019-04-05 15:28:33 -040061 else if (rl->rlim_cur >= RLIM_INFINITY)
Andrew Geissler7e0e3c02022-02-25 20:34:39 +000062- r = asprintf(&s, "infinity:" RLIM_FMT, rl->rlim_max);
63+ r = asprintf(&s, "infinity:" RLIM_FMT, (uintmax_t)rl->rlim_max);
Brad Bishop19323692019-04-05 15:28:33 -040064 else if (rl->rlim_max >= RLIM_INFINITY)
Andrew Geissler7e0e3c02022-02-25 20:34:39 +000065- r = asprintf(&s, RLIM_FMT ":infinity", rl->rlim_cur);
66+ r = asprintf(&s, RLIM_FMT ":infinity", (uintmax_t)rl->rlim_cur);
Brad Bishop19323692019-04-05 15:28:33 -040067 else if (rl->rlim_cur == rl->rlim_max)
Andrew Geissler7e0e3c02022-02-25 20:34:39 +000068- r = asprintf(&s, RLIM_FMT, rl->rlim_cur);
69+ r = asprintf(&s, RLIM_FMT, (uintmax_t)rl->rlim_cur);
Brad Bishop19323692019-04-05 15:28:33 -040070 else
Andrew Geissler7e0e3c02022-02-25 20:34:39 +000071- r = asprintf(&s, RLIM_FMT ":" RLIM_FMT, rl->rlim_cur, rl->rlim_max);
72+ r = asprintf(&s, RLIM_FMT ":" RLIM_FMT, (uintmax_t)rl->rlim_cur, (uintmax_t)rl->rlim_max);
73 if (r < 0)
Brad Bishop19323692019-04-05 15:28:33 -040074 return -ENOMEM;
Andrew Geissler7e0e3c02022-02-25 20:34:39 +000075
76@@ -403,7 +403,7 @@ int rlimit_nofile_safe(void) {
Brad Bishop19323692019-04-05 15:28:33 -040077
78 rl.rlim_cur = FD_SETSIZE;
79 if (setrlimit(RLIMIT_NOFILE, &rl) < 0)
80- return log_debug_errno(errno, "Failed to lower RLIMIT_NOFILE's soft limit to " RLIM_FMT ": %m", rl.rlim_cur);
81+ return log_debug_errno(errno, "Failed to lower RLIMIT_NOFILE's soft limit to " RLIM_FMT ": %m", (uintmax_t)rl.rlim_cur);
82
83 return 1;
84 }
Andrew Geisslerd1e89492021-02-12 15:35:20 -060085--- a/src/core/execute.c
86+++ b/src/core/execute.c
Andrew Geissler517393d2023-01-13 08:55:19 -060087@@ -5869,9 +5869,9 @@ void exec_context_dump(const ExecContext
Andrew Geisslerd1e89492021-02-12 15:35:20 -060088 for (unsigned i = 0; i < RLIM_NLIMITS; i++)
Brad Bishop19323692019-04-05 15:28:33 -040089 if (c->rlimit[i]) {
90 fprintf(f, "%sLimit%s: " RLIM_FMT "\n",
91- prefix, rlimit_to_string(i), c->rlimit[i]->rlim_max);
92+ prefix, rlimit_to_string(i), (uintmax_t)c->rlimit[i]->rlim_max);
93 fprintf(f, "%sLimit%sSoft: " RLIM_FMT "\n",
94- prefix, rlimit_to_string(i), c->rlimit[i]->rlim_cur);
95+ prefix, rlimit_to_string(i), (uintmax_t)c->rlimit[i]->rlim_cur);
96 }
97
98 if (c->ioprio_set) {