blob: 7533fde1e1217236b595b72133b5624e746abf1a [file] [log] [blame]
Andrew Geisslerd5838332022-05-27 11:33:10 -05001From 0542d27ebbb250c09bdcfcf9f2ea3d27426fe522 Mon Sep 17 00:00:00 2001
Brad Bishop19323692019-04-05 15:28:33 -04002From: Chen Qi <Qi.Chen@windriver.com>
3Date: Tue, 10 Jul 2018 15:40:17 +0800
William A. Kennington IIIac69b482021-06-02 12:28:27 -07004Subject: [PATCH] distinguish XSI-compliant strerror_r from GNU-specifi
Brad Bishop19323692019-04-05 15:28:33 -04005 strerror_r
6
7XSI-compliant strerror_r and GNU-specifi strerror_r are different.
8
9 int strerror_r(int errnum, char *buf, size_t buflen);
10 /* XSI-compliant */
11
12 char *strerror_r(int errnum, char *buf, size_t buflen);
13 /* GNU-specific */
14
15We need to distinguish between them. Otherwise, we'll get an int value
16assigned to (char *) variable, resulting in segment fault.
17
18Upstream-Status: Inappropriate [musl specific]
19
20Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
William A. Kennington IIIac69b482021-06-02 12:28:27 -070021
Brad Bishop19323692019-04-05 15:28:33 -040022---
William A. Kennington IIIac69b482021-06-02 12:28:27 -070023 src/libsystemd/sd-bus/bus-error.c | 5 +++++
24 src/libsystemd/sd-journal/journal-send.c | 5 +++++
Brad Bishop19323692019-04-05 15:28:33 -040025 2 files changed, 10 insertions(+)
26
Andrew Geisslerd1e89492021-02-12 15:35:20 -060027--- a/src/libsystemd/sd-bus/bus-error.c
28+++ b/src/libsystemd/sd-bus/bus-error.c
Andrew Geissler517393d2023-01-13 08:55:19 -060029@@ -409,7 +409,12 @@ static void bus_error_strerror(sd_bus_er
Brad Bishop19323692019-04-05 15:28:33 -040030 return;
31
32 errno = 0;
33+#ifndef __GLIBC__
34+ strerror_r(error, m, k);
35+ x = m;
36+#else
37 x = strerror_r(error, m, k);
38+#endif
39 if (errno == ERANGE || strlen(x) >= k - 1) {
40 free(m);
41 k *= 2;
Andrew Geissler517393d2023-01-13 08:55:19 -060042@@ -594,8 +599,12 @@ const char* _bus_error_message(const sd_
43
44 if (e && e->message)
45 return e->message;
46-
47+#ifndef __GLIBC__
48+ strerror_r(abs(error), buf, ERRNO_BUF_LEN);
49+ return buf;
50+#else
51 return strerror_r(abs(error), buf, ERRNO_BUF_LEN);
52+#endif
53 }
54
55 static bool map_ok(const sd_bus_error_map *map) {
William A. Kennington IIIac69b482021-06-02 12:28:27 -070056--- a/src/libsystemd/sd-journal/journal-send.c
57+++ b/src/libsystemd/sd-journal/journal-send.c
Andrew Geissler517393d2023-01-13 08:55:19 -060058@@ -381,7 +381,12 @@ static int fill_iovec_perror_and_send(co
William A. Kennington IIIac69b482021-06-02 12:28:27 -070059 char* j;
60
61 errno = 0;
62+#ifndef __GLIBC__
63+ strerror_r(_saved_errno_, buffer + 8 + k, n - 8 - k);
64+ j = buffer + 8 + k;
65+#else
66 j = strerror_r(_saved_errno_, buffer + 8 + k, n - 8 - k);
67+#endif
68 if (errno == 0) {
69 char error[STRLEN("ERRNO=") + DECIMAL_STR_MAX(int) + 1];
70