| Andrew Geissler | 517393d | 2023-01-13 08:55:19 -0600 | [diff] [blame^] | 1 | From f295491361ed7fbe729ef6f029d83f68b8e2bee3 Mon Sep 17 00:00:00 2001 |
| 2 | From: Mukilan Thiyagarajan <quic_mthiyaga@quicinc.com> |
| 3 | Date: Wed, 21 Dec 2022 09:04:06 +0000 |
| 4 | Subject: [PATCH] configure: Fix check-tcg not executing any tests |
| 5 | MIME-Version: 1.0 |
| 6 | Content-Type: text/plain; charset=UTF-8 |
| 7 | Content-Transfer-Encoding: 8bit |
| 8 | |
| 9 | After configuring with --target-list=hexagon-linux-user |
| 10 | running `make check-tcg` just prints the following: |
| 11 | |
| 12 | ``` |
| 13 | make: Nothing to be done for 'check-tcg' |
| 14 | ``` |
| 15 | |
| 16 | In the probe_target_compiler function, the 'break' |
| 17 | command is used incorrectly. There are no lexically |
| 18 | enclosing loops associated with that break command which |
| 19 | is an unspecfied behaviour in the POSIX standard. |
| 20 | |
| 21 | The dash shell implementation aborts the currently executing |
| 22 | loop, in this case, causing the rest of the logic for the loop |
| 23 | in line 2490 to be skipped, which means no Makefiles are |
| 24 | generated for the tcg target tests. |
| 25 | |
| 26 | Fixes: c3b570b5a9a24d25 (configure: don't enable |
| 27 | cross compilers unless in target_list) |
| 28 | |
| 29 | Signed-off-by: Mukilan Thiyagarajan <quic_mthiyaga@quicinc.com> |
| 30 | Reviewed-by: Richard Henderson <richard.henderson@linaro.org> |
| 31 | Link: https://patchew.org/QEMU/20221207082309.9966-1-quic._5Fmthiyaga@quicinc.com/ |
| 32 | Message-Id: <20221207082309.9966-1-quic_mthiyaga@quicinc.com> |
| 33 | Signed-off-by: Alex Bennée <alex.bennee@linaro.org> |
| 34 | Message-Id: <20221221090411.1995037-2-alex.bennee@linaro.org> |
| 35 | |
| 36 | Upstream-Status: Backport [https://github.com/qemu/qemu/commit/73acb87be536d23e42db73a306104d8fd316ff20] |
| 37 | Signed-off-by: Alexander Kanavin <alex@linutronix.de> |
| 38 | --- |
| 39 | configure | 4 +--- |
| 40 | 1 file changed, 1 insertion(+), 3 deletions(-) |
| 41 | |
| 42 | diff --git a/configure b/configure |
| 43 | index 0c1db72b8..6b4589273 100755 |
| 44 | --- a/configure |
| 45 | +++ b/configure |
| 46 | @@ -1881,9 +1881,7 @@ probe_target_compiler() { |
| 47 | # We shall skip configuring the target compiler if the user didn't |
| 48 | # bother enabling an appropriate guest. This avoids building |
| 49 | # extraneous firmware images and tests. |
| 50 | - if test "${target_list#*$1}" != "$1"; then |
| 51 | - break; |
| 52 | - else |
| 53 | + if test "${target_list#*$1}" = "$1"; then |
| 54 | return 1 |
| 55 | fi |
| 56 | |