| Brad Bishop | bba38f3 | 2018-08-23 16:11:46 +0800 | [diff] [blame] | 1 | From 0d88b73d189ea3440ccaab00418d6469f76fa590 Mon Sep 17 00:00:00 2001 |
| 2 | From: Michal Hocko <mhocko@suse.com> |
| 3 | Date: Wed, 18 Jul 2018 11:24:29 +0200 |
| 4 | Subject: [PATCH] cgrulesengd: remove umask(0) |
| 5 | |
| 6 | One of our partners has noticed that cgred daemon is creating a log file |
| 7 | (/var/log/cgred) with too wide permissions (0666) and that is seen as |
| 8 | a security bug because an untrusted user can write to otherwise |
| 9 | restricted area. CVE-2018-14348 has been assigned to this issue. |
| 10 | |
| 11 | CVE: CVE-2018-14348 |
| 12 | Upstream-Status: Backport [https://sourceforge.net/p/libcg/libcg/ci/0d88b73d189ea3440ccaab00418d6469f76fa590] |
| 13 | |
| 14 | Signed-off-by: Michal Hocko <mhocko@suse.com> |
| 15 | Acked-by: Balbir Singh <bsingharora@gmail.com> |
| 16 | Signed-off-by: Jagadeesh Krishnanjanappa <jkrishnanjanappa@mvista.com> |
| 17 | --- |
| 18 | src/daemon/cgrulesengd.c | 3 --- |
| 19 | 1 file changed, 3 deletions(-) |
| 20 | |
| 21 | diff --git a/src/daemon/cgrulesengd.c b/src/daemon/cgrulesengd.c |
| 22 | index ea51f11..0d288f3 100644 |
| 23 | --- a/src/daemon/cgrulesengd.c |
| 24 | +++ b/src/daemon/cgrulesengd.c |
| 25 | @@ -889,9 +889,6 @@ int cgre_start_daemon(const char *logp, const int logf, |
| 26 | } else if (pid > 0) { |
| 27 | exit(EXIT_SUCCESS); |
| 28 | } |
| 29 | - |
| 30 | - /* Change the file mode mask. */ |
| 31 | - umask(0); |
| 32 | } else { |
| 33 | flog(LOG_DEBUG, "Not using daemon mode\n"); |
| 34 | pid = getpid(); |
| 35 | -- |
| 36 | 2.13.3 |
| 37 | |