| Brad Bishop | d7bf8c1 | 2018-02-25 22:55:05 -0500 | [diff] [blame] | 1 | From 7a316dad0697af2ef4e8079a5af51565a8195aa6 Mon Sep 17 00:00:00 2001 |
| 2 | From: Hongxu Jia <hongxu.jia@windriver.com> |
| 3 | Date: Mon, 24 Jul 2017 01:42:30 -0400 |
| 4 | Subject: [PATCH] userhelper.c: fix formatting issues |
| 5 | |
| 6 | Fixed when compile with "-Wformat -Wformat-security -Werror=format-security": |
| 7 | |../usermode-1.111/userhelper.c:585:4: error: format not a string |
| 8 | literal and no format arguments [-Werror=format-security] |
| 9 | | text = g_strdup_printf(dgettext(data->domain, data->banner)); |
| 10 | | ^~~~ |
| 11 | |
| 12 | Upstream-Status: Pending |
| 13 | |
| 14 | Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com> |
| 15 | --- |
| 16 | userhelper.c | 2 +- |
| 17 | 1 file changed, 1 insertion(+), 1 deletion(-) |
| 18 | |
| 19 | diff --git a/userhelper.c b/userhelper.c |
| 20 | index 76ad492..ee0da49 100644 |
| 21 | --- a/userhelper.c |
| 22 | +++ b/userhelper.c |
| 23 | @@ -582,7 +582,7 @@ converse_console(int num_msg, const struct pam_message **msg, |
| 24 | |
| 25 | if (banner == 0) { |
| 26 | if ((data->banner != NULL) && (data->domain != NULL)) { |
| 27 | - text = g_strdup_printf(dgettext(data->domain, data->banner)); |
| 28 | + text = g_strdup_printf("%s", dgettext(data->domain, data->banner)); |
| 29 | } else { |
| 30 | if ((service != NULL) && (strlen(service) > 0)) { |
| 31 | if (data->fallback_allowed) { |
| 32 | -- |
| 33 | 2.8.1 |
| 34 | |