Brad Bishop | 6e60e8b | 2018-02-01 10:27:11 -0500 | [diff] [blame] | 1 | From f36c9476d2816e0d3e61c9e13c22ed73883cb54a Mon Sep 17 00:00:00 2001 |
| 2 | From: Khem Raj <raj.khem@gmail.com> |
| 3 | Date: Mon, 24 Apr 2017 12:13:43 -0700 |
| 4 | Subject: [PATCH] compare the first character of string to be null or not |
| 5 | |
| 6 | Fixes |
| 7 | |
| 8 | error: ISO C++ forbids comparison between pointer and integer [-fpermissive] |
| 9 | | if (value[0] == '\0') |
| 10 | | ^~~~ |
| 11 | |
| 12 | Signed-off-by: Khem Raj <raj.khem@gmail.com> |
| 13 | --- |
| 14 | js/src/shell/jsoptparse.cpp | 2 +- |
| 15 | 1 file changed, 1 insertion(+), 1 deletion(-) |
| 16 | |
| 17 | diff --git a/js/src/shell/jsoptparse.cpp b/js/src/shell/jsoptparse.cpp |
| 18 | index b49d0a5..612aa00 100644 |
| 19 | --- a/js/src/shell/jsoptparse.cpp |
| 20 | +++ b/js/src/shell/jsoptparse.cpp |
| 21 | @@ -243,7 +243,7 @@ OptionParser::extractValue(size_t argc, char **argv, size_t *i, char **value) |
| 22 | char *eq = strchr(argv[*i], '='); |
| 23 | if (eq) { |
| 24 | *value = eq + 1; |
| 25 | - if (value[0] == '\0') |
| 26 | + if (value[0][0] == '\0') |
| 27 | return error("A value is required for option %.*s", eq - argv[*i], argv[*i]); |
| 28 | return Okay; |
| 29 | } |
| 30 | -- |
| 31 | 2.12.2 |
| 32 | |