blob: c1ba42eeedf5b21b2182436b267d898eacf0d6f9 [file] [log] [blame]
Brad Bishop316dfdd2018-06-25 12:45:53 -04001From 1e6d40fec16a94d1a4bd40634405267200b7e969 Mon Sep 17 00:00:00 2001
2From: marxin <mliska@suse.cz>
3Date: Tue, 10 Apr 2018 15:21:40 +0200
4Subject: [PATCH] Fix GCC 8 warning:
5MIME-Version: 1.0
6Content-Type: text/plain; charset=UTF-8
7Content-Transfer-Encoding: 8bit
8
9/home/marxin/Programming/libyui/src/YDialog.cc: In static member function static void YDialog::showText(const string&, bool)’:
10/home/marxin/Programming/libyui/src/YDialog.cc:690:26: error: catching polymorphic type class YUIException by value [-Werror=catch-value=]
11 catch ( YUIException exception )
12 ^~~~~~~~~
13/home/marxin/Programming/libyui/src/YDialog.cc: In static member function static bool YDialog::showRelNotesText()’:
14/home/marxin/Programming/libyui/src/YDialog.cc:814:26: error: catching polymorphic type class YUIException by value [-Werror=catch-value=]
15 catch ( YUIException exception )
16 ^~~~~~~~~
17---
18Upstream-Status: Submitted [https://github.com/libyui/libyui/pull/122]
19Signed-off-by: Khem Raj <raj.khem@gmail.com>
20
21 src/YDialog.cc | 4 ++--
22 1 file changed, 2 insertions(+), 2 deletions(-)
23
24diff --git a/src/YDialog.cc b/src/YDialog.cc
25index 92e5031..8ecff90 100644
26--- a/src/YDialog.cc
27+++ b/src/YDialog.cc
28@@ -687,7 +687,7 @@ YDialog::showText( const std::string & text, bool useRichText )
29 dialog->waitForEvent();
30 dialog->destroy();
31 }
32- catch ( YUIException exception )
33+ catch ( YUIException &exception )
34 {
35 // Don't let the application die just because help couldn't be displayed.
36
37@@ -811,7 +811,7 @@ YDialog::showRelNotesText()
38 }
39 dialog->destroy();
40 }
41- catch ( YUIException exception )
42+ catch ( YUIException &exception )
43 {
44 // Don't let the application die just because RN couldn't be displayed.
45
46--
472.17.0
48