| Andrew Geissler | 635e0e4 | 2020-08-21 15:58:33 -0500 | [diff] [blame^] | 1 | From b65152ebc03832972115e6d98e50cb6190d01793 Mon Sep 17 00:00:00 2001 |
| 2 | From: =?UTF-8?q?Ond=C5=99ej=20Lyson=C4=9Bk?= <olysonek@redhat.com> |
| 3 | Date: Mon, 3 Feb 2020 13:18:13 +0100 |
| 4 | Subject: [PATCH 1/3] Drop superfluous global variable definitions |
| 5 | |
| 6 | The file minicom.c, by including the minicom.h header, already defines |
| 7 | the global variables 'dial_user' and 'dial_pass'. The object file |
| 8 | minicom.o is always linked to dial.o. Thus the definitions in dial.c |
| 9 | can be dropped. |
| 10 | |
| 11 | This fixes linking with gcc 10 which uses -fno-common by default, |
| 12 | disallowing multiple global variable definitions. |
| 13 | |
| 14 | Upstream-Status: Pending |
| 15 | Signed-off-by: Khem Raj <raj.khem@gmail.com> |
| 16 | --- |
| 17 | src/dial.c | 2 -- |
| 18 | 1 file changed, 2 deletions(-) |
| 19 | |
| 20 | diff --git a/src/dial.c b/src/dial.c |
| 21 | index eada5ee..d9d481f 100644 |
| 22 | --- a/src/dial.c |
| 23 | +++ b/src/dial.c |
| 24 | @@ -146,8 +146,6 @@ static int newtype; |
| 25 | /* Access to ".dialdir" denied? */ |
| 26 | static int dendd = 0; |
| 27 | static char *tagged; |
| 28 | -char *dial_user; |
| 29 | -char *dial_pass; |
| 30 | |
| 31 | /* Change the baud rate. Treat all characters in the given array as if |
| 32 | * they were key presses within the comm parameters dialog (C-A P) and |
| 33 | -- |
| 34 | 2.24.1 |
| 35 | |