blob: 48fd007e11bc774fbbbf90c9223ff4b1ce135a4e [file] [log] [blame]
Andrew Geissler706d5aa2021-02-12 15:55:30 -06001From 4938705454cf46cfe8deac8ce457d5d2432cbead Mon Sep 17 00:00:00 2001
Brad Bishop19323692019-04-05 15:28:33 -04002From: Chen Qi <Qi.Chen@windriver.com>
3Date: Tue, 10 Jul 2018 15:40:17 +0800
Andrew Geissler706d5aa2021-02-12 15:55:30 -06004Subject: [PATCH] distinguish XSI-compliant strerror_r from GNU-specifi
Brad Bishop19323692019-04-05 15:28:33 -04005 strerror_r
6
7XSI-compliant strerror_r and GNU-specifi strerror_r are different.
8
9 int strerror_r(int errnum, char *buf, size_t buflen);
10 /* XSI-compliant */
11
12 char *strerror_r(int errnum, char *buf, size_t buflen);
13 /* GNU-specific */
14
15We need to distinguish between them. Otherwise, we'll get an int value
16assigned to (char *) variable, resulting in segment fault.
17
18Upstream-Status: Inappropriate [musl specific]
19
20Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
Andrew Geissler706d5aa2021-02-12 15:55:30 -060021
Brad Bishop19323692019-04-05 15:28:33 -040022---
23 src/journal/journal-send.c | 5 +++++
24 src/libsystemd/sd-bus/bus-error.c | 5 +++++
25 2 files changed, 10 insertions(+)
26
Andrew Geissler706d5aa2021-02-12 15:55:30 -060027Index: systemd-stable/src/journal/journal-send.c
28===================================================================
29--- systemd-stable.orig/src/journal/journal-send.c
30+++ systemd-stable/src/journal/journal-send.c
31@@ -348,7 +348,12 @@ static int fill_iovec_perror_and_send(co
Brad Bishop19323692019-04-05 15:28:33 -040032 char* j;
33
34 errno = 0;
35+#ifndef __GLIBC__
36+ strerror_r(_saved_errno_, buffer + 8 + k, n - 8 - k);
37+ j = buffer + 8 + k;
38+#else
39 j = strerror_r(_saved_errno_, buffer + 8 + k, n - 8 - k);
40+#endif
41 if (errno == 0) {
42 char error[STRLEN("ERRNO=") + DECIMAL_STR_MAX(int) + 1];
43
Andrew Geissler706d5aa2021-02-12 15:55:30 -060044Index: systemd-stable/src/libsystemd/sd-bus/bus-error.c
45===================================================================
46--- systemd-stable.orig/src/libsystemd/sd-bus/bus-error.c
47+++ systemd-stable/src/libsystemd/sd-bus/bus-error.c
48@@ -379,7 +379,12 @@ static void bus_error_strerror(sd_bus_er
Brad Bishop19323692019-04-05 15:28:33 -040049 return;
50
51 errno = 0;
52+#ifndef __GLIBC__
53+ strerror_r(error, m, k);
54+ x = m;
55+#else
56 x = strerror_r(error, m, k);
57+#endif
58 if (errno == ERANGE || strlen(x) >= k - 1) {
59 free(m);
60 k *= 2;