blob: 373669461b9fb70bc1e9a798abc51ee4e3a6d889 [file] [log] [blame]
Andrew Geissler97771a32021-03-05 15:23:11 -06001From de10fbc2386dcac3ab810c49b6977b2ee01bf426 Mon Sep 17 00:00:00 2001
Andrew Geissler82c905d2020-04-13 13:39:40 -05002From: Khem Raj <raj.khem@gmail.com>
Andrew Geissler97771a32021-03-05 15:23:11 -06003Date: Wed, 17 Feb 2021 13:30:23 -0800
Andrew Geissler82c905d2020-04-13 13:39:40 -05004Subject: [PATCH] setup.py: Do not mix C and C++ compiler options
5
6EXTRA_ENV_COMPILE_ARGS is used both with CC and CXX
7so using -std=c++11 or -std=gnu99 together will cause
8build time errors espcially with clang
9
Andrew Geissler97771a32021-03-05 15:23:11 -060010Keep '-std=c++11' to fix native build error
Andrew Geissler82c905d2020-04-13 13:39:40 -050011with old gcc (such as gcc 5.4.0 on ubuntu 16.04), for clang
12we will remove them through GRPC_PYTHON_CFLAGS at do_compile
13in bb recipe.
14
Andrew Geissler97771a32021-03-05 15:23:11 -060015While export CC="gcc ", cc_args is None, it will
Andrew Geissler82c905d2020-04-13 13:39:40 -050016cause subprocess.Popen always return 1. On centos 8, if you don't
17install package libatomic, there will be a native build error
18`cannot find /usr/lib64/libatomic.so.1.2.0'.
19
20Add no harm '-g' to cc_args if cc_args is empty.
21
22Upstream-Status: Inappropriate [oe specific]
Andrew Geissler97771a32021-03-05 15:23:11 -060023
24Signed-off-by: Khem Raj <raj.khem@gmail.com>
Andrew Geissler82c905d2020-04-13 13:39:40 -050025Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
26---
Andrew Geissler97771a32021-03-05 15:23:11 -060027 setup.py | 9 ++++++---
Andrew Geissler82c905d2020-04-13 13:39:40 -050028 src/python/grpcio/commands.py | 5 ++++-
Andrew Geissler97771a32021-03-05 15:23:11 -060029 2 files changed, 10 insertions(+), 4 deletions(-)
Andrew Geissler82c905d2020-04-13 13:39:40 -050030
31diff --git a/setup.py b/setup.py
Andrew Geissler97771a32021-03-05 15:23:11 -060032index 4b8c9d4..271b7b1 100644
Andrew Geissler82c905d2020-04-13 13:39:40 -050033--- a/setup.py
34+++ b/setup.py
Andrew Geissler97771a32021-03-05 15:23:11 -060035@@ -172,8 +172,11 @@ def check_linker_need_libatomic():
36 """Test if linker on system needs libatomic."""
37 code_test = (b'#include <atomic>\n' +
38 b'int main() { return std::atomic<int64_t>{}; }')
39- cxx = os.environ.get('CXX', 'c++')
40- cpp_test = subprocess.Popen([cxx, '-x', 'c++', '-std=c++11', '-'],
41+ cxx, cxx_args = os.environ.get('CXX').split(' ', 1) or 'c++'
42+ if not cxx_args:
43+ cxx_args = "-g"
Andrew Geissler82c905d2020-04-13 13:39:40 -050044+
Andrew Geissler97771a32021-03-05 15:23:11 -060045+ cpp_test = subprocess.Popen([cxx, cxx_args, '-x', 'c++', '-std=c++11', '-'],
46 stdin=PIPE,
47 stdout=PIPE,
48 stderr=PIPE)
49@@ -183,7 +186,7 @@ def check_linker_need_libatomic():
50 # Double-check to see if -latomic actually can solve the problem.
51 # https://github.com/grpc/grpc/issues/22491
52 cpp_test = subprocess.Popen(
53- [cxx, '-x', 'c++', '-std=c++11', '-latomic', '-'],
54+ [cxx, cxx_args, '-x', 'c++', '-std=c++11', '-latomic', '-'],
55 stdin=PIPE,
56 stdout=PIPE,
57 stderr=PIPE)
Andrew Geissler82c905d2020-04-13 13:39:40 -050058diff --git a/src/python/grpcio/commands.py b/src/python/grpcio/commands.py
Andrew Geissler97771a32021-03-05 15:23:11 -060059index a8b2ff5..b928201 100644
Andrew Geissler82c905d2020-04-13 13:39:40 -050060--- a/src/python/grpcio/commands.py
61+++ b/src/python/grpcio/commands.py
Andrew Geissler97771a32021-03-05 15:23:11 -060062@@ -219,7 +219,10 @@ class BuildExt(build_ext.build_ext):
Andrew Geissler82c905d2020-04-13 13:39:40 -050063 """
Andrew Geissler97771a32021-03-05 15:23:11 -060064 try:
65 # TODO(lidiz) Remove the generated a.out for success tests.
66- cc_test = subprocess.Popen(['cc', '-x', 'c', '-std=c++11', '-'],
67+ cc_test, cc_args = os.environ.get('CC').split(' ', 1) or 'gcc'
68+ if not cc_args:
69+ cc_args = "-g"
70+ cc_test = subprocess.Popen([cc_test, cc_args, '-x', 'c', '-std=c++11', '-'],
71 stdin=subprocess.PIPE,
72 stdout=subprocess.PIPE,
73 stderr=subprocess.PIPE)
Andrew Geissler82c905d2020-04-13 13:39:40 -050074--
Andrew Geissler97771a32021-03-05 15:23:11 -0600752.30.1
Andrew Geissler82c905d2020-04-13 13:39:40 -050076