Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / openbmc / 87f5cff0cfca11f43851cb3d7d49dd96ced7fe03 / . / meta-openembedded / meta-oe / recipes-extended / hplip / hplip / 0005-hp_ipp.c-Add-printf-format-to-snprintf-calls.patch
blob: d844e49ad384da3d2edb2f6428e853558f8856c9 [file] [log] [blame]
Andrew Geissler87f5cff2022-09-30 13:13:31 -0500[diff] [blame^]1From 4b3014df3990d90d6929510f2bde073171503329 Mon Sep 17 00:00:00 2001
2From: Khem Raj <raj.khem@gmail.com>
3Date: Fri, 2 Sep 2022 18:18:44 -0700
4Subject: [PATCH] hp_ipp.c: Add printf format to snprintf calls
5
6Avoid -Wformat warnings
7
8Signed-off-by: Khem Raj <raj.khem@gmail.com>
9---
10 protocol/hp_ipp.c | 14 +++++++-------
11 1 file changed, 7 insertions(+), 7 deletions(-)
12
13diff --git a/protocol/hp_ipp.c b/protocol/hp_ipp.c
14index 597d9b9..a027baf 100644
15--- a/protocol/hp_ipp.c
16+++ b/protocol/hp_ipp.c
17@@ -112,7 +112,7 @@ int addCupsPrinter(char *name, char *device_uri, char *location, char *ppd_file,
18 }
19
20 if ( info == NULL )
21- snprintf( info,sizeof(info), name );
22+ snprintf( info,sizeof(info), "%s", name );
23
24 sprintf( printer_uri, "ipp://localhost/printers/%s", name );
25
26@@ -513,27 +513,27 @@ int __parsePrinterAttributes(ipp_t *response, printer_t **printer_list)
27
28 if ( strcmp(attr_name, "printer-name") == 0 &&
29 val_tag == IPP_TAG_NAME ) {
30- snprintf(t_printer->name, sizeof(t_printer->name),ippGetString(attr, 0, NULL) );
31+ snprintf(t_printer->name, sizeof(t_printer->name), "%s", ippGetString(attr, 0, NULL) );
32 }
33 else if ( strcmp(attr_name, "device-uri") == 0 &&
34 val_tag == IPP_TAG_URI ) {
35- snprintf(t_printer->device_uri,sizeof(t_printer->device_uri), ippGetString(attr, 0, NULL) );
36+ snprintf(t_printer->device_uri,sizeof(t_printer->device_uri), "%s", ippGetString(attr, 0, NULL) );
37 }
38 else if ( strcmp(attr_name, "printer-uri-supported") == 0 &&
39 val_tag == IPP_TAG_URI ) {
40- snprintf(t_printer->printer_uri,sizeof(t_printer->printer_uri), ippGetString(attr, 0, NULL) );
41+ snprintf(t_printer->printer_uri,sizeof(t_printer->printer_uri), "%s", ippGetString(attr, 0, NULL) );
42 }
43 else if ( strcmp(attr_name, "printer-info") == 0 &&
44 val_tag == IPP_TAG_TEXT ) {
45- snprintf(t_printer->info,sizeof(t_printer->info), ippGetString(attr, 0, NULL) );
46+ snprintf(t_printer->info,sizeof(t_printer->info), "%s", ippGetString(attr, 0, NULL) );
47 }
48 else if ( strcmp(attr_name, "printer-location") == 0 &&
49 val_tag == IPP_TAG_TEXT ) {
50- snprintf(t_printer->location,sizeof(t_printer->location),ippGetString(attr, 0, NULL) );
51+ snprintf(t_printer->location,sizeof(t_printer->location), "%s", ippGetString(attr, 0, NULL) );
52 }
53 else if ( strcmp(attr_name, "printer-make-and-model") == 0 &&
54 val_tag == IPP_TAG_TEXT ) {
55- snprintf(t_printer->make_model,sizeof(t_printer->make_model),ippGetString(attr, 0, NULL) );
56+ snprintf(t_printer->make_model,sizeof(t_printer->make_model), "%s", ippGetString(attr, 0, NULL) );
57 }
58 else if ( strcmp(attr_name, "printer-state") == 0 &&
59 val_tag == IPP_TAG_ENUM ) {
60--
612.37.3
62