| Andrew Geissler | 82c905d | 2020-04-13 13:39:40 -0500 | [diff] [blame] | 1 | https://bugs.launchpad.net/hplip/+bug/1672256 |
| 2 | |
| 3 | memcpy should never be used with overlapping memory regions |
| 4 | |
| 5 | --- a/io/hpmud/musb.c |
| 6 | +++ b/io/hpmud/musb.c |
| 7 | @@ -775,7 +775,7 @@ static int device_id(int fd, unsigned ch |
| 8 | len = size-1; /* leave byte for zero termination */ |
| 9 | if (len > 2) |
| 10 | len -= 2; |
| 11 | - memcpy(buffer, buffer+2, len); /* remove length */ |
| 12 | + memmove(buffer, buffer+2, len); /* remove length */ |
| 13 | buffer[len]=0; |
| 14 | DBG("read actual device_id successfully fd=%d len=%d\n", fd, len); |
| 15 | |