| Patrick Williams | 8dd6848 | 2022-10-04 07:57:18 -0500 | [diff] [blame^] | 1 | From 3126adccaf9c9dc669bb7e1f96326c03da4b570d Mon Sep 17 00:00:00 2001 |
| 2 | From: Jerome Forissier <jerome.forissier@linaro.org> |
| 3 | Date: Fri, 5 Aug 2022 09:48:03 +0200 |
| 4 | Subject: [PATCH] core: link: add --no-warn-rwx-segments |
| 5 | |
| 6 | Signed-off-by: Anton Antonov <Anton.Antonov@arm.com> |
| 7 | Upstream-Status: Backport [https://github.com/OP-TEE/optee_os/pull/5474] |
| 8 | |
| 9 | binutils ld.bfd generates one RWX LOAD segment by merging several sections |
| 10 | with mixed R/W/X attributes (.text, .rodata, .data). After version 2.38 it |
| 11 | also warns by default when that happens [1], which breaks the build due to |
| 12 | --fatal-warnings. The RWX segment is not a problem for the TEE core, since |
| 13 | that information is not used to set memory permissions. Therefore, silence |
| 14 | the warning. |
| 15 | |
| 16 | Link: [1] https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=ba951afb99912da01a6e8434126b8fac7aa75107 |
| 17 | Link: https://sourceware.org/bugzilla/show_bug.cgi?id=29448 |
| 18 | Reported-by: Dominique Martinet <dominique.martinet@atmark-techno.com> |
| 19 | Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org> |
| 20 | Acked-by: Jens Wiklander <jens.wiklander@linaro.org> |
| 21 | |
| 22 | --- |
| 23 | core/arch/arm/kernel/link.mk | 8 ++++++-- |
| 24 | 1 file changed, 6 insertions(+), 2 deletions(-) |
| 25 | |
| 26 | diff --git a/core/arch/arm/kernel/link.mk b/core/arch/arm/kernel/link.mk |
| 27 | index 69375ad6..bea239cf 100644 |
| 28 | --- a/core/arch/arm/kernel/link.mk |
| 29 | +++ b/core/arch/arm/kernel/link.mk |
| 30 | @@ -17,6 +17,7 @@ link-ldflags += -T $(link-script-pp) -Map=$(link-out-dir)/tee.map |
| 31 | link-ldflags += --sort-section=alignment |
| 32 | link-ldflags += --fatal-warnings |
| 33 | link-ldflags += --gc-sections |
| 34 | +link-ldflags += $(call ld-option,--no-warn-rwx-segments) |
| 35 | |
| 36 | link-ldadd = $(LDADD) |
| 37 | link-ldadd += $(libdeps) |
| 38 | @@ -37,6 +38,7 @@ link-script-cppflags := \ |
| 39 | $(cppflagscore)) |
| 40 | |
| 41 | ldargs-all_objs := -T $(link-script-dummy) --no-check-sections \ |
| 42 | + $(call ld-option,--no-warn-rwx-segments) \ |
| 43 | $(link-objs) $(link-ldadd) $(libgcccore) |
| 44 | cleanfiles += $(link-out-dir)/all_objs.o |
| 45 | $(link-out-dir)/all_objs.o: $(objs) $(libdeps) $(MAKEFILE_LIST) |
| 46 | @@ -49,7 +51,8 @@ $(link-out-dir)/unpaged_entries.txt: $(link-out-dir)/all_objs.o |
| 47 | $(q)$(NMcore) $< | \ |
| 48 | $(AWK) '/ ____keep_pager/ { printf "-u%s ", $$3 }' > $@ |
| 49 | |
| 50 | -unpaged-ldargs = -T $(link-script-dummy) --no-check-sections --gc-sections |
| 51 | +unpaged-ldargs := -T $(link-script-dummy) --no-check-sections --gc-sections \ |
| 52 | + $(call ld-option,--no-warn-rwx-segments) |
| 53 | unpaged-ldadd := $(objs) $(link-ldadd) $(libgcccore) |
| 54 | cleanfiles += $(link-out-dir)/unpaged.o |
| 55 | $(link-out-dir)/unpaged.o: $(link-out-dir)/unpaged_entries.txt |
| 56 | @@ -77,7 +80,8 @@ $(link-out-dir)/init_entries.txt: $(link-out-dir)/all_objs.o |
| 57 | $(q)$(NMcore) $< | \ |
| 58 | $(AWK) '/ ____keep_init/ { printf "-u%s ", $$3 }' > $@ |
| 59 | |
| 60 | -init-ldargs := -T $(link-script-dummy) --no-check-sections --gc-sections |
| 61 | +init-ldargs := -T $(link-script-dummy) --no-check-sections --gc-sections \ |
| 62 | + $(call ld-option,--no-warn-rwx-segments) |
| 63 | init-ldadd := $(link-objs-init) $(link-out-dir)/version.o $(link-ldadd) \ |
| 64 | $(libgcccore) |
| 65 | cleanfiles += $(link-out-dir)/init.o |