Andrew Geissler | 595f630 | 2022-01-24 19:11:47 +0000 | [diff] [blame] | 1 | From fbc10748c7c59d82024a4d35146b8dfef8d52927 Mon Sep 17 00:00:00 2001 |
| 2 | From: Khem Raj <raj.khem@gmail.com> |
| 3 | Date: Fri, 21 Jan 2022 15:15:11 -0800 |
| 4 | Subject: [PATCH 1/2] pass correct parameters to getdents64 |
| 5 | |
| 6 | Fixes |
| 7 | ../git/src/basic/recurse-dir.c:57:40: error: incompatible pointer types passing 'uint8_t *' (aka 'unsigned char *') to parameter of type 'struct dirent *' [-Werror,-Wincompatible-pointer-types] |
| 8 | n = getdents64(dir_fd, (uint8_t*) de->buffer + de->buffer_size, bs - de->buffer_size); |
| 9 | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ |
| 10 | |
| 11 | ../git/src/basic/stat-util.c:102:28: error: incompatible pointer types passing 'union (unnamed union at ../git/src/basic/stat-util.c:78:9) *' to parameter of type 'struct dirent *' [-Werror,-Wincompatible-pointer-types] |
| 12 | n = getdents64(fd, &buffer, sizeof(buffer)); |
| 13 | ^~~~~~~ |
| 14 | |
| 15 | Upstream-Status: Pending |
| 16 | Signed-off-by: Khem Raj <raj.khem@gmail.com> |
| 17 | --- |
| 18 | src/basic/recurse-dir.c | 2 +- |
| 19 | src/basic/stat-util.c | 2 +- |
| 20 | 2 files changed, 2 insertions(+), 2 deletions(-) |
| 21 | |
| 22 | diff --git a/src/basic/recurse-dir.c b/src/basic/recurse-dir.c |
| 23 | index efa1797b7b..797285e3be 100644 |
| 24 | --- a/src/basic/recurse-dir.c |
| 25 | +++ b/src/basic/recurse-dir.c |
| 26 | @@ -54,7 +54,7 @@ int readdir_all(int dir_fd, |
| 27 | bs = MIN(MALLOC_SIZEOF_SAFE(de) - offsetof(DirectoryEntries, buffer), (size_t) SSIZE_MAX); |
| 28 | assert(bs > de->buffer_size); |
| 29 | |
| 30 | - n = getdents64(dir_fd, (uint8_t*) de->buffer + de->buffer_size, bs - de->buffer_size); |
| 31 | + n = getdents64(dir_fd, de->buffer + de->buffer_size, bs - de->buffer_size); |
| 32 | if (n < 0) |
| 33 | return -errno; |
| 34 | if (n == 0) |
| 35 | diff --git a/src/basic/stat-util.c b/src/basic/stat-util.c |
| 36 | index efac7b002e..9e1fe7f5a0 100644 |
| 37 | --- a/src/basic/stat-util.c |
| 38 | +++ b/src/basic/stat-util.c |
| 39 | @@ -99,7 +99,7 @@ int dir_is_empty_at(int dir_fd, const char *path) { |
| 40 | return fd; |
| 41 | } |
| 42 | |
| 43 | - n = getdents64(fd, &buffer, sizeof(buffer)); |
| 44 | + n = getdents64(fd, (struct dirent *)&buffer, sizeof(buffer)); |
| 45 | if (n < 0) |
| 46 | return -errno; |
| 47 | |
| 48 | -- |
| 49 | 2.34.1 |
| 50 | |