blob: 4713da174f8493ce99b7b0aff5e8d5b4c7d303d5 [file] [log] [blame]
Andrew Geissler97771a32021-03-05 15:23:11 -06001From 9b2f1d400db8b8d0045f5a58a748a2dc52b5c9ef Mon Sep 17 00:00:00 2001
2From: Khem Raj <raj.khem@gmail.com>
3Date: Wed, 17 Feb 2021 13:38:55 -0800
4Subject: [PATCH] setup.py: Do not mix C and C++ compiler options
5
6EXTRA_ENV_COMPILE_ARGS is used both with CC and CXX
7so using -std=c++11 or -std=gnu99 together will cause
8build time errors espcially with clang
9
10Keep '-std=c++11' to fix native build error
11with old gcc (such as gcc 5.4.0 on ubuntu 16.04), for clang
12we will remove them through GRPC_PYTHON_CFLAGS at do_compile
13in bb recipe.
14
15While export CC="gcc ", cc_args is None, it will
16cause subprocess.Popen always return 1. On centos 8, if you don't
17install package libatomic, there will be a native build error
18`cannot find /usr/lib64/libatomic.so.1.2.0'.
19
20Add no harm '-g' to cc_args if cc_args is empty.
21
22Upstream-Status: Inappropriate [oe specific]
23
24Signed-off-by: Khem Raj <raj.khem@gmail.com>
25---
26 setup.py | 9 ++++++---
27 1 file changed, 6 insertions(+), 3 deletions(-)
28
Andrew Geissler97771a32021-03-05 15:23:11 -060029--- a/setup.py
30+++ b/setup.py
Andrew Geissler9aee5002022-03-30 16:27:02 +000031@@ -87,8 +87,11 @@ def check_linker_need_libatomic():
Andrew Geissler97771a32021-03-05 15:23:11 -060032 """Test if linker on system needs libatomic."""
33 code_test = (b'#include <atomic>\n' +
34 b'int main() { return std::atomic<int64_t>{}; }')
35- cxx = os.environ.get('CXX', 'c++')
36- cpp_test = subprocess.Popen([cxx, '-x', 'c++', '-std=c++11', '-'],
37+ cxx, cxx_args = os.environ.get('CXX').split(' ', 1) or 'c++'
38+ if not cxx_args:
39+ cxx_args = "-g"
40+
41+ cpp_test = subprocess.Popen([cxx, cxx_args, '-x', 'c++', '-std=c++11', '-'],
42 stdin=PIPE,
43 stdout=PIPE,
44 stderr=PIPE)
Andrew Geissler9aee5002022-03-30 16:27:02 +000045@@ -98,7 +101,7 @@ def check_linker_need_libatomic():
Andrew Geissler97771a32021-03-05 15:23:11 -060046 # Double-check to see if -latomic actually can solve the problem.
47 # https://github.com/grpc/grpc/issues/22491
48 cpp_test = subprocess.Popen(
Andrew Geissler9aee5002022-03-30 16:27:02 +000049- [cxx, '-x', 'c++', '-std=c++11', '-', '-latomic'],
50+ [cxx, cxx_args, '-x', 'c++', '-std=c++11', '-', '-latomic'],
Andrew Geissler97771a32021-03-05 15:23:11 -060051 stdin=PIPE,
52 stdout=PIPE,
53 stderr=PIPE)