Brad Bishop | 977dc1a | 2019-02-06 16:01:43 -0500 | [diff] [blame] | 1 | Fix compiler error seen with clang, The return value of this |
| 2 | function is not checked anywhere so in a way its useless but |
| 3 | still technically correct to return a value here |
| 4 | |
| 5 | Fixes |
| 6 | |
| 7 | ../../bfd/reloc.c:1638:7: error: non-void function '_bfd_clear_contents' should return a value [-Wreturn-type] |
| 8 | return; |
| 9 | ^ |
| 10 | 1 error generated. |
| 11 | |
| 12 | It has been fixed in master along with a larger cleanup and fix for relocations |
| 13 | |
| 14 | https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=1dc9e2d63e37839ff1768346b2e3f52e338baba5 |
| 15 | |
| 16 | Upstream-Status: Backport [Fixes differently] |
| 17 | |
| 18 | Signed-off-by: Khem Raj <raj.khem@gmail.com> |
| 19 | |
| 20 | --- a/bfd/reloc.c |
| 21 | +++ b/bfd/reloc.c |
| 22 | @@ -1629,7 +1629,7 @@ _bfd_clear_contents (reloc_howto_type *h |
| 23 | default: |
| 24 | abort (); |
| 25 | case 0: |
| 26 | - return; |
| 27 | + return 0; |
| 28 | case 1: |
| 29 | x = bfd_get_8 (input_bfd, location); |
| 30 | break; |